From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f44.google.com (mail-dl1-f44.google.com [74.125.82.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EB1617B506 for ; Sun, 26 Apr 2026 04:28:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777177706; cv=none; b=uqMrdyM8nk9/1K5zrKwG2Po0hzziGGs/MUzdE5FBCDkUNyEZm06sAPD17TTwmZUFcuX6k29aBHIt1BMJeO/K4S9PkO3boA8O2q700H8pVFXxe7BTZt1JxJQO7p/bjBtp8V3IqhFQZpMVV/K85onMVGJrKfn4EJ/GKpEPSqhvOb4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777177706; c=relaxed/simple; bh=xfsZPFOGlUAzwf6fVdJkq3KKTEcKYX3z+4B7g9iLlg0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HJr895xaqlpVIHqBm1YAS7rFeNqdNED0bddQqmQ1WSgGZnIgxP5SyVtp3odu6jXLujRy4M3dQqNP50IAcAQ2GTUr1bcT8sOKgsFzhoYllZA0ErMUOidor35oO9ESiSuiamHFQ2Mmi4Cm+EP8SHMoQt1DQGA2GJ9QxvxUe7QZ/0U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SXO8iZFh; arc=none smtp.client-ip=74.125.82.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SXO8iZFh" Received: by mail-dl1-f44.google.com with SMTP id a92af1059eb24-12c726ef332so12623048c88.1 for ; Sat, 25 Apr 2026 21:28:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777177704; x=1777782504; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QiNFy+Pe1YgCLRW9GTmW/74h6LPgkfDMo8eqshh65go=; b=SXO8iZFhFi1r/kJsdK5V9uWeO4e5mjKh31DUnYKRXyTk6K4SOPZeBGTKTvBwLtCw2x WhdS4aI4IF3BumeSNeupmPMRKTxSFTdXjVlYLH7gsV3/X+XR744w6M1AFfjLIVhcx2VM Sez89YAw0ylalI9gBzccKIDeC8jPucbFS87AoegssrB1lKvPbhFAT4P5viNVzCYrnvTM tVV4haq5o59yVFYwekBL0d1ZXlyLgYRK1mx/hQrA6rN/wcr+/r2PKZWChOFr3TovmNes 1dlA9fQtmAt6TA0tPEjc8+FOFPfSS/bOejh4NeVisAbgt2llYl4rUeZ1K8aCcjJAKzlQ B02Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777177704; x=1777782504; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QiNFy+Pe1YgCLRW9GTmW/74h6LPgkfDMo8eqshh65go=; b=IGzVHW3IW9A0J3fc/EmHFOgNScRZuWZVenQUageU4JW/kqn4zTg5HX/jS0eyIDnbFA KE1OAnPCmC7h/UjdwMtS/9WusDeI+xvS7c6r+zJ9g8APklqdgfrnCPcQberH7NGb9eKm jo9L0gvPSnrQEXZTcQUWb/mqXT6vwLRRsYZVxoe6n3S2nueIHZMIEH5mHh5pdOKT89SC bvCE3/ULqD5pkxkOcWGhuRXDF8Mj3wyIjGBa6QcbIlxhxrHbuw6fpR86V9sWtBU5eESu dSsPtAkWPVeGueDVn/UZ7OIVXi2XwUuTyGpYNfS2aNagyu2PI9JO4sTmbc4HxLmcWw+K O/MQ== X-Forwarded-Encrypted: i=1; AFNElJ/fd6cXE5L8Zn3HI5kYspFGmRhU6b0F+Sn98tApNPdiDH43/X/2xWXaEkCoualL/6HqzDAFJ98MnsBny28=@vger.kernel.org X-Gm-Message-State: AOJu0YzFi53qgDGDxmAXtZWsVEwA7I4JZKc9v6erZHsRWPNaMfdlUM5/ U/N1FgVuXWgy9hw5ntGNA6pPbTwKz4O/MY8BMsvX6I1LLMosGWGtiNSbBiZY1w== X-Gm-Gg: AeBDiesx80p0+0br2MEfrjtlat3A9FsE+UZDDd1u0Bdyq7k/eA00Dk7nzZ1YfCVXxsx PgEbXosJcPN3icesj/dCZ8UDGHYoLQcpUcHePoPDdmR40WaQHK+1FDIG0qY8e9JX1lzlWYteW8v HsRvG2ZqladyDuKO1H5KGK0A5IRBgIhOOtfToYXNT17BzAKt1/teiknitN8BNeBkc9/DastNqmQ vs8dvDKbc0s3i4aEEd6EFa0RrN5iUBjDDkuhHUxNht1Jfj9GO+mFEunmCcUNx5z18eJX4heKrjX +gkqa3k4JejHxGL8F7fpfGCAnN6wxJUB2ei8FzW7lXLVJFNE7f7XW8WJoaKRZRtxY47hLUimA8k 57RtSr/EHtH/kb0ZC8306A0Nm8DsjZeGCTfCKg6B/aFTFxMr/jieq6o0UYcVDuVctth2ltrQOpc 7GtOJbiRwKdBq1xmtPx4aKGGVamjOsevc9VVAUJC6RR6C0G7iF6lE1G6tyefHNdNzC7FVz9GeHe DE= X-Received: by 2002:a05:7022:fe08:b0:12b:f881:d8d0 with SMTP id a92af1059eb24-12c73f9987dmr19784551c88.18.1777177704040; Sat, 25 Apr 2026 21:28:24 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:f359:aa0c:530d:9dfd]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12c837f7feasm46022289c88.0.2026.04.25.21.28.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Apr 2026 21:28:23 -0700 (PDT) Date: Sat, 25 Apr 2026 21:28:20 -0700 From: Dmitry Torokhov To: Svyatoslav Ryhel Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/2] Input: isa1200 - new driver for Imagis ISA1200 Message-ID: References: <20260424071305.89503-1-clamor95@gmail.com> <20260424071305.89503-3-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Svyatoslav, On Sat, Apr 25, 2026 at 08:26:00PM +0300, Svyatoslav Ryhel wrote: > Hello Dmitry! > > I have a question regarding this sashiko comment > > > +static void isa1200_play_work(struct work_struct *work) > > +{ > > + struct isa1200 *isa = > > + container_of(work, struct isa1200, play_work); > > + > > + if (isa->level) > > + isa1200_start(isa); > > + else > > + isa1200_stop(isa); > > +} > Because the driver tracks isa->level locklessly, if an effect starts > and quickly stops, the workqueue might only execute once. When it > executes, it sees isa->level == 0 and calls isa1200_stop(). Since > isa1200_start() was never called for this effect, > clk_disable_unprepare(isa->clk) will be invoked on an un-enabled > clock. Does this unbalance the clock reference count? > > This is a valid comment, but I cannot find how this should be handled > among all available haptic drivers. Maybe you can point me in the > right direction? Maybe have a flag reflecting the true (committed) state of the controller that is both checked and updated in the work entity? Thanks. -- Dmitry