From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87F17431E72 for ; Wed, 1 Jul 2026 23:38:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782949083; cv=none; b=rI/YNWjN1QD0QwZeJOXyR/ptPaxvoSE+O9LuhrjtCusH002P5dq/xHhD52iRZnKVPTTJ9j3UGnu/5OW/ihMCykcfrpnKXtU8qL7AqA+/IGFBZIUhC3L7pXcAXMvIidSlR9X5QKT9GAkVy2TssbYLlo6PjdPwBjY6RxArNI3E9PA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782949083; c=relaxed/simple; bh=Ul+8pa7VUBwqQ9vUFj7cuT/cSE751FIa+VX8ioXeBlo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QqnNGNV5fdFs/Ro+3sUPf95pNOutXRDi4oPJ6AyQFYMMwXNuCmQpDAeb+5ZqcQlt3GBb9CcjapKLk/MSWRarlNRsA19h5zNDa6BrVtSCiMBrX98DvBV1uJH87pUBAcZTHDENa1lB9vr5iAtRyS4uVWQzq5IhwTDxnMXFISWv+BU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=au6dbQ19; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="au6dbQ19" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-5aeb99bc721so140520e87.1 for ; Wed, 01 Jul 2026 16:38:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1782949080; x=1783553880; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=OVCh6Lf8+nzzdAxzyPMuHDYAnEuNDpXn+opdGjJoaxg=; b=au6dbQ19ocDmFW8BHJn9lEOMKFQxa57yUbSs2zRJi99wQw+wZvrKCbkurmaCo1z6ba QqM2NXH4gWIXH+y1SspK8t40P1Q3TSZVDI/a69Lwf0KUdbQMnQBnZ9pkPaEQ0lCDYBrx 14+O5E19dxpdNBt2Fi2znI4X9LzOa6UX6FgZKAO8B/l0GcqH+RzLAs6PGLJ9a6CTr9j5 O11S5Bx7XBBec1iTqvBjlrAJHz4STwdd5cWuvF3505igPFahuo2K6LYpBaWIT8X0BQJU nDtmRGDQ+9IkksZVfVem2NBE23modaHpD8AmkTAi5DQcbyiypS/zQ1zp7dgHVK94vuo0 Gxfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782949080; x=1783553880; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OVCh6Lf8+nzzdAxzyPMuHDYAnEuNDpXn+opdGjJoaxg=; b=tBs14o/Ut1eYxAl4zxaUlGx+rRfGOjNrs6BiSeTyKEKJDbv9Qxsjeftztj8rGTRkL1 QI2GUbm4m8D7JFiLvmbWQ3kGFYDVWqWF071IRxl4ro2S5Nfzeo7eWUwGGh6QoSsv4EJe bG0C7D7nK4SLghOrL0uDh0Vk3aebKY5jVs3FnRK2t4cO0XytnGR3Qacq/KPu02cmJJPG eu4cxErlUPybWxgmunq3Y8Top4bfMLIh97z28i+3FDtGFf487lWBJItZc226X5+V96l5 YFk5awiv61vBntGnF76l6+kFml98ncfrDmxt5EADnXm3Rh4NWfXoGRnwXv0lG+XKP3rW tVUg== X-Forwarded-Encrypted: i=1; AHgh+RoaVNxBxRea1VgH6ZtPbWm6pnY+WLfZI7n7C6JgGDYllimRWMHoEe4jUM/DbeQzlpgr3wYGetblR9tWUR8=@vger.kernel.org X-Gm-Message-State: AOJu0YznjSSk878t6ehPdpQzh1o/AY7iqe4MdKEuw/oIZ1k4eyD6+WDc AnyiHxJ3YnfKKxltGFhybfw2dOFPjatfbprOyU29MpJD1+a8Eh85NEPgz0KQ6RHDkNU= X-Gm-Gg: AfdE7clT0O/ZzyOMmcidvy/WXAW9MSSAv/0fe7X67LlwecaCoJrQyaMsJDsnRf32so+ LjW8+cp0M2gbtwR7WSbpI204fREzTiY1OMMVcGriYbJfCENe11qFGh1JJ73f4Bf5/Vy71Lfy3bS p4RJaBbtYhuNZaIuMpZXXh72Uo2aNdIsbFFovC8g8qQ9TFM/ztjaHxXRFn8uvkw+YxSU38fDxY9 zdXHYk/x5VHhoGSCVB3874gtX6ZrjHYVwGPk6IWoQVYXn6CX71VkSUh8j+dpa0a+YtbWnomSqp8 +Os8YokzStsFPGfschMhYiaHAnYcx2OakfNMVdzNZBDgsc0C4Z4AggqBrtpcnYGFE5Xl+w7p+Vo SQQibRSX0tIuVEuoubriB0keKXQ5QZ/nrnrsUib4UxNIsGlxIYnPZVkuf9fklQ9DGN57NGDXY51 98EVez1+U2Ihu3quL53dhs5ww8VM9MPK32NcPa3QcU/kMFr9WuXSjTwrlm/ZB7OPo5/JI= X-Received: by 2002:a05:6512:4613:b0:5ae:b17a:2617 with SMTP id 2adb3069b0e04-5aec7435771mr533633e87.6.1782949079808; Wed, 01 Jul 2026 16:37:59 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aec89dc478sm300818e87.68.2026.07.01.16.37.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 16:37:58 -0700 (PDT) Message-ID: Date: Thu, 2 Jul 2026 02:37:58 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 1/2] dt-bindings: phy: qcom: Add CSI2 C-PHY/DPHY schema To: Bryan O'Donoghue , Vladimir Zapolskiy , Bryan O'Donoghue , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260523-x1e-csi2-phy-v8-0-a85668459521@linaro.org> <20260523-x1e-csi2-phy-v8-1-a85668459521@linaro.org> <7c564df8-5c5a-4b43-806e-5e017e5c51db@kernel.org> From: Vladimir Zapolskiy In-Reply-To: <7c564df8-5c5a-4b43-806e-5e017e5c51db@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/2/26 01:54, Bryan O'Donoghue wrote: > On 02/06/2026 22:59, Vladimir Zapolskiy wrote: >>> + >>> + "#phy-cells": >>> + const: 1 >>> + description: >>> + The single cell specifies the PHY operating mode. >> #phy-cells should be 0, because the PHY operating mode is well defined >> by 'bus-type' property of an endpoint on the sensor side, the opposite >> side of CAMSS/CSID as a CSIPHY "consumer" should not dictate the PHY type. > > So going through the list I don't believe this is correct. Be specific what is incorrect. > > Inserting bus-type into the PHY layer is borrowing from one domain > linux-media and pushing the concept into PHYs. It's the other way around, "bus-type" is an endpoint property of media devices, reference to video-interfaces.yaml to get more details about it. > phy-cells = 1 with CPHY/DPHY specified in the consumer, as was Rob's > suggestion will specify the mode. This cell is just not needed, and unneeded complexity should not be added. > Then to understand if we are in regular or combo mode, we parse the > ports/endspoints in the PHY node as we've agreed already. > That's correct, and while it's unavoidable to parse endpoint properties, a phy cell value will not bring any additional information, in the best case it's useless, or it opens a door to a clash, if different phy types are occasionally specified twice. -- Best wishes, Vladimir