From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Ai Chao <aichao@kylinos.cn>
Cc: Hans de Goede <hdegoede@redhat.com>,
u.kleine-koenig@pengutronix.de, mario.limonciello@amd.com,
jes965@nyu.edu, alexbelm48@gmail.com, onenowy@gmail.com,
platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] platform/x86: hp-wmi: use sysfs_emit() instead of sprintf()
Date: Thu, 14 Mar 2024 13:55:39 +0200 (EET) [thread overview]
Message-ID: <ae3ade7d-ca88-e2a5-aba5-9574e16e59c0@linux.intel.com> (raw)
In-Reply-To: <20240314063703.315841-1-aichao@kylinos.cn>
[-- Attachment #1: Type: text/plain, Size: 357 bytes --]
On Thu, 14 Mar 2024, Ai Chao wrote:
> Follow the advice in Documentation/filesystems/sysfs.rst:
> show() should only use sysfs_emit() or sysfs_emit_at() when formatting
> the value to be returned to user space.
>
> Signed-off-by: Ai Chao <aichao@kylinos.cn>
> ---
Thanks.
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
next prev parent reply other threads:[~2024-03-14 11:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 6:37 [PATCH v1] platform/x86: hp-wmi: use sysfs_emit() instead of sprintf() Ai Chao
2024-03-14 11:55 ` Ilpo Järvinen [this message]
2024-03-25 14:42 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae3ade7d-ca88-e2a5-aba5-9574e16e59c0@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=aichao@kylinos.cn \
--cc=alexbelm48@gmail.com \
--cc=hdegoede@redhat.com \
--cc=jes965@nyu.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=onenowy@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox