From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57AA32459CF for ; Sun, 26 Apr 2026 15:59:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777219173; cv=none; b=ANM6kWKdsjcnJMYnigG+AVrj7aqjyVQysWYgU3IXvlj6OqRqiZ3PZwICrMrqrCndduLbBs0bjmrN7iiuYiz21jSgVwb9woJ4dEeexBsT/QcR7a3CKuvGEIdvxNZoaPdkufcHisdiy5fBxOY/uOWGyUzE/lk39FUl1AanuyMztvI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777219173; c=relaxed/simple; bh=UMk17XFATjMPG5dAZfvWBkop20VNCYFQphs6l6VpWHo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AVI9GXta7ZYdupW4jsbVAU13eR5NMCwfFp7b/hynJlTNg3Q92/ZwBwWKD+UeG5CMF/ZKvDYZwVMvWca5uScDnCA0StQIt5EkDoja4D+aWba/Yz94byF26cb6/Te4/UaG6KRQdUn6JuMozvt+NImdWlNZCximIFX/+T0hkSoSqkU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VAgc9+dS; arc=none smtp.client-ip=209.85.222.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VAgc9+dS" Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-8eea23d01f7so519567385a.0 for ; Sun, 26 Apr 2026 08:59:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777219170; x=1777823970; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fo7d9J/wg1DQiQ3bpGIsE9EbQmrecHjxaY6UQYi40as=; b=VAgc9+dS+g1JhOgn+tSdBUFaEVMqTmzzE9ysAH4AXwVheuD+LiFDNEuX/lfBFKYqbf 6bYfNT7LhbDPuELhqOz0B37Yvc+ricedsvPP/xlztDTCtteS7t6imA9TqWw0cKaKmJ46 N6DM5l5SI2lcjIwd6XroFWboRtz7O6UGfxQ/dWqHLSX/Q8GWm8cFpdBaL4Mz5CXzMmAB hVGAksBMijbEm8Ud1mdK0s/+y3q6I4TB588wQ0DsR1zkpzNfoG3/eMFdDxRgdopmyySO KZdla7W8byMYz6K8lb3CyK2GqFZaKRvUh90zoFOHkG803fcg+9jlHgw+Aa0Ct2h1JxTS 29Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777219170; x=1777823970; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fo7d9J/wg1DQiQ3bpGIsE9EbQmrecHjxaY6UQYi40as=; b=Ks3IuKmteFEm0xmNvydKykKrwIQnW3HNDy/EHtfzRocu6klFLWd6i2cvV6bER5ARy5 3AhzWIj9nC+CuKiqOZrpUJUJmoIvyrHMCbN7LH6xU2wg+0yKvZJMeFGanfg11f3IR9Xq Dhadc6owrh1o88IegLqIPkbYOuKWIpr6geETjVcetXiB3Xj2soPSzQy3Zuw2Kn1/9hOq kFwMrMWyXTaJxln2bSTnSAn0gQh+yhAOgVboGfb7L10xxBUe97jxqSpnZMFWtvVXSxM/ Ofy86pYUxgJ0JirzxtKWYdiPadTz+xG2h/w1xZZf4adzl1QBq+0YlSFaSU5m4eYPw3Q/ LCTg== X-Forwarded-Encrypted: i=1; AFNElJ/i/DjqdfpLY91EgSq3xuxmo+ZP+VlvBkg3tqYKUdDl2U1uJ4ji4IzHjJrreO0tBfeH7Dj2hFIFVFHxqnc=@vger.kernel.org X-Gm-Message-State: AOJu0YzNnwqTAhYTUX36z9vRrvI2ZhnrDYu2wedqx51lzmMchAF+kpRO O5xhuwkuFTOHeNRp+KaH6j0eyS5chtDmrxF+zp1SS3CGGP1v861N7hwwQJGDfeYf X-Gm-Gg: AeBDieu9aTIyOSyfKat1zd9scWjwy6YTBQ6qG40XpM5kkbkrRG6OKtQgD8Yw/3tB57V 0refM0XHgnTx1kA+mUfODUPNyg2QBo4RtJixaf0P2ZU9a3zbchm9PG1go+nLXY64b8AuTxFyo5w Fx+T9ZCcsFomYPyC+dtb9rwTy/FQilHezBo0NTlC6yLlc1apg2Wp9/RvoO84njEYqSISALZl9QK lQb7tByp982LRfADdDFPgjIBscsIqZSLfcOMwQbl86ludNlkIP/nQj5S7fhWy5o1nf5hjynazua FETS4RxYuHwbRt56dcT01ZUygUT35u0aP1YWqjHkPldhXzOwAib/i6q5OW8HK5vEfEWW0ggLnl7 VHbHBW1T3ibBaxegMUAEn+pDOi9Yw4Dky9+mqjNlfvjYnZRTLLaO0JSv2cH5DTvEEhR+IgWXEot JPgRlQ7n6Ijp3NZSk8A/rMcrvF3CKnzuVMgTLg4ABlvhP9jVF0x8OcFNGenYSXw5yUj6U5kBs8M B1y9UkVvLhA X-Received: by 2002:a05:620a:4614:b0:8cd:8ee1:2eec with SMTP id af79cd13be357-8e78bce8d37mr5701845685a.0.1777219170249; Sun, 26 Apr 2026 08:59:30 -0700 (PDT) Received: from errol.ini.cmu.edu (pool-108-17-68-229.pitbpa.fios.verizon.net. [108.17.68.229]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8e7d8edb795sm2404340585a.25.2026.04.26.08.59.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2026 08:59:29 -0700 (PDT) Date: Sun, 26 Apr 2026 11:59:27 -0400 From: "Gabriel L. Somlo" To: Inochi Amaoto Cc: Ulf Hansson , Karol Gugala , Mateusz Holenko , Joel Stanley , Paul Mackerras , Maciej Dudek , Andy Shevchenko , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Yixun Lan , Longbin Li Subject: Re: [PATCH v3 0/2] mmc: litex_mmc: Set mandatory idle clocks before CMD0 Message-ID: References: <20260426112016.1370929-1-inochiama@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260426112016.1370929-1-inochiama@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett On Sun, Apr 26, 2026 at 07:20:13PM +0800, Inochi Amaoto wrote: > The litex_mmc driver assumes the card is already probed in the BIOS > and skip the phy initialization. This will cause the command fail > like the following when the old card is unplugged and then insert > a new card: > > [ 62.923593] litex-mmc f0004000.mmc: Command (cmd 8) error, status -110 > [ 62.949717] litex-mmc f0004000.mmc: Command (cmd 55) error, status -110 > [ 62.976606] litex-mmc f0004000.mmc: Command (cmd 55) error, status -110 > [ 63.002516] litex-mmc f0004000.mmc: Command (cmd 55) error, status -110 > [ 63.028442] litex-mmc f0004000.mmc: Command (cmd 55) error, status -110 > > Add required clock settings and initialization for the CMD 0, so it can > probe the new card. > > Changed from v2: > - https://lore.kernel.org/linux-mmc/20260424013615.470325-1-inochiama@gmail.com/ > 1. Remove the added function forward reference and add a new patch > for moving litex_mmc_setclk() function > > Change from v1: > - https://lore.kernel.org/linux-mmc/20260421025052.755471-1-inochiama@gmail.com/ > 1. use fsleep to replace udelay > > Inochi Amaoto (2): > mmc: litex_mmc: Move litex_mmc_setclk() to bottom for reuse > mmc: litex_mmc: Set mandatory idle clocks before CMD0 For the whole series: Reviewed-by: Gabriel Somlo Thanks, --Gabriel