Re: [PATCH v7 04/11] iommu/vt-d: Replace Intel specific PASID allocator with IOASID

Lu Baolu
2019-10-25T05:50:03Z

Hi,

On 10/25/19 3:54 AM, Jacob Pan wrote:
> Make use of generic IOASID code to manage PASID allocation,
> free, and lookup. Replace Intel specific code.
>
> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> ---
> drivers/iommu/intel-iommu.c | 12 ++++++------
> drivers/iommu/intel-pasid.c | 36 ------------------------------------
> drivers/iommu/intel-svm.c | 39 +++++++++++++++++++++++----------------
> 3 files changed, 29 insertions(+), 58 deletions(-)

[--cut--]

> @@ -458,10 +465,11 @@ int intel_svm_is_pasid_valid(struct device *dev, int pasid)
> if (!iommu)
> goto out;
>
> - svm = intel_pasid_lookup_id(pasid);
> - if (!svm)
> + svm = ioasid_find(NULL, pasid, NULL);
> + if (IS_ERR(svm)) {

Shall we check whether svm is NULL?

Others looks good to me.

Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>

Best regards,
baolu