From: James Zhu <jamesz@amd.com>
To: "Michał Winiarski" <michal.winiarski@intel.com>,
"Alex Deucher" <alexdeucher@gmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
intel-gfx@lists.freedesktop.org,
"Pekka Paalanen" <pekka.paalanen@collabora.com>,
"David Airlie" <airlied@linux.ie>,
"Oded Gabbay" <ogabbay@kernel.org>,
"Maxime Ripard" <mripard@kernel.org>,
"Emil Velikov" <emil.l.velikov@gmail.com>,
"Matthew Wilcox" <willy@infradead.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"James Zhu" <James.Zhu@amd.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH v6 0/4] drm: Use full allocated minor range for DRM
Date: Wed, 14 Aug 2024 00:20:12 -0400 [thread overview]
Message-ID: <ae511933-e191-4e25-a919-21504fa31b93@amd.com> (raw)
In-Reply-To: <nqsuaaibncfcnu3d5376ulujxfswbjwq3ptrivh6djpmvcpuih@fepbhcbik272>
Hi Michal
I did give Tested-by before. If you need Acks, Here I can give
Acked-by: James Zhu <James.Zhu@amd.com> for the series
Best Regards!
James
On 2024-08-13 20:18, Michał Winiarski wrote:
> On Mon, Aug 12, 2024 at 01:38:38PM GMT, Alex Deucher wrote:
>> Are there any objections to this series? We have been running into
>> this limit as a problem for a while now on big servers.
> I don't think there were any objections, just a general lack of
> interest - so there are no R-b / Acks.
> If you're interested to have a go at it - I can resend it.
> It should still apply on latest drm-tip.
>
> -Michał
>
>> Alex
>>
>> On Mon, Jul 24, 2023 at 5:15 PM Michał Winiarski
>> <michal.winiarski@intel.com> wrote:
>>> 64 DRM device nodes is not enough for everyone.
>>> Upgrade it to ~512K (which definitely is more than enough).
>>>
>>> To allow testing userspace support for >64 devices, add additional DRM
>>> modparam (force_extended_minors) which causes DRM to skip allocating minors
>>> in 0-192 range.
>>> Additionally - convert minors to use XArray instead of IDR to simplify the
>>> locking.
>>>
>>> v1 -> v2:
>>> Don't touch DRM_MINOR_CONTROL and its range (Simon Ser)
>>>
>>> v2 -> v3:
>>> Don't use legacy scheme for >=192 minor range (Dave Airlie)
>>> Add modparam for testing (Dave Airlie)
>>> Add lockdep annotation for IDR (Daniel Vetter)
>>>
>>> v3 -> v4:
>>> Convert from IDR to XArray (Matthew Wilcox)
>>>
>>> v4 -> v5:
>>> Fixup IDR to XArray conversion (Matthew Wilcox)
>>>
>>> v5 -> v6:
>>> Also convert Accel to XArray
>>> Rename skip_legacy_minors to force_extended_minors
>>>
>>> Michał Winiarski (4):
>>> drm: Use XArray instead of IDR for minors
>>> accel: Use XArray instead of IDR for minors
>>> drm: Expand max DRM device number to full MINORBITS
>>> drm: Introduce force_extended_minors modparam
>>>
>>> drivers/accel/drm_accel.c | 110 +++------------------------------
>>> drivers/gpu/drm/drm_drv.c | 105 ++++++++++++++++---------------
>>> drivers/gpu/drm/drm_file.c | 2 +-
>>> drivers/gpu/drm/drm_internal.h | 4 --
>>> include/drm/drm_accel.h | 18 +-----
>>> include/drm/drm_file.h | 5 ++
>>> 6 files changed, 69 insertions(+), 175 deletions(-)
>>>
>>> --
>>> 2.41.0
>>>
next prev parent reply other threads:[~2024-08-14 4:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 21:14 [PATCH v6 0/4] drm: Use full allocated minor range for DRM Michał Winiarski
2023-07-24 21:14 ` [PATCH v6 1/4] drm: Use XArray instead of IDR for minors Michał Winiarski
[not found] ` <10bb9689-9226-d47c-4cf1-7bf9d599456c@amd.com>
2023-08-28 21:08 ` Michał Winiarski
2023-08-29 17:34 ` James Zhu
2023-08-29 18:33 ` Matthew Wilcox
2023-08-29 18:35 ` James Zhu
2023-08-29 18:37 ` Matthew Wilcox
2023-07-24 21:14 ` [PATCH v6 2/4] accel: " Michał Winiarski
2023-07-24 21:14 ` [PATCH v6 3/4] drm: Expand max DRM device number to full MINORBITS Michał Winiarski
2023-07-26 18:15 ` Simon Ser
2023-07-27 12:01 ` Christian König
2023-07-28 14:22 ` Simon Ser
2023-08-08 13:55 ` Christian König
2023-08-08 15:04 ` James Zhu
2023-08-23 10:53 ` Simon Ser
2023-08-23 10:58 ` Simon Ser
2023-08-23 14:06 ` James Zhu
2023-07-24 21:14 ` [PATCH v6 4/4] drm: Introduce force_extended_minors modparam Michał Winiarski
2024-05-03 1:22 ` [PATCH v6 0/4] drm: Use full allocated minor range for DRM Eric Pilmore
2024-08-12 17:38 ` Alex Deucher
2024-08-14 0:18 ` Michał Winiarski
2024-08-14 4:20 ` James Zhu [this message]
2024-08-14 19:29 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae511933-e191-4e25-a919-21504fa31b93@amd.com \
--to=jamesz@amd.com \
--cc=James.Zhu@amd.com \
--cc=airlied@linux.ie \
--cc=alexdeucher@gmail.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.winiarski@intel.com \
--cc=mripard@kernel.org \
--cc=ogabbay@kernel.org \
--cc=pekka.paalanen@collabora.com \
--cc=tzimmermann@suse.de \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox