From: Florian Fainelli <florian.fainelli@broadcom.com>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
Thomas Renninger <trenn@suse.com>, Shuah Khan <shuah@kernel.org>,
"John B. Wyatt IV" <jwyatt@redhat.com>,
John Kacur <jkacur@redhat.com>, Peng Fan <peng.fan@nxp.com>,
"open list:CPU POWER MONITORING SUBSYSTEM"
<linux-pm@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pm: cpupower: Makefile: Fix cross compilation
Date: Mon, 2 Dec 2024 09:12:16 -0800 [thread overview]
Message-ID: <ae5eba41-e2ae-48c4-b25d-daece4d329ca@broadcom.com> (raw)
In-Reply-To: <20241129012006.3068626-1-peng.fan@oss.nxp.com>
On 11/28/24 17:20, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> After commit f79473ed9220 ("pm: cpupower: Makefile: Allow overriding
> cross-compiling env params") we would fail to cross compile cpupower in
> buildroot which uses the recipe at [1] where only the CROSS variable is
> being set.
>
> The issue here is the use of the lazy evaluation for all variables: CC,
> LD, AR, STRIP, RANLIB, rather than just CROSS.
>
> [1]:
> https://git.buildroot.net/buildroot/tree/package/linux-tools/linux-tool-cpupower.mk.in
>
> Fixes: f79473ed9220 ("pm: cpupower: Makefile: Allow overriding cross-compiling env params")
> Reported-by: Florian Fainelli <florian.fainelli@broadcom.com>
> Closes: https://lore.kernel.org/all/2bbabd2c-24ef-493c-a199-594e5dada3da@broadcom.com/
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Tested-by: Florian Fainelli <florian.fainelli@broadcom.com>
Thanks!
--
Florian
next prev parent reply other threads:[~2024-12-02 17:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-29 1:20 [PATCH] pm: cpupower: Makefile: Fix cross compilation Peng Fan (OSS)
2024-12-02 17:12 ` Florian Fainelli [this message]
2024-12-10 0:58 ` Shuah Khan
2025-01-07 18:56 ` Florian Fainelli
2025-01-07 20:38 ` Shuah Khan
-- strict thread matches above, loose matches on Subject: below --
2024-11-21 4:43 Florian Fainelli
2024-11-22 15:25 ` Shuah Khan
2024-11-22 16:11 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae5eba41-e2ae-48c4-b25d-daece4d329ca@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=jkacur@redhat.com \
--cc=jwyatt@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=shuah@kernel.org \
--cc=trenn@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox