Re: [PATCH 12/14] phy: qcom-qmp-combo: rename common-register pointers

Dmitry Baryshkov
2022-11-12T11:31:35Z

On 11/11/2022 12:24, Johan Hovold wrote:
> The common registers are shared by the USB and DP parts of the PHY so
> drop the misleading "dp" prefix from the corresponding pointers.
>
> Note that the "DP" prefix could also be dropped from the corresponding
> defines, but leave that in place for now.
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
> drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 24 +++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Note regarding the last phrase: I'd suggest leaving the DP prefix in
register names, it makes it easier to visually note & verify the
register block.

--
With best wishes
Dmitry