Re: [PATCH V7 14/19] famfs_fuse: GET_DAXDEV message and daxdev_table

John Groves
2026-02-25T23:52:12Z

On 26/02/19 11:51AM, Dave Jiang wrote:
>
>
> On 1/18/26 3:33 PM, John Groves wrote:
> > From: John Groves <john@groves.net>
> >
> > - The new GET_DAXDEV message/response is added
> > - The famfs.c:famfs_teardown() function is added as a primary teardown
> > function for famfs.
> > - The command it triggered by the update_daxdev_table() call, if there
> > are any daxdevs in the subject fmap that are not represented in the
> > daxdev_table yet.
> > - fs/namei.c: export may_open_dev()
> >
> > Signed-off-by: John Groves <john@groves.net>
> > ---
> > fs/fuse/famfs.c | 230 +++++++++++++++++++++++++++++++++++++-
> > fs/fuse/famfs_kfmap.h | 26 +++++
> > fs/fuse/fuse_i.h | 19 ++++
> > fs/fuse/inode.c | 7 +-
> > fs/namei.c | 1 +
> > include/uapi/linux/fuse.h | 20 ++++
> > 6 files changed, 301 insertions(+), 2 deletions(-)
> >
> > diff --git a/fs/fuse/famfs.c b/fs/fuse/famfs.c
> > index a9728e11f1dd..7aa2eb2e99bf 100644
> > --- a/fs/fuse/famfs.c
> > +++ b/fs/fuse/famfs.c
> > @@ -21,6 +21,231 @@
> > #include "famfs_kfmap.h"
> > #include "fuse_i.h"
> >
> > +/*
> > + * famfs_teardown()
> > + *
> > + * Deallocate famfs metadata for a fuse_conn
> > + */
> > +void
> > +famfs_teardown(struct fuse_conn *fc)
> > +{
> > + struct famfs_dax_devlist *devlist = fc->dax_devlist;
> > + int i;
> > +
> > + fc->dax_devlist = NULL;
> > +
> > + if (!devlist)
> > + return;
> > +
> > + if (!devlist->devlist)
> > + goto out;
>
> I think if you declare devlist with __free(), you can just return instead of having a goto.
>
> DJ

Nice...done.

John