From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Renjiang Han <quic_renjiang@quicinc.com>,
Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: Stanimir Varbanov <stanimir.varbanov@linaro.org>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/4] arm64: dts: qcom: add venus node for the qcs615
Date: Fri, 13 Dec 2024 11:31:07 +0000 [thread overview]
Message-ID: <ae83acc2-534d-49de-a0ec-b2117e5bd4d1@linaro.org> (raw)
In-Reply-To: <20241213-add-venus-for-qcs615-v4-3-7e2c9a72d309@quicinc.com>
On 13/12/2024 09:56, Renjiang Han wrote:
> + video-decoder {
> + compatible = "venus-decoder";
> + };
> +
> + video-encoder {
> + compatible = "venus-encoder";
> + };
To be honest, I'd prefer not to continue on doing this.
Adding a compat string to existing yaml might work-around the issue but,
it doesn't really _account_ for the issue.
I've posted a series to fix the problem
20241209-media-staging-24-11-25-rb3-hw-compat-string-v5-0-ef7e5f85f302@linaro.org
Either that or deeper rewrite of venus to remove the above dependencies
should go ahead.
I'm not in favour of willfully continuing to do the wrong thing,
especially when per above, there's a working solution for it.
---
bod
next prev parent reply other threads:[~2024-12-13 11:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 9:56 [PATCH v4 0/4] media: venus: enable venus on qcs615 Renjiang Han
2024-12-13 9:56 ` [PATCH v4 1/4] dt-bindings: media: add support for video hardware Renjiang Han
2024-12-16 7:52 ` Krzysztof Kozlowski
2024-12-17 3:57 ` Renjiang Han
2024-12-13 9:56 ` [PATCH v4 2/4] media: venus: core: use opp-table for the frequency Renjiang Han
2024-12-16 18:21 ` Bjorn Andersson
2024-12-17 5:32 ` Renjiang Han
2024-12-13 9:56 ` [PATCH v4 3/4] arm64: dts: qcom: add venus node for the qcs615 Renjiang Han
2024-12-13 11:31 ` Bryan O'Donoghue [this message]
2024-12-17 5:40 ` Renjiang Han
2024-12-16 18:14 ` Bjorn Andersson
2024-12-13 9:56 ` [PATCH v4 4/4] arm64: dts: qcom: qcs615-ride: enable venus node Renjiang Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae83acc2-534d-49de-a0ec-b2117e5bd4d1@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_renjiang@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=robh@kernel.org \
--cc=stanimir.k.varbanov@gmail.com \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox