From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3EE439A807 for ; Mon, 27 Apr 2026 08:18:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777277940; cv=none; b=XJiX0I5cVJ3Ry/vH3goguMynHo2MaGXeeYxZXB1NdC1GE+Ncnrve9OYeG7E3XSkpGRORTzksRGUpIgyjGurgN29rXtehGfSb+RPVbzB3GGsQyxkHKdJJAi4OgUU7nJY4s+4zzP3QeT/J2lG0dfm7StlVthgCLG9gvY4VDIlOX4c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777277940; c=relaxed/simple; bh=T0sbXkSjL1mT5QotmfhxZTftm4nSnzjJ+BmkUXi3jYM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WMlOv5m1A7eP3TlAtcsjCTMMmzlwIYvlSYJ5RvQ7NGeLK+IwUr98I6nkNMpITmP280bjM66JToA65zM3uRgL8rWJjol1rnhr5Z7kGt/8yQ6qdYYKDLj9nBnWyV2YEaGfSP0843VgMQDVqxFsbrkmJZ497y4HlnYVIITmb5WNWao= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mhQ+YYml; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mhQ+YYml" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-488b0046078so90469465e9.1 for ; Mon, 27 Apr 2026 01:18:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777277936; x=1777882736; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OcwOCXeAR5ogbgmVs39szOKmOHLVy+rS144H43uqveA=; b=mhQ+YYml93ZVTCjxI1uucOH/Q/JEWfIyzEfAK9SoM3l713JAMYMqrjtD2Wah9K9aqk 64tgJDHUXdhJSMDe0lSXfCxPfLj0SdM7FYnh+Q8wiARAe+C1OLzM7z9NgBAM1eyFcxX7 3y+bqf/ULxjLt5Fgu7qGBmXzTO3k5PnEj5kgAlN8TGBDMvru4YERXVYBhbmNcYWhTei4 kjXssmusBdUubaNtUTRPSQdItnrgsJr2rJif7Li6ciRXM0JCXBu/Sh0KrQw/bw8oeqm9 s08bsn8UrhegIqcbBv8fweGBhqfPQO5n5lysQxD9ucp4GNLha/q5ui3jwF1+6YcW3oup 7EKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777277936; x=1777882736; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OcwOCXeAR5ogbgmVs39szOKmOHLVy+rS144H43uqveA=; b=eHreBL9bNkbJJyJjTgHUjy9X7h43DIJsJf4/1iavJDYNyt7fLWZ1fcv1u3Xg+Bciwl MFio8YOfE7hjr9S/8tTUsEu+p/wnxznG5Peko2ZJcGvdyE35DlGuSptZUEgfPpnkPJXz L4yRn849+so9PR/reVUUxaWc72rkOfgYRMu3KKOYNTtrBrTPTZYE+quSOrCfjDVFVXiI oryPVaZbmVVYxwjXyZTZKYPLSfq+L8pntRZ3aVSVzAZgnPHdiPVWx/9ht+nRGQossHx/ D2Tj+OMtViRL1Z+qs09/DJXZF2/Y1AT6X4W76oR3tW059dnOioL/CMqnuzC85QPeOKUQ CY7A== X-Forwarded-Encrypted: i=1; AFNElJ/wXBLP0ZSheLKgCN8XWb+8L/hbUp+JMOCnF+4fiGa6jvzjPZZ8t6R13XG6r/ucaTpQ/S3apg8RzmuYgRU=@vger.kernel.org X-Gm-Message-State: AOJu0YxiqMRJGsqqSRWHgKz6wuAey7cEyHt2CgmbvplrKcqlWOg6vmd6 j6e2KKLFZMWSfQdlwze7jtrqJPBy1MS1/KOhf7utDRMibFrn5A85QvDL X-Gm-Gg: AeBDievGDeM8LEoCIieLLWBK7t/v9auB+mZL1z4lD9uZeQq/Xbu8gB2r0g83QtjR947 gA2Gu4rXIrlDFSwnrrxXW5lJVqCEhwkL0emcvxGO8pE5eSdBev8z094Zecy599mIEuVCHf+m9aL Hf5Vsm/xsyatj3g5Nzjh3JG/dRtGf+E2R3nJIY+o11qQllsFViNP1v8coHo3moUqy1TW4yELiQa yrf0MxWurjGfqbZwLQaTklzUgwBNVIdb4NOJ4ph7dafkhl3zWxrsIowu5fB0E6P0ZUx3xWcv6kg XD/vS3KrTIhuPA3/xi7si5asTZXNUvmX3r4TgJ7AA9p1stRHv7wK9l91+5GpCy1fvey4em+6hnJ 8pFUTm7RW1RbWUTQl5jJQp87mgZU1QJ23AkaYOxgg0Sql5azItaZqSeTkqLJOeV0pnJjNkLcODf UqCEcTzyW5ZiD4T+r/ttSmuOd1e1JPaw== X-Received: by 2002:a05:600c:5246:b0:487:219e:42d with SMTP id 5b1f17b1804b1-488fb750a1dmr588591455e9.11.1777277935677; Mon, 27 Apr 2026 01:18:55 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc1cfbf2sm814399735e9.15.2026.04.27.01.18.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 01:18:55 -0700 (PDT) Date: Mon, 27 Apr 2026 11:18:51 +0300 From: Dan Carpenter To: Maxwell Doose Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, gregkh@linuxfoundation.org, David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: iio: adt7316: Add error handling to adt7316_spi_probe() Message-ID: References: <20260426205039.125818-1-m32285159@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260426205039.125818-1-m32285159@gmail.com> On Sun, Apr 26, 2026 at 03:50:38PM -0500, Maxwell Doose wrote: > Currently, the return values of the adt7316_spi_write() calls in > adt7316_spi_probe() are unchecked. Add error handling to return early > and pass on the error code if we receive an error from > adt7316_spi_write(). > > While at it, move all three adt7316_spi_write() calls inside a for loop > to condense the logic. > > Signed-off-by: Maxwell Doose > --- A lot of the time, functions can't fail or if they do it means you need to buy a new computer and there is nothing the operating system can do to help you. spi_write() feels like one of those things. Plus we wouldn't add new checks like this unless they had been tested. regards, dan carpenter