From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A6353AE1B1 for ; Mon, 27 Apr 2026 09:00:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777280440; cv=none; b=PNdbIVtNczbIHNaF4KFSkmhPaGRJu7/4FFQHfDFxbVyp1gZgJEBgo40DSPURkfrMfrF8j71PbyqNZ0eVNWWEWBmdErPq47xWSk1nQFrsmt5TbyAYNzV/QZIaSrp1BjlXthScTNscRDREvY6+Pvy0/+fF2op0vTOtHiobDnx7aVc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777280440; c=relaxed/simple; bh=5ITOg6EqoWqXlZntp1Gld4HRcnn+N8uuRj9oXYJFars=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=vBSq2Sgdj8HA0xI72M21ztHdmT2s6xvOj36GuqniF7t5RusCDKqNx0D9L9xYPEx01hBUvgwPP0M21jLeqsIFI6hYt9PsL222UOpcIl33Ri5Pyz8NMw2zmDW0UxFCiN+OiZXUbKV0YZhCs08wkCD14+GE/WM3v5HrNf/0qBbDMp4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T5fgqGHt; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T5fgqGHt" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-488a14c31eeso81299435e9.0 for ; Mon, 27 Apr 2026 02:00:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777280437; x=1777885237; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=K7NAZlpKXzIndoIBQKSD2JPSIiZtdTLAwhYTzEj9A5o=; b=T5fgqGHt3Ku6xCeGPs1TZtEbjqfBjtxjNfgAHssoXLTeHWWlaAodwFbc0XLSLfZGaK 5PbQtqN9uZeTSA8hrXx+x+mLv5hqsoh8CArc5E4c2wta+VaX4jtrw/YDyq3LhfHy+9ur R6mXH6At7uCt+cgsrC0VsahZwXrUxblRB1Rd3FWURbLqB/AtWNINU1TL8iZhjA8KNySr iymK1SB4SuGCOsB8jZWYEdD8ge7niNdn2ug3B2eBcvNugtxRAw64q6v3EswPi8qU8Bhw DpCKYyhrq7626ORcaVmL01vNgDiQcLkwoUMXCB1S5ilWq26S0B4MAHOmM6N3AmqMnsyR UsVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777280437; x=1777885237; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K7NAZlpKXzIndoIBQKSD2JPSIiZtdTLAwhYTzEj9A5o=; b=Xh7Wek3SMEjCwQ1IgUdtwUr4ew5247xY5/vvsPlk5rxw0uis1kpT1fEQr5iViMQPM5 bTpT3jh/hLgmaNafOBQieSMWT1xgH9PLwExgLWKrJ3+Fi0grT8bZmDCe3HuYyUtifhVv 7Ct57FlBKAwcYT0IREd2f+baL+og+4jO2uH16sDtzXVx8WQbkMmUVxm506dNEBYDZCrO Wc3qu0uHhEd2iCNY6uRH3BtVzZ5YCZCNMzxxdSoMUDFD08T0RwGRivsZALr47XoejQrv Iztu+mC3Ez5LtfFneS4LN6H7ob8FzWLz8mj6ufRQ/UAcFnuc+wQA3zI87XX7hapefWwF kZeA== X-Forwarded-Encrypted: i=1; AFNElJ9VfPePxUhiV5H0nTq/mYqndFMWfucZnxFzgXLnFUzAuQxYHLKn5o9UkB5ZCOlpm0BB3jvYD4Pifk4rWyc=@vger.kernel.org X-Gm-Message-State: AOJu0Yxldq6XSEx7gu5M2JF6+rUwg8O3xNMW+Goqww0zUscHwVt8U9At G9BfoTH5YoizVwQHUQe4OTZw8XSj+tGQ3vTp7knxX1sj1n9FE1iG5We8 X-Gm-Gg: AeBDiet16RydpkAb2EgqJsI9UbeM0tE6+hpit2qPUCHt0q9zsFQ2Nimq+jmVBrCuLK8 3JuE7cpVOnZMnotEENUPAjeBVWqfTqsgvL0mqpuHjPU6gWn9JzG8i5BSXg4A8AV+4JADTQqUYDc TzpXxyxQMK1hlkFFkf3nKfhei7FViD1u77nK5qJ1+z+xzPNcQrVhj0INcCJwhAMaREheVIcDf4t Fnz3aKTdwb/3ZsqC0u1FgJxSDXJoH+wCCDZ1gs6NuWhNxYIm4/vQzAU8AsoMvB+1S17zRQv37L5 tzXGKqF24Y//5olKDE2ubA56v7+9Rs9nc8Y7GwfU++fnRNZxXslk6aBhj3TJ7+H9x5wVnC0hC2N eGS35o3tfLHQK3M+gsIZ9FjHadDRMRdmdsZx6eqWeP6s3HNcf943YjWCeBygxH6Bj6F3x1SYkGZ wzsod7Nq1qQsiTNrhWnXYTG/cyPnPsXQ== X-Received: by 2002:a05:600c:6085:b0:488:936a:6220 with SMTP id 5b1f17b1804b1-488fb782618mr541683735e9.21.1777280436814; Mon, 27 Apr 2026 02:00:36 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4e4daf2sm76856446f8f.33.2026.04.27.02.00.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 02:00:36 -0700 (PDT) Date: Mon, 27 Apr 2026 12:00:32 +0300 From: Dan Carpenter To: Maxwell Doose Cc: Greg KH , tsbogend@alpha.franken.de, len.bao@gmx.us, yoelvisoliveros@gmail.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH v4] staging: octeon: remove SPI, POW, and PKO typedef enums Message-ID: References: <20260418230344.44242-1-m32285159@gmail.com> <2026042615-ambulance-upright-3041@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sun, Apr 26, 2026 at 11:46:27PM -0500, Maxwell Doose wrote: > Hi Greg, > > On Sun, Apr 26, 2026 at 10:50 PM Greg KH wrote: > > > > How was this tested given that the previous ones all were not? > > > > What ended up happening was when I did my test compilation, I'd > forgotten to compile the arch/mips half of the driver. The test bot > obviously then caught that and it ended up being fixed. It's also > important to keep in mind that this is (or was, rather) my first > *ever* patch, I hadn't learned all of the tools of the kernel yet. I'm > almost certain that this revision is sound, as the test bot hasn't > reported any errors or warnings, and Dan Carpenter hasn't asked for > any naming changes. I don't care about the naming so long as you don't have two enums with the same name where one ends in _e (which stands for enum). But I also haven't looked at this code at all. regards, dan carpenter