From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1C442F8BC3 for ; Mon, 27 Apr 2026 09:11:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777281064; cv=none; b=cMqxrwcahMSsvivNors7qBdUeDpYvtBmpIkYrgdzb7CVjQLgS+FC2fnjxVv7eTDnPkaDOkEkHFtnIz8T/ijvrINQECbTqhpc3JksLIoH51beKcCYGnPRgYMocJ1S3CNXhVFCiwdyR39gSVB8zp24uWrQUxzzU0+uhM/h7fgm4lk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777281064; c=relaxed/simple; bh=GH5bX0PmlN2AKMnVu4z7dOKGObcLx8VTJGpQUxJzHlM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pG5n9J2KtK/9kxA5WKBxdzEzKBNi3bWWP8XoAkvWf/vDcmoV2NCuAcz8hMhaVuABxtAem81jRbYc+7ymwPUatSDQuvHNqVW9ls30RPpZdGIIiUh1tSS9AI3XM+IaZsZsBZ1hTjzt8xBX5hfznkFQ0E0iO1irCN66t0Ajq0IGZ8o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GMIWwoHp; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GMIWwoHp" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-488a88aeec9so124516025e9.2 for ; Mon, 27 Apr 2026 02:11:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777281061; x=1777885861; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XZntYVnVsrGv6F9rosThtG71miTc62QxvlA4TBCc9So=; b=GMIWwoHpTKeePBMV+nfoB0wkwi+VMHRl5Jsm5jXRvdTPeYT4ZKaLCZory7ySfnWa0/ wQUSJfJSLKyXhM7RH6teWHxqZjoN232xPAX8T3Js2hzAQcmVRM1QRlgs551O3W/1Fgze iGFiR5onCceLOSBTMJF/+hgK5TpklSqEgSzX/IUTE7hMoBt6HHq3v+8hLxaMGHsmE4ob eZbiCbFLSuEWpWlxQ9WoZuGYDGw9yM17NHoUHcvq/NmDAx5wY1XTUfRMfMffW58/5zWl ok2D5Oh81RsHcajBYPgMc8fPvpbYVxju4dptCzCO9C4ypGp9TpkCevJJwjQjWI87B/Bv 6e4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777281061; x=1777885861; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XZntYVnVsrGv6F9rosThtG71miTc62QxvlA4TBCc9So=; b=MKXkyhjjCyqy2KDWh0nAvVt18Jx48rWOlfmUNc785OgUhA3JO4uz/tZ+cZQWKG5LL4 tCOTaNNYjvtnlM6h+Fnq6yTyPDJ9iYLYcJ2WTQTjRrZFAFiS3ese7e8t1DQtdoE5+EI4 Lbc2mZt+T45Xj0P+FJVijMrm06QrvtGlwOqLQxl0v2kB/R8JL5OfYprSUbKES5Wxgo/d XB1QmfdyHgOeGDYcH4IhNFSkbJd1zx0mrEoPtl/zSnE5T4oLqGHVA0ATDg4ytqD2FLfP 0wjvZ/XKvJzAS+u4NZwf+vrEQgEw6AeU8Jow4poSBED5Bt4D95amcwlDFPPOVQ73r1W9 hcMw== X-Forwarded-Encrypted: i=1; AFNElJ/LsENYrsERUWQK3OQtbKCsz/rS2BbbGg81yLjlI/TLvvJH4UjgA5RSDkHTmVqHzLtWi6jUmzRFWyOyt1g=@vger.kernel.org X-Gm-Message-State: AOJu0YyqjPQqQtWQTZI9T+rCNkgJq2bfdXgiNj+AvQWuCEymJ3RQG15Z 4RYVzowkCb+xeWTv+bafl+gjgh6JW6FEOIsVRVVm3+4jGrKYORvzJqJ7 X-Gm-Gg: AeBDievpLGctyubEotJ+waRoE6ge1/CW7JPie8AO/oBCpJb/5GqTLh1aRBDbJAIVp6F cuis47znrQ8OO/vJ7lENTrUg2cswYr77qgtiOlRUwiCqYGrn+KSqOoFemfVT1LRfDVtZsoEXn11 X2etTcL8Ps09XYYgRALlTaJzwdzGnrnehHdlmnJAXFH+UKEqo3D2aw8uOAUOpyBgpQhxVUtzIJS vtCL4+QXSmzhzQhzQb6ZQgKnaKzor65vF6iDFRWhpH/hcWhvwyVGLuUMZp4bqSlYei8Mls1cjSK +eEwmHqpWr55N7CiOSylcJWOl4ubkGgElfyZwmf3hXBqzcnQMxPOVjQMmBAQJUEzkHi2MeMZ7lg AZhepi8XPjUVh7byN6K3TXNg3B6B39bDl1kDMRN+RZuqM1vy6J9AiFY2T3CF3sZMNnYlxEcKn7H usSBUWidNDZwgF4SndH4hNNDVCsOmHJw== X-Received: by 2002:a05:600c:1390:b0:483:709e:f238 with SMTP id 5b1f17b1804b1-488fb78ea6fmr613584525e9.29.1777281060727; Mon, 27 Apr 2026 02:11:00 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a55dc9f58sm928468665e9.6.2026.04.27.02.10.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 02:11:00 -0700 (PDT) Date: Mon, 27 Apr 2026 12:10:56 +0300 From: Dan Carpenter To: Salman Alghamdi Cc: gregkh@linuxfoundation.org, luka.gejak@linux.dev, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/5] staging: rtl8723bs: rtw_mlme: fix lines exceeding 100 columns Message-ID: References: <20260426225552.87114-1-me@cipherat.com> <20260426225552.87114-3-me@cipherat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260426225552.87114-3-me@cipherat.com> On Mon, Apr 27, 2026 at 01:54:59AM +0300, Salman Alghamdi wrote: > Wrap long lines and extract local variables to bring all lines > within the 100 column limit. > > Signed-off-by: Salman Alghamdi > --- This patch is too big and too complicated. If you send a patch that only adds newlines, then I have automated ways to review that but when you're adding variables and change code to use min_t() then it's hard to review. > drivers/staging/rtl8723bs/core/rtw_mlme.c | 284 +++++++++++++++------- > 1 file changed, 201 insertions(+), 83 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c > index 268f294528e6..cdc631464565 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c > +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c > @@ -52,7 +52,10 @@ int rtw_init_mlme_priv(struct adapter *padapter) > pmlmepriv->pscanned = NULL; > pmlmepriv->fw_state = WIFI_STATION_STATE; /* Must sync with rtw_wdev_alloc() */ > pmlmepriv->cur_network.network.infrastructure_mode = Ndis802_11AutoUnknown; > - pmlmepriv->scan_mode = SCAN_ACTIVE;/* 1: active, 0: passive. Maybe someday we should rename this varable to "active_mode" (Jeff) */ > + /* 1: active, 0: passive. Maybe someday we should rename > + * this varable to "active_mode" (Jeff) > + */ > + pmlmepriv->scan_mode = SCAN_ACTIVE; > > spin_lock_init(&pmlmepriv->lock); > INIT_LIST_HEAD(&pmlmepriv->free_bss_pool.queue); > @@ -125,7 +128,8 @@ void rtw_free_mlme_priv_ie_data(struct mlme_priv *pmlmepriv) > rtw_free_mlme_ie_data(&pmlmepriv->p2p_beacon_ie, &pmlmepriv->p2p_beacon_ie_len); > rtw_free_mlme_ie_data(&pmlmepriv->p2p_probe_req_ie, &pmlmepriv->p2p_probe_req_ie_len); > rtw_free_mlme_ie_data(&pmlmepriv->p2p_probe_resp_ie, &pmlmepriv->p2p_probe_resp_ie_len); > - rtw_free_mlme_ie_data(&pmlmepriv->p2p_go_probe_resp_ie, &pmlmepriv->p2p_go_probe_resp_ie_len); > + rtw_free_mlme_ie_data(&pmlmepriv->p2p_go_probe_resp_ie, > + &pmlmepriv->p2p_go_probe_resp_ie_len); > rtw_free_mlme_ie_data(&pmlmepriv->p2p_assoc_req_ie, &pmlmepriv->p2p_assoc_req_ie_len); > } > > @@ -369,7 +373,8 @@ int is_same_network(struct wlan_bssid_ex *src, struct wlan_bssid_ex *dst, u8 fea > (d_cap & WLAN_CAPABILITY_ESS)); > } > > -struct wlan_network *_rtw_find_same_network(struct __queue *scanned_queue, struct wlan_network *network) > +struct wlan_network *_rtw_find_same_network(struct __queue *scanned_queue, > + struct wlan_network *network) > { > struct list_head *phead, *plist; > struct wlan_network *found = NULL; > @@ -420,7 +425,8 @@ void update_network(struct wlan_bssid_ex *dst, struct wlan_bssid_ex *src, > long rssi_final; > > /* The rule below is 1/5 for sample value, 4/5 for history value */ > - if (check_fwstate(&padapter->mlmepriv, _FW_LINKED) && is_same_network(&padapter->mlmepriv.cur_network.network, src, 0)) { > + if (check_fwstate(&padapter->mlmepriv, _FW_LINKED) && > + is_same_network(&padapter->mlmepriv.cur_network.network, src, 0)) { > /* Take the recvpriv's value for the connected AP*/ > ss_final = padapter->recvpriv.signal_strength; > sq_final = padapter->recvpriv.signal_qual; > @@ -431,11 +437,15 @@ void update_network(struct wlan_bssid_ex *dst, struct wlan_bssid_ex *src, > rssi_final = rssi_ori; > } else { > if (sq_smp != 101) { /* from the right channel */ > - ss_final = ((u32)(src->phy_info.signal_strength) + (u32)(dst->phy_info.signal_strength) * 4) / 5; > - sq_final = ((u32)(src->phy_info.signal_quality) + (u32)(dst->phy_info.signal_quality) * 4) / 5; > + ss_final = ((u32)(src->phy_info.signal_strength) + > + (u32)(dst->phy_info.signal_strength) * 4) / 5; > + sq_final = ((u32)(src->phy_info.signal_quality) + > + (u32)(dst->phy_info.signal_quality) * 4) / 5; > rssi_final = (src->rssi + dst->rssi * 4) / 5; > } else { > - /* bss info not receiving from the right channel, use the original RX signal infos */ > + /* bss info not receiving from the right channel, use > + * the original RX signal infos > + */ > ss_final = dst->phy_info.signal_strength; > sq_final = dst->phy_info.signal_quality; > rssi_final = dst->rssi; > @@ -462,13 +472,18 @@ static void update_current_network(struct adapter *adapter, struct wlan_bssid_ex > &pmlmepriv->cur_network.network, > &pmlmepriv->cur_network.network); > > - if (check_fwstate(pmlmepriv, _FW_LINKED) && (is_same_network(&pmlmepriv->cur_network.network, pnetwork, 0))) { > + if (check_fwstate(pmlmepriv, _FW_LINKED) && > + (is_same_network(&pmlmepriv->cur_network.network, pnetwork, 0))) { > + u32 ie_len; > + u8 *ie; > + > update_network(&pmlmepriv->cur_network.network, pnetwork, adapter, true); > - if (pmlmepriv->cur_network.network.ie_length < sizeof(struct ndis_802_11_fix_ie)) > + ie_len = pmlmepriv->cur_network.network.ie_length; > + if (ie_len < sizeof(struct ndis_802_11_fix_ie)) > return; > > - rtw_update_protection(adapter, (pmlmepriv->cur_network.network.ies) + sizeof(struct ndis_802_11_fix_ie), > - pmlmepriv->cur_network.network.ie_length - sizeof(struct ndis_802_11_fix_ie)); > + ie = pmlmepriv->cur_network.network.ies + sizeof(struct ndis_802_11_fix_ie); > + rtw_update_protection(adapter, ie, ie_len - sizeof(struct ndis_802_11_fix_ie)); > } > } > > @@ -604,7 +619,16 @@ static bool rtw_is_desired_network(struct adapter *adapter, struct wlan_network > privacy = pnetwork->network.privacy; > > if (check_fwstate(pmlmepriv, WIFI_UNDER_WPS)) { > - if (rtw_get_wps_ie(pnetwork->network.ies + _FIXED_IE_LENGTH_, pnetwork->network.ie_length - _FIXED_IE_LENGTH_, NULL, &wps_ielen)) > + u8 *ie_ptr; > + u32 ie_len_val; Why is this not call ie and ie_len like the earlier code? Also the declarations should be in reverse Christmas tree order. long long variable_name; medium name; short n; When you start doing things which are more complicated than just adding newlines, then it gets controversial in ways you don't expect. For example, we don't really use min_t() these days. > + > + if (pnetwork->network.ie_length < _FIXED_IE_LENGTH_) > + return false; This is a behavior change so we can't merge it. regards, dan carpenter > + > + ie_ptr = pnetwork->network.ies + _FIXED_IE_LENGTH_; > + ie_len_val = pnetwork->network.ie_length - _FIXED_IE_LENGTH_; > + > + if (rtw_get_wps_ie(ie_ptr, ie_len_val, NULL, &wps_ielen)) > return true; > else > return false;