From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0305F2EDD78 for ; Mon, 27 Apr 2026 09:30:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777282234; cv=none; b=Ks4qbJRS7zrwT+HTpF0ECTEVxUCEd/FKudBeORf4OAtdWQCXSRJckkT17a2bqNkWYDWOSATjfHDo5AVtyWXVNN/1AfYpuUc0dcZmaZMaj19hGskVivMwWDXT1d1EkuqHdJXXsPRwP9VY5KXY2/iZ4jUZ7PSLxX5z+XIQFrM0uPw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777282234; c=relaxed/simple; bh=wUuV9kwRl57SBgN2ZqTgRyL8hlQOgooVOFrGpCvBmJ4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PvE9wwJQon/TQOpuVdPKUlld89F8r4YkJDrn9JUV9IrS/eln7xHNG/lL1omdzIqMLLS8gAIFhuxoAS+Z99xFUjRolUdaaM6pIKcL9s7nPrYJhWyPurDCB8Cx0qk9nchJZUqzoI2TsLh0Q98KZdM6NItMDPRF02YWfYj2VItrF84= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ZrB03SoQ; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ZrB03SoQ" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-488940ccfa6so928765e9.1 for ; Mon, 27 Apr 2026 02:30:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1777282231; x=1777887031; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=x+SZvW/F4GOHW6PySXy0XMzRT2W7+eZbjrzSkalzGFo=; b=ZrB03SoQIzPCcQXuW4nuSW2S5ykchDw+cRG5w9JiUNxz2zw/6QMvmWicvkE5Rcs1J3 T55oJEng8J9dgwCy6Gvy41F2Wjleplxvh+c0NpGN2+tqFZyWtr5sg4YtUq83jXTnQbF9 B2cDxGHUlC/PoKupOWyLzftd+pGpy+AhyhHI99nU0Sc04b3RGKFvy/ix1R5mD+buGmhV keNHv99wqcG9pQxhmqtozSV/jIQONwnvPQ19GhMZuWZz3loyzZkl6Yn0Omyl0MsYJFKq +Ut4+uHr1p3WTP5OQ//P8zBxUtg+nWo8Vdn47LkNPxKTR1E3ycNwkNquuirddL9GY4qL R2JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777282231; x=1777887031; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x+SZvW/F4GOHW6PySXy0XMzRT2W7+eZbjrzSkalzGFo=; b=j+dujHv6zXAJo86Fq6aEJb3to8iakmtUgQtPVc8jP/HDT1olW3/TZh1hsoB6w00esc 6gf8H8TjjE5NZNgYo+Kso8+ZDcA/aMFQf0imXLAY5OgwfqaXcYzmzm4fYIr76X9OmP/v gXPjT13/NRsIFttwOdiLr6hCa0oylOmRR+yogFiKM4F+XAYMxBS0aekgcNWfNujYnwb3 qvZSoYSUbo6Jng3m0Q5gJrSeGazh0GwFqIRNkPn3QF6ZY9GYweeCoAsbDhu97HRe9YYI 9FJ2t5pN29m1yz1L0WCTHJ1gcWnPZsgDIGrmAk0n8HkglKBlXwYTVBRuLqF9izPqaoPx o5tw== X-Gm-Message-State: AOJu0Yy0nJRi8zsNcAB7u3GdtFXc6HlNfJJQP0BR8LWtVD0I2/6SL1Y7 j2wa6lEB5gZj3jOrQl1EoZOYyogdQD6fettDDIth+xg2GILbaXo+VYH1wxEWbXhJ8g== X-Gm-Gg: AeBDieuzcJQg9MiRbEZQg9JUXRLBQM2DIOyl9YBkCnTB1li4JteAOOLhED+Q9FD5hXb x5rlqGRsgWAK/WlDp0jbzya4p3Fb++KY+oqnrKhBMCi6r2t6NZyX+RY97J/KQTMsi1g4fQEMO6s C8qkLl30UjyrBzNMFUQZT4RE0vfzHoxNPvKStxZVd6oshYKqNQR/0k0tjJ648d1yYiElIUp9gtq 8uckV8wa1UgHSvnEq7/IpcVtWZduhxhFn6paLToHf8GwjvMaRkClT7g85z7DmIV2fMlDPPMuv7W 7qExHn4SvxO3R71DJ8hSTwkWXNS3pdIqDK80KBQk29VC/KnLHd6b9dogmD0TOGMqLSTFyGyL67v MznoO6x+TK5N/MVvtx9q7yWiMcSD3oLnft17mwhPwpxLOgXGrPrD8nPH2j/3v05Mtuy9gZQajAv Ve62eYV3T4SO1XrXDelTEYR95ZeGuUG7nUFxOhCLps1YwsteKjMhwog7/pLX4jp6gqRIEapWX9j 8zPq1NsSvQ/mBV40J0= X-Received: by 2002:a05:600c:8a0c:20b0:48a:5d55:c194 with SMTP id 5b1f17b1804b1-48a5d55c46fmr1545e9.7.1777282230673; Mon, 27 Apr 2026 02:30:30 -0700 (PDT) Received: from google.com (117.15.199.104.bc.googleusercontent.com. [104.199.15.117]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fb7a0b60sm231015525e9.17.2026.04.27.02.30.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 02:30:30 -0700 (PDT) Date: Mon, 27 Apr 2026 09:30:17 +0000 From: Sebastian Ene To: Sudeep Holla Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jens Wiklander Subject: Re: [PATCH 3/8] firmware: arm_ffa: Align RxTx buffer size before mapping Message-ID: References: <20260423-ffa_fixes-v1-0-61189661affe@kernel.org> <20260423-ffa_fixes-v1-3-61189661affe@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260423-ffa_fixes-v1-3-61189661affe@kernel.org> On Thu, Apr 23, 2026 at 06:22:53PM +0100, Sudeep Holla wrote: > Commit 83210251fd70 ("firmware: arm_ffa: Use the correct buffer size during > RXTX_MAP") advertises PAGE_ALIGN(rxtx_bufsz) to firmware when mapping the > buffers but the driver continues to stores the minimum FF-A buffer size > in drv_info->rxtx_bufsz which is used elsewhere in the driver. Hello Sudeep, > > Align the size before storing it so that the allocation, validation and > FFA_RXTX_MAP all use the same buffer size. > Thanks for fixing this, Reviewed-by: Sebastian Ene . > Fixes: 83210251fd70 ("firmware: arm_ffa: Use the correct buffer size during RXTX_MAP") > Cc: Sebastian Ene > Link: https://sashiko.dev/#/patchset/20260402113939.930221-1-sebastianene@google.com > Signed-off-by: Sudeep Holla > --- > drivers/firmware/arm_ffa/driver.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/firmware/arm_ffa/driver.c b/drivers/firmware/arm_ffa/driver.c > index e6a051b20cb7..4dec7ca52f8c 100644 > --- a/drivers/firmware/arm_ffa/driver.c > +++ b/drivers/firmware/arm_ffa/driver.c > @@ -2063,6 +2063,7 @@ static int __init ffa_init(void) > rxtx_bufsz = SZ_4K; > } > > + rxtx_bufsz = PAGE_ALIGN(rxtx_bufsz); > drv_info->rxtx_bufsz = rxtx_bufsz; > drv_info->rx_buffer = alloc_pages_exact(rxtx_bufsz, GFP_KERNEL); > if (!drv_info->rx_buffer) { > @@ -2078,7 +2079,7 @@ static int __init ffa_init(void) > > ret = ffa_rxtx_map(virt_to_phys(drv_info->tx_buffer), > virt_to_phys(drv_info->rx_buffer), > - PAGE_ALIGN(rxtx_bufsz) / FFA_PAGE_SIZE); > + rxtx_bufsz / FFA_PAGE_SIZE); > if (ret) { > pr_err("failed to register FFA RxTx buffers\n"); > goto free_pages; > > -- > 2.43.0 >