From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DC4B3793BD for ; Mon, 27 Apr 2026 14:48:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777301293; cv=none; b=m4YC4pU463O0ivHw3zxg1XRqaHegHxW/DPQTAzYUwarwoY3aLeolTSWhkfpu63/U7VdZ/22SDdgwjP6mX1fbkx5lUqj3Fw7gMqu1MSmXNp1os1wANAdSd/NXpr0rG5ynwCF2v3tGI37R6Vtk4E4arwiwihTmYADX/xSQr3URkIc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777301293; c=relaxed/simple; bh=4xdstEQtN9d2VydlCsWuNlInxa0I2W3Gw3auRkkxvgk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZEGKkXyu7TuVdPDPTVjEoDA/xhTIbZOfTTXCGVF9bD0Yycb9DZdxs7FpLH1M5yoZJvClfdxcHw5bugWjAYwtwFkDjbzYxDNnQE9bhFljMP+RdWLd2zdhDspN4bHRYLYh1SIKTXBaVafDSa2Ug2ismn9pGtvTuhr5mC0Pe4g8Cp0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LOyOQezT; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LOyOQezT" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-43fe608cb92so7040685f8f.2 for ; Mon, 27 Apr 2026 07:48:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777301291; x=1777906091; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iTcA7y4hzbQFYWxx1WwEVcRWIQQQtI3KW/oxlJQFs7Y=; b=LOyOQezTnEpSTus6l3eJPZhGgW+9t9tiVJjAATWKRwcRi6wgXq/YQL4T6DZ//AhAZh RuB0ZxEoEYfeqrJskRzOCmqI1bwm4x+MYCsCt5A7YRd8oowpDuH6D3AYfGxhtlH41GLw tv4WR5+6caFO6mCiHF6uOnLPXWmbSZYt2QIdPn5EqOyPYLV5is8SDageHhm5DrAjkBFy JdBMa0sVS+TPfDlAQKRcf14pqljDps+EN7QSJ/gAh/68O0eDqiYtocHeEyD7gsuGZqn0 UiTwW/vD6g+oLUYJbXJqNBJ87uj2PvZBLyGK4s389+s93o2FrcZ6wzQwJ0dqdFHs+SuT lQNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777301291; x=1777906091; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iTcA7y4hzbQFYWxx1WwEVcRWIQQQtI3KW/oxlJQFs7Y=; b=j2kzEmH0x/PIPstHUVCFlVeAhvHLhNdY6u6UeKGazqHlVY5NX4HvJuf4AXBHFgjU+E WC+XWo6lHYe1UTm/b1cRTq8B8pzbw8AlVDyRPa5Q7JN7yaAFc+AZCPFhvXTEy5CIvLUn 0iiOQ0GDQt9H4x+AARXt7sfeu2Tp8c0F+r7QCXhrYK32fcajS06dPd1DUHCuMwvCh7Hc Cdg6NfTiv4ZgxJqH9cT2VGRiuYDu99dy1LD4fto7baabwYIxyy7UElqbzFYzLvSx18E+ jBoWwaiMj7d7/sj5B9Fmix5HPvpbQSdp+ZLjUD0vBZg/ylYMG4Izpv66azU1EntULxCD ETPg== X-Forwarded-Encrypted: i=1; AFNElJ9YzWI0QpFG1riztwOLco8s0/m7ts5yrL/DUAtEx52VJybuxX5pUkgpqfC9zWWVRY5H3/jmL3E/GqYJn8s=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7Sq4QnMQTRqjpzorcnOuyffO32rihA+5O5AaVxVggjZ5pBBIH 0zWshkQLyQ1Nr+o+AvZRQB3YrO5/JKGucV8cgG3ZsoDMvNZ1rIoCuRtL X-Gm-Gg: AeBDieuwXyxc/7uvmpvMiV9pOzPrcoTV7Nhqc3te3MhMO2sGO+S+t8rvLNfD2NWtH2P IizN6gSjcz9e21Oni05iz6mkhbtNrvvjIpcJ0iMIgLpCu0opDRw/5pElrJBzQlABenRBn33iRnn 32k/X5Q5+oX4FE7d6ITL8n+k4FsemEyh13G3ek4RrIMhQN3Cx01G6VVY0CYzL+NC5tDntdaXcFj NjurvSGWH7UXLtmU/kTrfOTiBTeI4a2DJn4mmhtLDK8zA/PEpEhQcJ9SEf3pUQip8GtlpayWrvy gTryRQkosN82dTPRSn9b/MdulAunXJMPHBmMhCxLvTPrVkYwqWdCJzSdEc8I11nx2WNufnMvOez dYUDaiaxDO8NCASn/jNbr4hJ+9IX30L4W4pqRovXu2cmBThSi4f5h5frL6x3sajKOn95l69PpCp 2kBjMTmRYKW5C0bpCTdXAS83J8/OmnBw== X-Received: by 2002:a05:6000:1447:b0:43d:a37f:8d5e with SMTP id ffacd0b85a97d-43fe3dc595bmr60078822f8f.18.1777301290496; Mon, 27 Apr 2026 07:48:10 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4e44f69sm85182307f8f.25.2026.04.27.07.48.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 07:48:09 -0700 (PDT) Date: Mon, 27 Apr 2026 17:48:06 +0300 From: Dan Carpenter To: Greg KH Cc: Alexandru Hossu , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, luka.gejak@linux.dev, stable@vger.kernel.org Subject: Re: [PATCH v2 1/2] staging: rtl8723bs: fix OOB write in HT_caps_handler() Message-ID: References: <20260427081748.3407939-1-hossu.alexandru@gmail.com> <20260427081748.3407939-2-hossu.alexandru@gmail.com> <69ef2c47.5d0a0220.2e33d8.bde8@mx.google.com> <2026042737-riding-bunkhouse-f8e0@gregkh> <2026042713-buffing-recite-c3d7@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Apr 27, 2026 at 05:45:11PM +0300, Dan Carpenter wrote: > On Mon, Apr 27, 2026 at 07:11:28AM -0600, Greg KH wrote: > > On Mon, Apr 27, 2026 at 03:58:23PM +0300, Dan Carpenter wrote: > > > On Mon, Apr 27, 2026 at 05:11:19AM -0600, Greg KH wrote: > > > > On Mon, Apr 27, 2026 at 12:48:38PM +0300, Dan Carpenter wrote: > > > > > On Mon, Apr 27, 2026 at 02:28:39AM -0700, Alexandru Hossu wrote: > > > > > > On Mon, Apr 27, 2026 at 11:17 AM, Dan Carpenter wrote: > > > > > > > We need a little change log here. I was hoping you would provide > > > > > > > a link to the AI review in the changelog. > > > > > > > > > > > > Hi Dan, > > > > > > > > > > > > Sorry about the missing changelog, will add it in v3. > > > > > > > > > > > > For the AI review link, I don't have a direct link to the bot output. > > > > > > What I know is from Greg's reply in the v1 thread on lore.kernel.org, > > > > > > > > > > What about a link to the email on lore? > > > > > > > > Sorry, I was on a plane with no connectivity to look it up, here's the > > > > AI review for my patch: > > > > https://sashiko.dev/#/patchset/2026041408-grill-mahogany-d1e3%40gregkh > > > > > > > > > > Ah. Very good. That's fair enough then. The AI is very convincing. > > > > Yes, but is it correct? That's the problem with these tools :) > > If we go with this approach then probably we should probably > change HT_info_handler() to match as well? No, sorry, I think HT_info_handler() is fine. I don't love that it doesn't return error codes, but since we set pmlmeinfo->HT_info_enable on success that kind of works as error handling. regards, dan carpenter