From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 331A72AD37 for ; Mon, 27 Apr 2026 11:35:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777289704; cv=none; b=IiZena7dRQBgsPEjy2OI6DJR7OZ83O1/hx11raYkOpiby69hmawqOeCy53ScDqartNw7IvMV3CH4wnraDp29BFf9KlfZvhiYclyfkRGR4lqKaJoqKfUFE/tmceRpt8i7ajO1RcTE+kXhSUZ1XLaQQkK0wwDP5pqH3fy2za+OZcQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777289704; c=relaxed/simple; bh=uE2xZcOHv1gDB5vI9Kbc5cyOqf0U/rRtTbeFJEwRxuA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HeQgqlUedAADlfMQEUsCsqilwicyikuiJTMpRIgMb4CgStZzO4DOdYeCvEpcqKBSvFNBv7/hCPjp6V9+zk5/mJMOghqbtt66h6RoWq7rAW7zzMHIticnwsedx8BmO2sScTj3/AivVin2R94A+t0hhPto0BpexUEztoJKQZFFfP8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DS4l0FHh; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DS4l0FHh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777289702; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a5jZeNVnCwNCFcUiWl3CXTI+K7OHOqggBIKz4nQ435A=; b=DS4l0FHhl6Gv45U0x2ZXLvbWCD7wCLEyUTi2K0oG577Ft4vmKP2ODpVCQ8XqeUaJCI5GGc FDE+J0BHSny/vyIuWEtkfQziYda0UB9hbRLqmVIp4VwoClUuCuD+QsCPKnBw9mGbxOl5J5 fDonNy0CuCEZNKHt5Z2lQ5uwII/r1Ns= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-421-2tMWPHoePyeqc--_EoA_Bg-1; Mon, 27 Apr 2026 07:35:00 -0400 X-MC-Unique: 2tMWPHoePyeqc--_EoA_Bg-1 X-Mimecast-MFC-AGG-ID: 2tMWPHoePyeqc--_EoA_Bg_1777289700 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CCC1118005A8; Mon, 27 Apr 2026 11:34:59 +0000 (UTC) Received: from fedora (unknown [10.44.48.22]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 9930019560B1; Mon, 27 Apr 2026 11:34:58 +0000 (UTC) Received: by fedora (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Mon, 27 Apr 2026 13:34:59 +0200 (CEST) Date: Mon, 27 Apr 2026 13:34:56 +0200 From: Oleg Nesterov To: Andrew Morton Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] dequeue_synchronous_signal: kill the unnecessary still-pending check Message-ID: References: <20260426122723.d1b180bf62b03a94cfe5d2f7@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260426122723.d1b180bf62b03a94cfe5d2f7@linux-foundation.org> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 On 04/26, Andrew Morton wrote: > > On Sun, 26 Apr 2026 18:21:29 +0200 Oleg Nesterov wrote: > > > The signals in SYNCHRONOUS_MASK are not real-time signals, so at most > > one instance can be queued. Add a static_assert() to ensure. > > > > Remove the list_for_each_entry_continue() loop and simplify the code. > > AI review asked a thing: > https://sashiko.dev/#/patchset/ae47bBSixfPpkQBm@redhat.com OOPS. Indeed I am stupid. I forgor that posixtimer_send_sigqueue() checks prepare_signal() but not legacy_queue(). Heh ;) Dear Sashiko, thanks for your quick NACK! Oleg.