From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0F6F30CD80 for ; Mon, 27 Apr 2026 11:31:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777289502; cv=none; b=h3FMglsZPDBEcG2HUCgKW0zZ0KE7uBMxdrrqe2Auvr5C+ZQlgfsP4nGAnmZ0ULZgTPD/kA1y0rt8UiRWhvVlrW++wcqtOolKoDMi9dQT8UP9QKIGa3ZagSH7tpN+9EoGv4mwkLXO5dCGGzvAXPYzky9HW7vy20eft3B1xtZ7gvI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777289502; c=relaxed/simple; bh=BSKeNmldHT4Gnyu3PoZpB2N+yepnrwlBw7UytxqJLDI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mJnOMAwurN7Dxei3tGFphCIYZ3FkrWkwm8jQsENjmgi7uTKYiyWdkekuybHUOR+78AzlFnJOUyriQSiEGmPDCUPnWbW5457lYBPcl9IhYG96Vne34dW61aXev88+dLYCNTdaNHvT8OUIXTA+NGie1TG0YjW3Wf42OtT4CRdsS44= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b2PS94mM; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b2PS94mM" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4852a9c6309so93294905e9.0 for ; Mon, 27 Apr 2026 04:31:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777289499; x=1777894299; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oczoMnPReZaIdQXexoCfPQETvMC08e4WB9/AECl0kH0=; b=b2PS94mMgMzzACiK70mb0ZWH1D0Vs8ne6WWmA9RT8Ev7tOHbNY0RqtHV0sXXsj2D2P kqYb+Xi4OAKLstwB9ol6sTalNCVhdjMN4Aiy96X5RGlhJD4S052mHWpbPGJlnhc3nSG1 zhqGi4vWEU0twTDDKM0GzyATuU/L4hp69Gg2ROJzPQiDRTY5T2Kb8Dy+aXnJySNW6YaA Kb/kVX3beKMXq7tZBrWWei28dMxglf2O25o7fEbY8MwLKr/3dg8sl3AQtbRr3qA5b6xK 2p0RYoOiScW557p38VFppwzg76pz2V+gh+SR7xg6qjf4+JkoNma5D7htj/dcD01qnaWR K2jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777289499; x=1777894299; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oczoMnPReZaIdQXexoCfPQETvMC08e4WB9/AECl0kH0=; b=pWJExpfEhsTGTy5PbUhmM70XNES7hGHicaxzZaX2f2445kFtMRbY4qKp8YDabyzDqZ TI2OTgXbeRkZETFDaoDQtMEyeilF1BqEhh4C+KhwF4mR6y7Os6EucVXObFGklpMF3yZ8 ewftEXb0xffnxKPaO3XQVc4KYEYm3O5ScsBtSYlbqzYdNUS9pIzNiVOPbCL86ysgkudj IUcxqB1bI5WNGfkUbAiztN9WMpcsIPdHeE+wSm7tX3XCa1ulOXQfMeZVch1MGG7bX+cF d8BOW5EWTNP/E0jtNnA/asjp3ie0uPZmlkVpbWvF1/e74YrweODXToWokFdIIrUsh3QQ I8qw== X-Forwarded-Encrypted: i=1; AFNElJ+IhPGeHOfKxPO++wC2bOoHD8zurKbzB7MkyJHcvBNCIaHwadCGMcXEeK8vqnaDV3Zh0Lg+c3BadgUnosU=@vger.kernel.org X-Gm-Message-State: AOJu0YzHh0NL6YRVta80s8FB20RUXeRhkuBNkrFzwR48tqiLLwD3BBD9 NGvNYzY2z32H+aFvodqzcXb+D5LUHz3Zjk8SMmI0cTJZDzokbvj+D90x X-Gm-Gg: AeBDies2N8sCw7ovWwXYVkupLXSmGhhoBx/SccAzaSZT+iPJ2XiWHL0rG3I7+jKYtzD q1oLxjZk/ozCAEHBlAbTxlIfkuSgonGMg7HQMd7GZzX9rOIOOvy/DK73hNBPaJiNShuKinv+uM0 ehotyC0bMlaAHSCHcPrFmseBkCdpPw6blhRRxOppuAS1BLo+p/2GJbLaR0j5ZEYf5yaqIXnOZuD ulqlVeCVSk8CDTJq/h4e+FTVUkwKs1Oh5DEF7zbXmnM3oizvmUR3nFwRXerhfEAxXm6A4s8W8TU HIVRnUZBlrgFtnjdw5Y1biCiAwdo8ylbK3WFpCNMMfrIf5C3VS50QVE3ohO3S9G/iJ62k21zzg7 tVwaP6U7S9R0TlkmwfC5iCNWhkOeumzFVE52d7eiVx5hPj8LufDNccRFEROwhtj++fGmjY0i/0W tc6dRh81n8j0SgEdbiMbU14hhqVgQdKGMpJQ== X-Received: by 2002:a05:600c:a31a:b0:488:b241:2c5f with SMTP id 5b1f17b1804b1-488fb785b7emr456261975e9.26.1777289498891; Mon, 27 Apr 2026 04:31:38 -0700 (PDT) Received: from pc ([196.235.239.18]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a59816b71sm221145305e9.1.2026.04.27.04.31.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 04:31:38 -0700 (PDT) Date: Mon, 27 Apr 2026 12:31:34 +0100 From: Salah Triki To: Andy Shevchenko Cc: Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Matthias Brugger , AngeloGioacchino Del Regno , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH] iio: adc: mt6359: fix unchecked return value in mt6358_read_imp Message-ID: References: <20260427085458.38546-1-salah.triki@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Apr 27, 2026 at 12:14:40PM +0300, Andy Shevchenko wrote: > On Mon, Apr 27, 2026 at 09:54:57AM +0100, Salah Triki wrote: > > In mt6358_read_imp(), the return value of regmap_read() is currently > > ignored. This is problematic because if the bus read fails the variable > > val_v remains uninitialized. > > > > The function subsequently assigns this uninitialized stack value to > > *vbat, leading to incorrect measurement results being reported to > > the IIO subsystem without any error indication. > > > > Update the function to check the return value of regmap_read(). Ensure > > that mt6358_stop_imp_conv() is still called to clean up the hardware > > state before returning the error code. > > Sounds like this deserves a Fixes tag, but the problem is that the whole driver > is written like this. Why does having this fixed make it special? > > -- > With Best Regards, > Andy Shevchenko > > You are right, Andy. I noticed that several other functions in this driver share the same issue. I will send a V2 that addresses all unchecked regmap_read() calls in this file and I will include the Fixes tag. Thanks for the feedback. Best Regards Salah Triki