From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A6AD355F36 for ; Mon, 27 Apr 2026 12:20:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777292418; cv=none; b=j8hc8e39snfE3sNsRnCdtHUXujfjW1FyfZWHiMlua1ZFxiN9eWwyz0MElE3/SNIFqGUqydBi922WJk489pnufJ2x1PGcDSE6p8ubdGCRhhh2RepY1gvB+Zpxczzc+QXUJ+CEzEFK1SMGWZILqHcAJ5I6JZfO6hWw9m+kwoLc8MI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777292418; c=relaxed/simple; bh=vfwoasfNMWJSpfAsK91lcEgHR2U+YXlN33dahW6hJhQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Dgm+D/iHEkX34OVKFeoRay5mwn7dTSfVKEKOJAgmpGDafmehwlrV46iNPmL3rmuXaAl2rKCxgPgHzUvyBNT1JiKXjjBkS6yY7Ln6/ScyLUq050+HadRH+1A2kPEbNj86C3Q3WRv05tN8lJa/iJgxFYBPUuY3K1sd4dH3uw/7qcg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LQJQBahN; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LQJQBahN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777292416; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gQCC3LXbAisJgiqfxp2+is0RYrYavB+fY/mgCdio8cg=; b=LQJQBahNqtdckMxv1LWLM3HLzNhsNRbBahG/Jz98/dXbHm5GeDcZAjr5RojnYcajpsYpg8 ci5mfhiPLeCfu4e8L+M2NngKMyg7bfR6V/fXMnaZcaiDJHae51d36GBnK7RTOCf4ZsR9nm f9TZmwea6RdIaeLQueTJOTiPJtpPdwk= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-244-aCvH4pPQMOqGkHWQoYxhOA-1; Mon, 27 Apr 2026 08:20:14 -0400 X-MC-Unique: aCvH4pPQMOqGkHWQoYxhOA-1 X-Mimecast-MFC-AGG-ID: aCvH4pPQMOqGkHWQoYxhOA_1777292413 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B28D81800464; Mon, 27 Apr 2026 12:20:13 +0000 (UTC) Received: from 192.168.0.21 (unknown [10.22.88.120]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 92E2A3000707; Mon, 27 Apr 2026 12:20:10 +0000 (UTC) Date: Mon, 27 Apr 2026 09:20:09 -0300 From: Wander Lairson Costa To: Tomas Glozar Cc: Steven Rostedt , John Kacur , Luis Goncalves , Crystal Wood , Costa Shulyupin , LKML , linux-trace-kernel Subject: Re: [PATCH 0/9] rtla/tests: Extend runtime test coverage Message-ID: References: <20260423130558.882022-1-tglozar@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260423130558.882022-1-tglozar@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 On Thu, Apr 23, 2026 at 03:05:49PM +0200, Tomas Glozar wrote: > This patchset introduces some new tests to cover more options, especially > histogram and thread options. Most of the new tests use positive and negative > output matches, sometimes in combination with action scripts, to verify that > RTLA is applying the settings correctly. > > Tests were reorganized a little, adding two new sections: thread tests and > histogram tests, next to basic tests. > > Additionally, coverage of existing tests is extended by adding new matches and > by extending tests to cover both top and hist tools where possible. For the > latter, new helpers check_top_hist and check_top_q_hist are added to engine.sh. > > As part of the new action scripts, detection of measurement threads is made more > robust by following child processes of either RTLA (user workload) or kthreadd > (kernel workload) rather than grepping through the comms of all processes, which > might have lead to false positives. > > These changes significantly improve test coverage and make the test suite more > against false positives from unrelated processes. Reviewed-by: Wander Lairson Costa > > Tomas Glozar (9): > rtla/tests: Cover both top and hist tools where possible > rtla/tests: Add get_workload_pids() helper > rtla/tests: Check -c/--cpus thread affinity > rtla/tests: Use negative match when testing --aa-only > rtla/tests: Extend timerlat top --aa-only coverage > rtla/tests: Cover all hist options in runtime tests > rtla/tests: Add runtime test for -H/--house-keeping > rtla/tests: Add runtime test for -k and -u options > rtla/tests: Add runtime tests for -C/--cgroup > > tools/tracing/rtla/tests/engine.sh | 15 +++ > tools/tracing/rtla/tests/osnoise.t | 73 +++++++---- > .../rtla/tests/scripts/check-cgroup-match.sh | 17 +++ > .../tracing/rtla/tests/scripts/check-cpus.sh | 9 ++ > .../tests/scripts/check-housekeeping-cpus.sh | 4 + > .../rtla/tests/scripts/check-priority.sh | 8 +- > .../scripts/check-user-kernel-threads.sh | 16 +++ > .../tests/scripts/lib/get_workload_pids.sh | 11 ++ > tools/tracing/rtla/tests/timerlat.t | 113 +++++++++++------- > 9 files changed, 194 insertions(+), 72 deletions(-) > create mode 100755 tools/tracing/rtla/tests/scripts/check-cgroup-match.sh > create mode 100755 tools/tracing/rtla/tests/scripts/check-cpus.sh > create mode 100755 tools/tracing/rtla/tests/scripts/check-housekeeping-cpus.sh > create mode 100755 tools/tracing/rtla/tests/scripts/check-user-kernel-threads.sh > create mode 100644 tools/tracing/rtla/tests/scripts/lib/get_workload_pids.sh > > -- > 2.53.0 >