From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5AE2A3C0639 for ; Mon, 27 Apr 2026 13:09:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777295348; cv=none; b=b1aK4KUY/rQ0SgKYCMel639kDb2yklv9aFbxaVT86eMeabxLWyoxNERm5J8v7YTdVbhQn0hsAL04cnNbVembRwZjnbri34eEtqj9Kxt9rBf/uroSE7e2EzwjinpQfn3XXkTI8YsZoOi1QvtBdMxb2qfbkfH9rdfpU1e/wwfNg+s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777295348; c=relaxed/simple; bh=3lEd+nslUIMJVRUD1dkEUnZLHxcKxZauUlrUhoeYug0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BQ/9zp+w7Pkt9RlEgmjd6xflwzD1uN4ee3fXa187NQuymgxVpqy4l8COgr2A4+pXo2rEeiPik4kuzllUWkoh2dvB2Rn7qtuWnyV/MFs8Meyi/nTzKBHfrMRf6uQVsNJ3lV8OltaKvDoyB1PUY7BIdn3H4hsQ3dnHFrpEW1bhPI8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=rRhUICjQ; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="rRhUICjQ" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C9F291684; Mon, 27 Apr 2026 06:09:00 -0700 (PDT) Received: from J2N7QTR9R3.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8CA463F763; Mon, 27 Apr 2026 06:09:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1777295346; bh=3lEd+nslUIMJVRUD1dkEUnZLHxcKxZauUlrUhoeYug0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rRhUICjQxC+J+gvIvJyw2LTbu4lmfhcdu1zeIon7sP5Cu1DlCLj8NmSfJ0DGmjqkh SgHNRlBLRGTIUfbLt5bYT6YTi4qbcOKfqbZ5feYtj/InEylUd9HrXR/LV4EzammT6n orT1KUk1/9VsJ7Xuaty1zbu1UTXWHvTETCRMH6rc= Date: Mon, 27 Apr 2026 14:08:59 +0100 From: Mark Rutland To: Catalin Marinas Cc: Breno Leitao , Will Deacon , leo.bras@arm.com, leo.yan@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, palmer@dabbelt.com, paulmck@kernel.org, puranjay@kernel.org, usama.arif@linux.dev, rmikey@meta.com, kernel-team@meta.com Subject: Re: [PATCH v2] arm64/irqflags: __always_inline the arch_local_irq_*() helpers Message-ID: References: <20260421-arm64_always_inline-v2-1-c59d1400514d@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Apr 27, 2026 at 01:26:18PM +0100, Catalin Marinas wrote: > On Tue, Apr 21, 2026 at 08:58:57AM -0700, Breno Leitao wrote: > > Force-inline all of the arch_local_irq_*() wrappers so they cannot be > > emitted out-of-line: > > > > - arch_local_irq_enable() > > - arch_local_irq_disable() > > - arch_local_save_flags() > > - arch_irqs_disabled_flags() > > - arch_irqs_disabled() > > - arch_local_irq_save() > > - arch_local_irq_restore() > > I'll queue this, thanks! > > I think we should also do local_daif_{mask,restore,inherit} as they seem > to be called from noinstr locations in entry-common.c. I agree we probably should mark those as __always_inline, but I beleive they're safe as-is. For their current usage in entry-common.c they're only called between between enter_from_*_mode() and exit_to_*_mode(), in a period where instrumentation is safe. Mark.