From: Dominique Martinet <asmadeus@codewreck.org>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Eric-Terminal <ericterminal@gmail.com>,
ericvh@kernel.org, lucho@ionkov.net, stefano.stabellini@amd.com,
v9fs@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] 9p/trans_xen: replace simple_strto* with kstrtouint
Date: Thu, 16 Apr 2026 11:07:04 +0900 [thread overview]
Message-ID: <aeBESEDdGyf53Ttw@codewreck.org> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2604081830330.2873990@ubuntu-linux-20-04-desktop>
Stefano Stabellini wrote on Wed, Apr 08, 2026 at 06:30:43PM -0700:
> On Tue, 24 Mar 2026, Eric-Terminal wrote:
> > From: Yufan Chen <ericterminal@gmail.com>
> >
> > In xen_9pfs_front_init(), parse the backend version list as comma-separated
> > tokens with kstrtouint(), keep strict token validation, and explicitly
> > require protocol version 1 to be present.
> >
> > This replaces the deprecated simple_strtoul(), improves error reporting
> > consistency, and avoids partially parsed values in control paths.
> >
> > Signed-off-by: Yufan Chen <ericterminal@gmail.com>
FWIW this patch 2/2 was apparently truncated (won't apply because of the
missing context line), but looking at V2 there doesn't seem to be any
actual change missing, so applied anyway...
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Thank you for the reviews!
I'm picking these up for whenever I can send the patches.
--
Dominique Martinet | Asmadeus
prev parent reply other threads:[~2026-04-16 2:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 15:30 [PATCH v3 0/2] 9p/trans_xen: fixes and parser cleanup Eric-Terminal
2026-03-24 15:30 ` [PATCH v3 1/2] 9p/trans_xen: make cleanup idempotent after dataring alloc errors Eric-Terminal
2026-04-09 1:22 ` Stefano Stabellini
2026-03-24 15:30 ` [PATCH v3 2/2] 9p/trans_xen: replace simple_strto* with kstrtouint Eric-Terminal
2026-04-09 1:30 ` Stefano Stabellini
2026-04-16 2:07 ` Dominique Martinet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeBESEDdGyf53Ttw@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=ericterminal@gmail.com \
--cc=ericvh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=sstabellini@kernel.org \
--cc=stefano.stabellini@amd.com \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox