From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2559A2110E for ; Thu, 16 Apr 2026 02:07:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776305277; cv=none; b=XFUs2oBhXfkjEatIQR9TgRLVx4q6HcikBkL21wM4LRzAkS6YQy12JnONYLC4H8I/rl7e61G2XcNG6bCctxu2n3nV2fZ622bLZ1lh7BLY8tOF/rgbcg+U5UAYkZ/hTDFNf90QbXx3oP60xJKjWIuCtrI7B6PkkOrrKn94EB9RDcs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776305277; c=relaxed/simple; bh=kLV2gmEqZTbzpg/+kgChtK1IvtfTklo7fcABvu5X1mM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=o6FV+Di5T2CAg85szBlnJBwRyGu83rFxcQkdwFuloit5h9C4J42XiZsXDzsXLJV2SDai+6+N/NX8VhBiVqF0pPFUldl0+oRFblYwSLTBafkp2GrkJ1A2R6eBJJtKOid4R8iZKl0VIif/Jt7FIPgGK2uI/GKvDQIznD27oka05MM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Un0F9wGj; arc=none smtp.client-ip=209.85.222.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Un0F9wGj" Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-8cb40149037so691943985a.2 for ; Wed, 15 Apr 2026 19:07:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776305275; x=1776910075; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4chQeqQ2PHe+PX11zkrN7TC+Z5lJzf/WQwlK8ZX4R80=; b=Un0F9wGjcnlPDmMZr1spggHsArtKec+N3JL8mn1ssQzV+pzPtC3PRH9GAMx4VEGBKo Fq3/Gs4E2xEEk3Xgvwa7BvKH9aR9OUSP/FWLfmYzKhP8vIkWwEnylg0xXw2vW9q6YkKg pmSlm3h2rwGnZO2b428RZv3XXjpD7Lg9qFIwkN1FdM0nWpqQpnAB6eSRHkceSD6wTfZZ eRNpO+cPQzliBGoVcqtwjeZQoSOz9Xa3GdJd/llmj/C7va5ci0ityke91t3fZg8mpI+Y brI99b4ypgeJCltm0Q+bpJmQ3mQftWkO40a7CqH8OSVC4BZw/o/nI+ERGAbkL1g0fM4n HsFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776305275; x=1776910075; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4chQeqQ2PHe+PX11zkrN7TC+Z5lJzf/WQwlK8ZX4R80=; b=BzU/NriMnWXMKa1HfNOooCgT6+aqvD5HlEo/urcxmcsb4vv1WIEFutMWF0RcfL8+jP H0Sg/tST0bjC/FWgaYikjMeMtQlRIxBbD+saTbpvLurd7kHdeXEE6E+ZmJd/UmIIRR/6 YkIJ/bmNyjiNhD4QCLFjyXkpVLR40MftiY+I2F3EHThV+GPo0fKkiMEJFX9jLcptQ+u7 IJAsBOG8MDr3XtqtfgBFxuC7t2cuxClJ7ZYokrko/plfIPE+iAHKFexsUWndFJGs9+o3 wES/rd+31gN8rV2fa6mMtzNykUezbeBfEJrmY7Wib9sZw4CBsEmKdOIJsDBgWnNEct8S MbGQ== X-Forwarded-Encrypted: i=1; AFNElJ+FcUUFkMEke1Rr/JsL0Rju0O5i1N6MbHpah80hTSzPFZzM9KQ0/Odc2vQ3r/D7JDqi+uToNMJ73cALBYU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6dgRscYnX1iTSnHlxoz5UDtvALm+KKSc2pLzgETqyGgs8DcuW +Nf8N8nxODOrsMmgZWgEvjhynmu0yIXxBIPBF4LF44i3aFBOtbPJJlph X-Gm-Gg: AeBDiet7X6bCRAKKlx5B/xXxeqWUAvhrCVy7r811ekyo/G7jCFOCI4Nk6A1yzvoAiCA v3SbWuDMcbsixzvvvbr+8awts5EelmxMZUb8rKZXD8Zn1CikMA47YYQTP/rgj3UEEy/oSKgK4NQ /UaU5A9Z/KT+ivN/fjvjCXKaYrGp8Jk/uoGCRrV89wPfr1bcIbO7enDkcXmsI9mY1rZwLMcGetA WEHLn+e1gtcMt68+8ohGx8Ywpo3d9Vm3Fz4T9/3qTbvtIUP4itfSbYqNxNMgxSmB93U50BuPImd sPjzktcimHMi01L8+g/SASzV9RKiWuePPgmH7dL0iRQgk6COjN5sPTH1mMisjTrDynebWxnlyBf rQbmd3iaPB2OBpEg/n0F41ajNiG9w96AcZ+CRJvlcmU1/tHaokGOlwxYFyad9hhT3XAKqJDVJHS djZ36LKcp9cgP55DqtXTfBmKakqKvT9QemUGL2 X-Received: by 2002:a05:620a:2995:b0:8cf:d5f3:9a1a with SMTP id af79cd13be357-8ddcfca7aa9mr3612178885a.51.1776305275080; Wed, 15 Apr 2026 19:07:55 -0700 (PDT) Received: from localhost ([184.144.58.243]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8e4ef33af5dsm260449785a.16.2026.04.15.19.07.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 19:07:54 -0700 (PDT) Date: Wed, 15 Apr 2026 22:08:35 -0400 From: Richard Acayan To: David Heidelberg Cc: Tianshu Qiu , Sakari Ailus , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org Subject: Re: [PATCH] media: i2c: imx355: Add support for 24 MHz external clock Message-ID: References: <20260414-imx355-24mhz-v1-1-9ae77bc6e7ec@ixit.cz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260414-imx355-24mhz-v1-1-9ae77bc6e7ec@ixit.cz> On Tue, Apr 14, 2026 at 12:12:10PM +0200, David Heidelberg via B4 Relay wrote: > From: David Heidelberg > > The IMX355 sensor supports multiple external clock frequencies, > including 19.2 MHz and 24 MHz. The driver currently supports only > fixed 19.2 MHz input clock. > > Refactor the clock handling to make the PLL configuration dependent > on the external clock frequency and add support for 24 MHz. Introduce > a table of clock parameter sets and program the corresponding EXTCLK > frequency and PLL multipliers to maintain consistent internal VCO > frequencies across supported inputs. > > The PLL settings are adjusted so that: > - VT VCO remains at 1152 MHz > - OP VCO remains at 720 MHz > > This preserves existing timing characteristics while allowing systems > using a 24 MHz clock to operate correctly. > > No functional change for existing 19.2 MHz users. > > Assisted-by: Claude:claude-opus-4-6 > Signed-off-by: David Heidelberg > --- We are in an open merge window for v7.1-rc1 and there don't seem to be reviews currently, but I tested this revision on v6.19.10. Tested-by: Richard Acayan # Pixel 3a