From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08B4023E320 for ; Thu, 16 Apr 2026 16:46:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776357990; cv=none; b=dCiNdgLUwt14jAPOKRPd75hZ25yyYs2ZU6bqpyFbqTNmsao0d3FajSAo8DUHFbSIUYwaKQIbG0lENLnKWJlXBh6dVW4BZPGfBeCvizO08Dedy5stDZc1eabpWIGlextHInMlouLa0uWQx380svvVgpp5adtA5SAK9Nj4c7Eq+yM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776357990; c=relaxed/simple; bh=rem8kgb3AqU5fIvtvZXdN3Z05fPs8+9yW+ACN+9nAGw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=U/4CwYzAJbmN5cadfdCoRrDPV0Ye44vClQcOq1m9e26V5eqBbnmplL7xx9cMlMeRXeeOH7/486jw/boloYpO72eA9aehYlsku2LhsByrSKvpBo+v35nXxMzKdMYzom6u18RAEUYrbCNiYg7a5cieDfkouNjtGfCunpQTF5V1vCI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hxPv6n5w; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hxPv6n5w" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-488af96f6b2so108673525e9.0 for ; Thu, 16 Apr 2026 09:46:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776357987; x=1776962787; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yx+tk5XR/nKhfzFOweyHScYa0wnstAD5I5LHNHccNpo=; b=hxPv6n5wqWuXLcfu4tXLaoESOCF2mcOdesU87WFYkK4oKOL1NCDfAjLibtz5cu/Ai4 yGMEkLIlfEVm+HnHPumKzl419F4udciMlHZiC6S/DV4Az1tZaNth3CyVqc5HjfkwX3WB OEwVgE9OxEOkti/IrMc9mrqhXejJsYxTpvap06WkNsBOQi845778bR69UnCOaNK1J5MR kxGKa51tAhohvKBPhWDqi7NRW8FoxI+4/X7O5AB+0nByvj8MZm1lDJLGK2mgtrvWoW4d 8z3g9r14Nlx/RG6TuN/WJR5KYXpSm4k6+powEPchkSAGK2AZz/kT0sVGVKv7labPo6+m K7DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776357987; x=1776962787; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yx+tk5XR/nKhfzFOweyHScYa0wnstAD5I5LHNHccNpo=; b=bzHY3QT4bcGHtQ6DPdBO+jxyUBxfPVotuIc5q+sigAylotQMv/e9WKgZrj7zAP+w5O gWaoF0VhR2YeaPOkp19jrvDlS/n+HNY/nvW+A8FyH9pr04DXwRAsbR9g4UgzkAiuU49n 9kuG+Eg/XDFDX7WZ82ihDPkj8WFf4bZBKSHLCX3gPYYqBFKMheAUIJY1bI//Q3McM52p Y6i4hFsB0NlKh0Ji/nOG2L5BFtrgG7wgls9oni9W+9C+wGi5e/l58RGnzRdOjEK768+c uLWaM+N5PlPaiw+Civ3vu+w6to4DybgvQiK5qtJ3VjQCJF+VeNio2aasPkc5Gx1b9+3q gJiQ== X-Forwarded-Encrypted: i=1; AFNElJ/4ZYIRnSoS9kgoRWCpZCRwBPxVluumbufO+xb00FZxlNavvxP+RS/XQ77tH+3tkhcevgJwr3Y3nX4cMc8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+SA6a1q/UIwETRp5J8QCZX91rUGgA9P3hbkbAYc1t7RfkLBrf tVJf6nkGOvWFLhAcE8jn170dgWll54EwrmLRjXSxSzve90Q6OeYE+bFK X-Gm-Gg: AeBDiesm41vS3+lXuqbfI1Tc+0N48Bh5LguYXv41Wu/xIvzsJ6RlkxCcO0sSUAXR5+X U/VWw4439192UNEb7l+rk5n9yQj2dd/AyAma4VzZfCM3eC1UgHVFN8/MX5yEGvtHd4EZXqD3wM5 ogEf9BTL3HwD1qZon71v2omOfPjz7LuuR25O7ue45/7AQ17I7SSW9OhTDlNC7LU5fURwa44LbIH YnFvyYtotPN8bRWGL5LEVDJYm2B7PnqW+7rKIi3tCbtvO+F7vEhoNBxzWHGAAx6Zz+iFYK0Afdy GqkI/IkTn+vb0GZIZmOl3oATRHbil6E7yQpxL31EsroVKHxpaSs6s9KZBVuH4c6CzK2p3Gt2HS7 AjPlevY3Siei3UFDOsaroLfqprJgo2Xwj06syu0NVI7lNoMAshfTQFchsHhFkdN6VFZFUS8PJZ4 r2HSt+zIaZOWQ6aknZPrE= X-Received: by 2002:a05:600c:4504:b0:483:8062:b43 with SMTP id 5b1f17b1804b1-488d68684fdmr378438015e9.19.1776357987380; Thu, 16 Apr 2026 09:46:27 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f581b9fbsm63217285e9.5.2026.04.16.09.46.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 09:46:26 -0700 (PDT) Date: Thu, 16 Apr 2026 19:46:23 +0300 From: Dan Carpenter To: Delene Tchio Romuald Cc: gregkh@linuxfoundation.org, dan.carpenter@linaro.org, luka.gejak@linux.dev, hansg@kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v4 5/5] staging: rtl8723bs: fix negative length in WEP decryption Message-ID: References: <20260415185501.440492-1-delenetchior1@gmail.com> <20260415185501.440492-6-delenetchior1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260415185501.440492-6-delenetchior1@gmail.com> On Wed, Apr 15, 2026 at 07:55:01PM +0100, Delene Tchio Romuald wrote: > In rtw_wep_decrypt(), the payload length is computed as: > > length = frame->len - prxattrib->hdrlen - prxattrib->iv_len; > > All operands are unsigned. If the frame is shorter than the sum of > the header length and the IV length, this subtraction wraps around > and length becomes a huge unsigned value. That value is then used > to drive an arc4_crypt() call that reads and writes past the end > of the receive buffer. > > An attacker within WiFi radio range can exploit this by sending a > crafted short WEP-encrypted frame. No authentication is required. > > Validate that the frame is large enough to contain a WEP payload > before computing length. > > Found by reviewing length arithmetic in the WEP decrypt path. > Not tested on hardware. > > Fixes: 554c0a3abf216 ("staging: Add rtl8723bs sdio wifi driver") > Cc: stable@vger.kernel.org > Reviewed-by: Luka Gejak > Signed-off-by: Delene Tchio Romuald > --- > v4: add Fixes: tag and Cc: stable (Dan Carpenter); carry Luka Gejak's > Reviewed-by. > v3: rebased on staging-next; sent as numbered series with proper > Cc from get_maintainer.pl. > v2: rebased on staging-next (v1 was based on v7.0-rc6 and did not > apply). > > drivers/staging/rtl8723bs/core/rtw_security.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c > index a00504ff29109..f3bc2240749a4 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_security.c > +++ b/drivers/staging/rtl8723bs/core/rtw_security.c > @@ -113,6 +113,12 @@ void rtw_wep_decrypt(struct adapter *padapter, u8 *precvframe) > memcpy(&wepkey[0], iv, 3); > /* memcpy(&wepkey[3], &psecuritypriv->dot11DefKey[psecuritypriv->dot11PrivacyKeyIndex].skey[0], keylength); */ > memcpy(&wepkey[3], &psecuritypriv->dot11DefKey[keyindex].skey[0], keylength); > + > + /* Ensure the frame is long enough for WEP decryption */ > + if (((union recv_frame *)precvframe)->u.hdr.len <= > + prxattrib->hdrlen + prxattrib->iv_len) > + return; LGTM. Thanks! regards, dan carpenter