From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1A4AF1CFBA for ; Thu, 16 Apr 2026 17:06:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776359207; cv=none; b=V56fzMddX+JvelXyF7IuTwqRtHkaXYD3jSGlycrTYsWEuret4oTXpGvLtkhZFcZNONFpgfNgZzr+FnfyQt9+p3FakI+WDASLk/N9W8U82u6ooKZFMxBpvfdEo7cijUkop3SlRBx1szveTsR4q6XHRY8r0znVYvT/Txr5kGJ0dfA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776359207; c=relaxed/simple; bh=OVIVQW1n1YOcsaC+g5g3s5sYNcQ0zELCPBG91eZ3tcU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RzWhBztSkWFiAkfjrW3lGbJIZq+AfntsGVdbktgWbgoXevYDsZ2WNEqInNK7SLcxMjfAZU6TdC+leyJyoMnwQbq7Q143F09VyB8f0SqtLwTyLPw+L7Fg6sJ3uR14tDuctpUTvMOGDEFw3nOXRZZ/fpfgfHZ3mtC0IjZ0acmLfv4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=Kb+opqh/; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="Kb+opqh/" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E9B8F1595; Thu, 16 Apr 2026 10:06:39 -0700 (PDT) Received: from e129823.arm.com (e129823.arm.com [10.1.197.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 216963F7B4; Thu, 16 Apr 2026 10:06:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1776359205; bh=OVIVQW1n1YOcsaC+g5g3s5sYNcQ0zELCPBG91eZ3tcU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Kb+opqh/hXrIthfZigkAdV6+zEx2TIjfvm8H6kvph757YZ6BYUvRPmhx/IuWayLb0 3E0/3iAOCvaPHPt9sLKEojEp1lfbZb4i5KAFBmnQ/Hsxz3+5nE5W9SlC0Hm6iqdFk8 BQNC63f+D7Hx6R3hqVMuhOtzc/VFk68nFr6EMsD0= Date: Thu, 16 Apr 2026 18:06:41 +0100 From: Yeoreum Yun To: Leo Yan Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, suzuki.poulose@arm.com, mike.leach@arm.com, james.clark@linaro.org, alexander.shishkin@linux.intel.com, jie.gan@oss.qualcomm.com Subject: Re: [PATCH v5 06/12] coresight: etm4x: fix leaked trace id Message-ID: References: <20260415165528.3369607-1-yeoreum.yun@arm.com> <20260415165528.3369607-7-yeoreum.yun@arm.com> <20260416165541.GN356832@e132581.arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260416165541.GN356832@e132581.arm.com> Hi Leo, > On Wed, Apr 15, 2026 at 05:55:22PM +0100, Yeoreum Yun wrote: > > If etm4_enable_sysfs() fails in cscfg_csdev_enable_active_config(), > > the trace ID may be leaked because it is not released. > > > > To address this, call etm4_release_trace_id() when etm4_enable_sysfs() > > fails in cscfg_csdev_enable_active_config(). > > > > Reviewed-by: Jie Gan > > Signed-off-by: Yeoreum Yun > > --- > > drivers/hwtracing/coresight/coresight-etm4x-core.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c > > index f55338a4989d..b199aebbdb60 100644 > > --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c > > +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c > > @@ -920,8 +920,10 @@ static int etm4_enable_sysfs(struct coresight_device *csdev, struct coresight_pa > > cscfg_config_sysfs_get_active_cfg(&cfg_hash, &preset); > > if (cfg_hash) { > > ret = cscfg_csdev_enable_active_config(csdev, cfg_hash, preset); > > - if (ret) > > + if (ret) { > > + etm4_release_trace_id(drvdata); > > return ret; > > + } > > LGTM: > > Reviewed-by: Leo Yan Thanks. > > Just recording a bit thoughts. As Suzuki mentioned, it would be better > to allocate trace IDs within a session. We might consider maintaining > the trace ID map in the sink driver data, since the sink driver is > unique within a session so it is a central place to allocate trace ID. > > We should use paired way for allocation and release. For example: > > coresight_enable_sysfs() > { > ... > coresight_path_assign_trace_id(path); > > failed: > coresight_path_unassign_trace_id(path); > } > > coresight_disable_sysfs() > { > coresight_path_unassign_trace_id(path); > } > > But this requires broader refactoring. E.g., the STM driver currently > allocates system trace IDs statically during probe, we might need to > consolidate for all modules to use dynamic allocation. So IIUC, Do we want to "map" per "session" and save this map information in the "sink" driver? or just use "global" map but locate it in sink driver? I totally agree for above suggestion -- unsigned trace id in the coresight_XXX function -- (but we need to add another callback for this) but I think we don't need to sustain map per session and it seems enough to use current storage for trace_id not move to sink driver. Anyway It would be better to refactorying wiht another patchset... Thanks. -- Sincerely, Yeoreum Yun