From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7B188165F16 for ; Thu, 16 Apr 2026 17:07:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776359264; cv=none; b=ubsKAYbtpKytP7Hc5fZYTgkkFrl9CKbjUiAqpupsqFcWNgG1aREtuH+Nlf+d/4TDyDNDxIUfOS50f4cvsixNbDAcmlGe70qKnpg/2cjW53d6M7UcYaXPVLAUEFPWqEIWcERLfPyck/u4Y22i19Il2sviNtJ9R5JNcuGoaMaApQc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776359264; c=relaxed/simple; bh=nDteDOdJ6WLwX1WgNSqExb0QSln8I4f8AiInBzL0914=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tT3WqW9rFfKPDxGZtJhIsgx22uVouI88y07EQHkrB4lAJQz7jGJJC36DxClev05M6WfZAs6W0yxPujEJriPYHk+diEZPjJFsIbXNMzREXiK5KgNVIcHB3sTT3NTuwQjQFI6fI9bhMv4M/+FqdDGgdH3Frs0NOOHpQA6vX2UJN4s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=nn07vt5T; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="nn07vt5T" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 36CBF24E9; Thu, 16 Apr 2026 10:07:37 -0700 (PDT) Received: from e129823.arm.com (e129823.arm.com [10.1.197.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 634C13F7B4; Thu, 16 Apr 2026 10:07:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1776359262; bh=nDteDOdJ6WLwX1WgNSqExb0QSln8I4f8AiInBzL0914=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nn07vt5TJP1Doge5mqk1fbgOpaHirrwXWwE0rEsPhtJt6BjthqZakDg2KW1qLgBgg CgrzpNmsYRGMB7XeiXn4B/tU9OjvwOku/aGvaqZ4rbPVKX4caimqgPAE5NAalW3LiO 7tw/7/dooFJBfN/uNdAEvEmkCx4BGEMvOVu/6UHg= Date: Thu, 16 Apr 2026 18:07:38 +0100 From: Yeoreum Yun To: Leo Yan Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, suzuki.poulose@arm.com, mike.leach@arm.com, james.clark@linaro.org, alexander.shishkin@linux.intel.com, jie.gan@oss.qualcomm.com Subject: Re: [PATCH v5 02/12] coresight: etm4x: fix underflow for nrseqstate Message-ID: References: <20260415165528.3369607-1-yeoreum.yun@arm.com> <20260415165528.3369607-3-yeoreum.yun@arm.com> <20260416151102.GL356832@e132581.arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260416151102.GL356832@e132581.arm.com> Hi Leo, > On Wed, Apr 15, 2026 at 05:55:18PM +0100, Yeoreum Yun wrote: > > TCRSEQEVR is implemented only when TCRIDR5.NUMSEQSTATE is 0b100, > > in which case n ranges from 0 to 2; otherwise, TCRIDR5.NUMSEQSTATE is 0b000. > > My suggestion in previous version is not quite right, thanks for > making this correct. > > [...] > > > @@ -1395,6 +1395,8 @@ static ssize_t seq_idx_store(struct device *dev, > > struct etmv4_drvdata *drvdata = dev_get_drvdata(dev->parent); > > struct etmv4_config *config = &drvdata->config; > > > > + if (!drvdata->nrseqstate) > > + return -EINVAL; > > For "nrseqstate = 0" case, would it return -EOPNOTSUPP instead? > > Otherwise, LGTM: > > Reviewed-by: Leo Yan Yeap. It's much better to return -ENOTSUPP in here. I'll change it. -- Sincerely, Yeoreum Yun