From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A803939021B for ; Thu, 16 Apr 2026 21:13:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776373995; cv=none; b=GECuIYxzdHV5PlHnoApu/KyUnSDbhHS9vB3GdoLVpvQ1+LUaCSTYLpxaHRHJ5N9xY3Lk5Qo1e6NbambeMf+10lJNMB56b43elfTqdHz7c+m9ir7JluAV/4xaihe+JxejmEuZOUky3RNvqCtDhHwzC7MrXVwS9yZnN6WjuAiLBGs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776373995; c=relaxed/simple; bh=ylIgGBrsynMgUEE9Fpi9j7e5GYbSPq9xC4feukwCu+c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OKE9Uuc968nnv92QonkkmuVPwTFp86cNL4WdaN+FBliew3ipKu33keDOL3ntD3iMs4X3Ul/SUu4y7g3xNgYUfIfLl3DqmfYjHp0ais8JQG9GlhaAFe8NrauQa7qi5MDOuG06mF4Yd5mCDuirowg9TzP0nW6kVkmGCmm2nSnUdKU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IVqyHiGr; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IVqyHiGr" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-488ba6366a7so68615e9.0 for ; Thu, 16 Apr 2026 14:13:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776373992; x=1776978792; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=uoEJmOIxrlFqmI8KPwSPmOaLExlLGjywVGJPpSntiHM=; b=IVqyHiGrgqrOoqutjn/2WweDTB3+8/rjq2MHIvBeEjw4Vq3GNalk0bDV236tqY21Y1 KabufCXREIhAn0qTcGbaqzmDFqNmOXxC2pF2in3LYMYNNIqeNHQxgVWOBKe2M49h7e36 bI5FICFJ0ENEIgyjTHiX5eheJo9+2wD2z0si7Hh3Y5M41LaXFcsT6cznpE/7puviy/ED 6fAXdWI9YbRdudTQxGKhAt3Hiq9onLptPqChWkuSzJb8nORI4iWjpGoj5NwUdkvfMFoh cIB3qU+gQR7D9oVNZUSU2AptpkTYqj1OU+HufslYCBQSkGTN/gIdLQIa00rfZA28SfNg nfeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776373992; x=1776978792; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uoEJmOIxrlFqmI8KPwSPmOaLExlLGjywVGJPpSntiHM=; b=UJO35IGwZwu3QErO9qC3n9UHmgR1OHsLz65rSMuLJsBAIxniB1Fa/bbkv18EBMETGb zqXJDsI0jr/zH1d72JQhr+tmn42mV/7ZZcxMesgLYiNav4RIzCEBysXPSCJL1fG6inAR WDlREpX4oWJFgi59eA/6j75zi1jCI9Pvxy3bPD7aIfYHQ6l4sFH/IbTeFbdfpLdPX2Jz r2ImQIvQ1N5FcnB5/0ZbeyvgMKjTGujWZrdCHHmRjhBmvpO+dEkURhZJUT4WK1N+nXDA vNGdwgtxrEGp8iDren8FrTqr3eyHTgtvi61CkfUZTyCn+KFPeLjvj3DJAUd3o6w1pCD1 L1mg== X-Forwarded-Encrypted: i=1; AFNElJ9pVTdY7V4mYETZqHDoe2OojXf0/zanG7LkwH9InWmtna378KzgWMVJdaMEsEfZcf0UDG34hGWei1eZgwc=@vger.kernel.org X-Gm-Message-State: AOJu0YzMVf25mVPE1fAuxm7HXqF5tFfwMPun76cocI8a+cvr5ljgfiAS 2TwgMiOTHpKHzQxtg4ToIiqCyA+6OpZYx3RtHmcJ5IyRH2janEVtSwvw X-Gm-Gg: AeBDievA+hSJgmAWBWm9Vm10sjY2X05fmS7mXEcuEaBdyfPuFsGwVRVdNaw0nyWgba1 LHRXoHfQsbsQ0EHWPlvOEFWEuUJ9isLlAp2cmUgWSy+MznMQEnnXfCJubUTNhbi5Dh7hVIVymvd 1oN4IC3C57jpTORoaLFYqVgcAREn76GoRtgs15FiTN6SYWuc5C+Ga959MGwQ3JzwUIu8xdDe6Zw wZjJSaE3tU7Maxi4aVd0jEqadOTRAkZKSJ1tqQvYtrjJ8nSuicah+BnUVXAm1wv/9LTkIxhKsVw CrbgzqMH3rLs0Cd+lNiKOA6d5rfRMT12ofTfWnbGUFQF8CsqSX/TEZWGWm9JdSz/EblO1GvPLY1 zINNRisjBnw9xkebJVn3sdy6ZPtiTMQweviCRyvCJEXRVBPJqJ4hJy/1QqG05+iKeAhvM+pktEa 6NDhrCPMBQ5/EzOuTd6MhwRAatw00jEw== X-Received: by 2002:a05:600c:8488:b0:488:a882:c7 with SMTP id 5b1f17b1804b1-488fb77b575mr2718445e9.25.1776373991754; Thu, 16 Apr 2026 14:13:11 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fb7b2634sm1094485e9.28.2026.04.16.14.13.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 14:13:11 -0700 (PDT) Date: Fri, 17 Apr 2026 00:13:07 +0300 From: Dan Carpenter To: Maksym Pikhotskyi Cc: gregkh@linuxfoundation.org, ethantidmore06@gmail.com, starpt.official@gmail.com, straube.linux@gmail.com, sameekshasankpal@gmail.com, arthur.stupa@gmail.com, luka.gejak@linux.dev, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] staging: rtl8723bs: fix stainfo check in rtw_aes_decrypt Message-ID: References: <20260415184727.285753-1-mpikhotskyi@gmail.com> <20260416195338.324428-1-mpikhotskyi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260416195338.324428-1-mpikhotskyi@gmail.com> On Thu, Apr 16, 2026 at 11:53:37PM +0400, Maksym Pikhotskyi wrote: > The null-pointer-guard was incorrect, returning _FAIL on valid pointer. > Invert the guard, so it returns _FAIL on invalid pointer. > > Fixes: e23ad1570028 ("staging: rtl8723bs: use guard clause for stainfo check") > Signed-off-by: Maksym Pikhotskyi > --- You need to put a little note here under the --- cut off line which says: v2: rebased on linux-next. Also added another fix? Please send v3. You can still add my Reviewed-by tag though. regards, dan carpenter