Re: [PATCH] staging: r8723bs: reduce nesting

Luka Gejak
2026-04-16T11:20:33Z

Hi Maksym,
Your patch doesn't apply cleanly on top of the staging-next branch.
Recently, we merged a patch that replaced is_broadcast_mac_addr() with
the standard kernel function is_broadcast_ether_addr(), which is
causing conflicts. Additionally, someone recently tried to do a
similar refactoring just for rtw_aes_decrypt() but introduced a major
bug. They wrote if (stainfo) instead of if (!stainfo), causing it to
fail on valid pointers and crash on invalid ones. Your patch actually
fixes their mistake. Could you please rebase your work onto the latest
staging-next branch and send a v2 series? It would be best to split it
into two patches(a patch series): first, a bug fix for
rtw_aes_decrypt() to correct the if (!stainfo) logic (please add a
fixes tag), and second, your early-return refactoring for the
remaining functions. Also, don't forget to fix the subsystem prefix in
your subject line to staging: rtl8723bs:
Looking forward to the v2.
Best regards,
Luka Gejak