From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 278763815DE for ; Thu, 16 Apr 2026 21:20:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776374404; cv=none; b=Q2RdRWScxIG13RHKtw8/gH9KtgLSDOugQTnjtP2SNIDcbAdB62wfgKXHVzuZ34aawZWnW0xbwIy+L5B0P35EtySJb60HA6fB/hXHb1uMX79ttuXsVasCAdQXAVMDaaCYa8k/m3E7a2y36hsxSU5XoOzpPdpVLO8xQBehgrGsxv8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776374404; c=relaxed/simple; bh=VHtF7CE3q/wy5vzdJ/EtjoUiYyfjCwo7Js8hD/IKvBw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=r0ffEZuVpRpu0dMjQbrVqtY6QJE8gvyVzJUrSXRYQwSbQUVDHOlm96ESAo2+4nofq0DajQFJVE/hxZcR/W0GzaksFSypfoYhMRQ+tFm2zCoFH3b4sU9FA72m0FHwF1inS+dpJ0246kG76zHGuu4BB9ptAhW4dilHQ4kNIqJceW4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kAYF7Chx; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kAYF7Chx" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-488c21c636dso52023535e9.2 for ; Thu, 16 Apr 2026 14:20:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776374400; x=1776979200; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=o2uW1n39EkbYnhmpWm78u6mtacB6MzGeEndluD+Ii8w=; b=kAYF7ChxQhQDNQ7Qs45N1SSJo0KoKXvHjDWxBz5oOISCltCxTyPR+sbUPgXDHB0vBY yM96u48ZW80+5zFkFnM740cUu7s6z6NEfvaUrzWed192bRfXkvFsPs247CXN66W7yc5O DA54QPIBq0gCRnkYapxcQhTNtAlRVoCGdOqBc/qHms9b6tGRjAL2g17MSztwUn7PMm5B CP/oLg5OrtuTtYwl11DXtw7nLafSq6vmoNVD+vJxL77LQWnAS63caGI+HOveHGysb/hM eCQdGlRqdD3yxCC+0qqMGmuTnc5Qu6mp4Qzav2tYIgOG7MD+if8Jlg0ZSQ7c1DoFmfmf KyAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776374400; x=1776979200; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o2uW1n39EkbYnhmpWm78u6mtacB6MzGeEndluD+Ii8w=; b=mP0XHB50hsGuIRHHKMuwN3lzTskyR+ycsoJs0m6uljlznGC1iUUJ4n40OsIbcDPMaW tFopkgY7GQgoQukfek70x48V9yvYGv3n0WhCUM2B8lFhZTVS7X/YpsviZFz6QCDTmMYa YAuGda67cC5z7wKy8QgfbBx0qYJTm0wd3/to5zRNpQoa+XrUSK97wGmKjzWcFO5RKIrZ NjVBN0f96EEZecLMvk3qMXpI2IDqOXdg6FAgJt1eRS5ejHSeD5X347764jU8Ts996kAI Rj3OnMfB+eTFZpdP5QGqWrUp9UZdxjK3vx8GD6AX653qpitGSyKyS6/da/B80fvn4M8y 0QRw== X-Forwarded-Encrypted: i=1; AFNElJ9M4GUoELdEq65hKx14SUKGU2p/j6gkgEcyQM7u+b3qQ3XlK4lEYQ90uHuHvluYaLO7kjFi+x+8i1MbOtE=@vger.kernel.org X-Gm-Message-State: AOJu0YzGQTRddo+Ik+sd88Ma5BJZfNvN1DMEJbr55f/WUhLeujLlmGhl 2njp5gY2qIBKla4jlfyMPH4k6s7/128m9GkJNqH9x5rjHFKfUCTZ19KC X-Gm-Gg: AeBDiesdm5EymLE//thJ8npxrFDkt65TrHUoPrpr1Ihq9xk1yH56/eRiBWQLTwPYUt/ SCfZ8OnWaqP6KiGBvVzGQCkgNpAczcdN2MWNmBT5mXkUAohk9IOuDwSa1mZnCHjq3SJCDGAg/xm EF7j/Xd9FJ9OcJ8GpxZ9vLh0NPUvb0iiCuyLQ/r0v5BUAI8lNwh0RuWQySiDDSsnxFpZenoLOb5 5EE91hKMOt30Y4heafi6RLDqp08rRPdE0w2HVcUCPFtyDfzIEvzmwLXqpiwBITq0BmhLi09kGGQ iuXQc5bdd6qbR2gxbluOT5sqyM/7pMrRcqR0ILWi3nYxH/uHKeyr9nDX/xeH5YvdzNIwg6KQtws QLbvmF9tjDfa661hUOi1c98dhSXZepx7ERiKzxeV75BEoW4K4UUF/cM4v5X7aKAgwuI5qaNsMxc 71nh03QlTIJCPkBMVTjcfJlIovX+GCvw== X-Received: by 2002:a05:600c:c0c8:b0:471:700:f281 with SMTP id 5b1f17b1804b1-488fb78b8c5mr2081115e9.25.1776374400436; Thu, 16 Apr 2026 14:20:00 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f584e39dsm86498485e9.9.2026.04.16.14.19.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 14:19:59 -0700 (PDT) Date: Fri, 17 Apr 2026 00:19:56 +0300 From: Dan Carpenter To: Luka Gejak Cc: Maksym Pikhotskyi , gregkh@linuxfoundation.org, ethantidmore06@gmail.com, starpt.official@gmail.com, straube.linux@gmail.com, sameekshasankpal@gmail.com, arthur.stupa@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] staging: rtl8723bs: fix stainfo check in rtw_aes_decrypt Message-ID: References: <20260415184727.285753-1-mpikhotskyi@gmail.com> <20260416195338.324428-1-mpikhotskyi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Apr 16, 2026 at 10:42:07PM +0200, Luka Gejak wrote: > On Thu Apr 16, 2026 at 9:53 PM CEST, Maksym Pikhotskyi wrote: > > The null-pointer-guard was incorrect, returning _FAIL on valid pointer. > > Invert the guard, so it returns _FAIL on invalid pointer. > > > > Fixes: e23ad1570028 ("staging: rtl8723bs: use guard clause for stainfo check") > > Signed-off-by: Maksym Pikhotskyi > > --- > > drivers/staging/rtl8723bs/core/rtw_security.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c > > index a00504ff2910..f467cb5b1dca 100644 > > --- a/drivers/staging/rtl8723bs/core/rtw_security.c > > +++ b/drivers/staging/rtl8723bs/core/rtw_security.c > > @@ -1212,7 +1212,7 @@ u32 rtw_aes_decrypt(struct adapter *padapter, u8 *precvframe) > > if (prxattrib->encrypt != _AES_) > > return _SUCCESS; > > stainfo = rtw_get_stainfo(&padapter->stapriv, &prxattrib->ta[0]); > > - if (stainfo) > > + if (!stainfo) > > return _FAIL; > > if (is_multicast_ether_addr(prxattrib->ra)) { > > static unsigned long start; > > You should Cc stable. The bug isn't in any stable releases so no need to Cc stable. regards, dan carpenter