From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3B0D30EF63
	for <linux-kernel@vger.kernel.org>; Thu, 16 Apr 2026 22:00:18 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1776376819; cv=none; b=soZO7mV8ac7amDXF6HHpoFEMH/bPBepHvk4UbBN5ef2YRYYx1yGE7ufeUTzykIX+YnAtBeeGZesZFw4cXGMOXRu6BQ2g8koOk4zP8kq8ZIisADeZjLRH6b172B2Pr6+KIWiG2F+b9+6mJTzLCJWgq5lewCwmMTUSknuzwEJWcVE=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1776376819; c=relaxed/simple;
	bh=nDuiyqtYf9H2vTd2p1zOKi6h1vITGxjuSg9O2IQ5J9E=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=NvkCSnOd0Ns36eVmnrul4hhR18KijQhuR9K+k2Gl2PUbszh5bljx0fLimI1xtnAosEeCnbrmLmfeVQHHCHv/YLKQlppxBQG+siF5e6woq4zQjATY8A9emXWXsRsltppFIpYa5q8Es58GfnZIQLqk9EvHRQIXMEe7teBBuldrPYc=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=N8UvAMzq; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="N8UvAMzq"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F86BC2BCAF;
	Thu, 16 Apr 2026 22:00:18 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1776376818;
	bh=nDuiyqtYf9H2vTd2p1zOKi6h1vITGxjuSg9O2IQ5J9E=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=N8UvAMzqA70xQkzxDdxGE2SF/a8aQr6zEzAELVM+QjKuLkW1TFX7IXv/J8V3EBMqM
	 VlEBWcqenREpG58O4Mj8wUuroa6s7d8946OvGaBMubaSNSbAZIxdFuy0lCHL6+hQzc
	 NmaysNm3grohN9WoFmCigvdOpPwJmA6lVRJLk10aydJ0uzOGtyAXdj3QCLZv9T1g6n
	 tnbN4Qvfa9jRBhzZZYuNsm6Xbw+BbS+LeGgFShYmAYxMrp3qEAAsRxBSXfSuESeDIy
	 gZ5utEQQ+xb2C9D/1Q94lF07qowis2dUDMeQ5wVnciKU0bp+aH7/U6ECWs0wFybwE+
	 uDZ9x4bS+/KGA==
Date: Thu, 16 Apr 2026 16:00:16 -0600
From: Keith Busch <kbusch@kernel.org>
To: =?utf-8?B?7KCE66+87Iud?= <hmi.jeon@samsung.com>
Cc: "hch@lst.de" <hch@lst.de>, "axboe@kernel.dk" <axboe@kernel.dk>,
	"sagi@grimberg.me" <sagi@grimberg.me>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	=?utf-8?B?7J207J2A7IiY?= <euns212.lee@samsung.com>,
	=?utf-8?B?7Lm47LCs?= <joshi.k@samsung.com>
Subject: Re: [PATCH v6] nvme: Skip trace complete_rq on host path error
Message-ID: <aeFb8Ao83MTy9jUq@kbusch-mbp>
References: <CGME20260416010713epcms2p78575bd400f93f6edb7fe3f3ead5bf930@epcms2p7>
 <20260416010713epcms2p78575bd400f93f6edb7fe3f3ead5bf930@epcms2p7>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20260416010713epcms2p78575bd400f93f6edb7fe3f3ead5bf930@epcms2p7>

On Thu, Apr 16, 2026 at 10:07:13AM +0900, 전민식 wrote:
> Co-authored-by: Beomsoo Kim <beomsooo.kim@samsung.com>
> Co-authored-by: Eunsoo Lee <euns212.lee@samsung.com>
> Co-authored-by: Steven Seungcheol Lee <sc108.lee@samsung.com>

...

> -void nvme_complete_rq(struct request *req)
> +void __nvme_complete_rq(struct request *req)

You're missing the "static" declaration, which was present in the
original suggestion:

https://lore.kernel.org/linux-nvme/acVCnozG1WKPkq1L@kbusch-mbp/

Should I just apply my local copy? I think it's an original patch from
me at this point.