From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEEF9357739 for ; Fri, 17 Apr 2026 05:25:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776403532; cv=none; b=e1mHmW669HOX0mmgU1AWY+wbnLLYuk+D+0nByBVZEpu04ncgQPUpvXBkdx2VCbD9SMoOEYC/HxKwhaP37mrrqD4or4sBxjIJh7HoH2U7oPMs7t9cLE4X9NpYUAbdVstUirS1P7HRgAFScRWJpeYZ+v0DFvzcittLdc63mXmSvec= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776403532; c=relaxed/simple; bh=ewSRNKHD3tCT/saduSwvvYMg/lug1Tof1ThFhOaIBv4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PVlJgjpBF/2DWOoH0k7HoPAvlqGj6yTt+7CvKiK6GymuMSocM1yTy6yHKBb4JVJ3iv1LNv0+uF3dzT18dDIRr0t2ZJRMpnbdnET7LXCGdVP1Q7Kj5uuT3nl9ddfb9LHV1QBsXjzaSr6xArikGDZAnUywchAP1Az8dYJcgzxgDsU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X+RQ6/lX; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X+RQ6/lX" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-488b00ed86fso2573905e9.3 for ; Thu, 16 Apr 2026 22:25:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776403529; x=1777008329; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pBOcs8If319sZczMI7MZUp1nUcUA46ONaU7CO4kO+eQ=; b=X+RQ6/lXYjkSiOdLsxJG2UwajdG6BJxibMmzMHjSiGyHt7/jDwaM6e/Nw//IGBk3VZ 2Qjrqah7gyuZe2UDEp6SK3d1RrqSgo/9dwzkCDLoBnF49nqCWwZmjbDwN/+YLOKHwMTz 2IvkECwBtyjdNqBa9wziD4Dfq9lgcgu/Q0sYOvHK5o7BJPP4+dCcanqOMwpfItLWrdPt zZyg257Zk+5cu3CPdvdKmCoTXRWW+i/4dLICI+tpQLxbm32cRlBdz7YI4Z9t+cf6HU2U tBKJ6oROvyyaM3W0NrgUGC+QhrCxR94kanWTR23tJzt8W5MSVNYTST5qGj/BMz4A+iOU j1uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776403529; x=1777008329; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pBOcs8If319sZczMI7MZUp1nUcUA46ONaU7CO4kO+eQ=; b=KLnzQEy4LmUf/ORSoEzmz3h716he6KW0dYVIgTjI5t6VV8VIOWO+VZnxL3H6B6AaKC DMSqktgH4DhUJq11XTUVBol+PeHZxJyirrukK0eEOkoFRSVPo10LkU88DDrQaalsYxaF 9PXJ0gQRQ1dOufZvYzjkJHfYKfQ6A32DG/hcZcjeSDNhqzFZnbam4SKetitvgLysxhb6 IjvvVGvKMt9gX4v5qMkWZFkFQneta920Piob2QMuxmYxLwrfjDBdidFw+JiR7hVj7x01 IWWU5JqKp6Z6RELz4++YBGQ7kKhAD8rxL5Iwu5mH9MOVBWzxvzyF4PQ0BWGZRzloNOT7 ze+A== X-Forwarded-Encrypted: i=1; AFNElJ9qH/fFEdtcPhYgY1QvLGi2U6VNMjuJGCTjtIohJq9eePh3rY3vaZS2lBPDGq/fUqdgJbG4LQc738C8CPA=@vger.kernel.org X-Gm-Message-State: AOJu0Yxm5TfbyVE/Q7+rZXG6WIf1TvYZ3qJclPUTrxhfKRWrTZf3oVvi 0Zog98sAxOfsFjtt2zeBbkOsM2lyVP3dg4O19971+BQiMdziXOIjxKFX X-Gm-Gg: AeBDiesEK4DBP3TSCGvZwxPvXFI5za51SM80MDP1Et9/p933SXQNE8GQbGvURYtipJ/ yHdG3/jrjWGkRqXSqd0PAHaDRRJbPQEAZ0cNhiXUCJaYyML+p0WBfWTSsE9Pic+51C743X9EZFc uP5spf1Aldnko2hIH7SnEe60mDKvHY5BR/EeXK7MigqWhH3k6ExhD633roS7OvF0n0ek9So28md 7yuKFpAwiqZfZDu0If5eZBUb3+LZFp104KzqR7XcI3HRGvuFZbROEh+cN7Ypz+8dgpq4Q6IMwrf /fCk5MmiyGuIjPrJqS2r1T7peI1nzwGg4UjBLpdhrq2QTM6GsrdhwdduuD9dWOWhYZXIpr+70b8 lrJ7FuRfqAm5G4Fz7aB8FDPxULkqlLWH/XBKXc1dpYbJJwMhEisP+xi1IXGtV+V5jj3EtJp5UZ/ sdP2fZ9iEFiiO5t9sLaSsBnB3i7hU5aA== X-Received: by 2002:a05:600c:4750:b0:486:fdba:f5db with SMTP id 5b1f17b1804b1-488fb6e7316mr19178335e9.0.1776403528847; Thu, 16 Apr 2026 22:25:28 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc16f93dsm20285885e9.3.2026.04.16.22.25.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 22:25:28 -0700 (PDT) Date: Fri, 17 Apr 2026 08:25:24 +0300 From: Dan Carpenter To: Maxwell Doose Cc: tsbogend@alpha.franken.de, gregkh@linuxfoundation.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH] mips: cavium-octeon: remove cmd queue state and related typedefs Message-ID: References: <20260417023602.112359-1-m32285159@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260417023602.112359-1-m32285159@gmail.com> On Thu, Apr 16, 2026 at 09:36:02PM -0500, Maxwell Doose wrote: > This change removes the cmd queue state typedefs to work towards the > "code cleanup" task in the staging's TODO, and aligns the codebase further with the > Linux Kernel Code Style. > > The following structs are affected: > > - __cvmx_cmd_queue_state_t (now struct __cvmx_cmd_queue_state) > - __cvmx_cmd_queue_all_state_t (now struct __cvmx_cmd_queue_all_state) > > In addition, the global exported pointer __cvmx_cmd_queue_state_ptr has > also been updated to use the new names, and its extern statement in > cvmx-cmd-queue.h has been moved to the top of the file to satisfy the > requirements for EXPORT_SYMBOL_GPL. > This should be two different patches. Is there no way to move the variable declarations around first and then get rid of the typedef? regards, dan carpenter