From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA1551E520A for ; Fri, 17 Apr 2026 13:34:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776432850; cv=none; b=h6mb0XZasbsyHNfLObEsSehXfI2i7SxhpqbUIjJcKCfE8ENfWtmJc/4uYtQLbDK0ylxrOnH5/dHW8xc944tSXj9KLKJNcRY9uH5vVUMvzSBhXSkMSKSkccWMARl90ahxzyNzO8dX5tOauVEg9vkxRYifoSjgshKIURutC8hTxaA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776432850; c=relaxed/simple; bh=JdRFtBf1aF4v4sSkchCdQI8qVbld3bKQGj6ayOgyt3A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YZyiZdKVKpu4qHhZo2doOSNiuEXE3hz2PXgRhZweTOrddoTFi2e/XUsoQ9LMOC0JcdydMeEK3WoZdI8ZCyYMdSARvYXHTgy/1dlUtdblGnGniIDdZnKZXFI5fLPajG1EQsflDieNgejdW6EbqCLv58r3o19Jhm0/Qu1OcYKTZBU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=eilDONDE; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="eilDONDE" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-48897fd88ebso7497745e9.2 for ; Fri, 17 Apr 2026 06:34:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1776432847; x=1777037647; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JdRFtBf1aF4v4sSkchCdQI8qVbld3bKQGj6ayOgyt3A=; b=eilDONDE44tAJT4CFr8gyxv7UbyNE0Cs4WAHughxcBKkohsoUds0Ry5GtIQjb2ErRy O/m55qysG8YcSVHaL14Fkkq5irDNMdvZvEdIk3mDmBqGe3v2/2+HIIi9Iq4nAU0EYclu J8VW2FBgMNm/NnPzfxNZM8IXAsXfMA4PHhjj4JgSoFPu8/fmDXJH9zWH55m7XOXk8o9A zRJkC3xxojDXVNAzGJzBdQBIdnWZV5tSJ4LBF2kYGdCXDMk/tOJxdDQ4HiievKWS43gl upstP+w0uvKFJXrwIWXP5o3KHIwaX3M4DCT/QUZ3CZGtbLHrs7LhC95NwT7ruGDWjV5M t2dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776432847; x=1777037647; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JdRFtBf1aF4v4sSkchCdQI8qVbld3bKQGj6ayOgyt3A=; b=WjEBYgdiwrh30WI8dmdhVaZdDUkHREL9MMNgWlYdRa5poaoLCX5Wh2zAWzPI+M7BvB oH9nXD65r/ZQ54w14a0FjVDZjwUgxr574VhKayw6zEVSsszQwkFHGlaTZeqnyT2SCAuG nyil/9FfdWqid4B3v8jXgopV0bHacqtkZrivenD1XHW2di8j5aY3e+Iu3yOC8IqTD45y TFnkoWRPt8RtuQFFQhPKAcfwiZ7tRk6QO1JascoE4oUjR2DbFo3cISBz8vPo7LNlEEAL RDRESg0k/LozLKQh9D6jXqgThsR089XKq2hWGJO9enNXW/1KTfrvDe0nT7yb4zLPCiKX EjyA== X-Gm-Message-State: AOJu0YxSWMZFdOu7jpOHhJUQik0nidMuMMKsJ7SBGhDmzRxj9SCObe7x N85KLJDc0aowaOpTfPIntPBDnB5Z3ldILOJXnViOfvHLxOwGq8Qi5yOuVHh+JzVMMPA= X-Gm-Gg: AeBDieuwmouiG2dbsgMTqxM80B6ySYpYiD3m8zwUh+oR3e8KuHfPJpo4tfyFKIF11Qd kyJEtW0Ft2RFsIra6nrWFWS6Mwlir27b61zSdL3uviQo9eBIjxQa4BVQ/+anHpGSiO0yG5oPdfN OcWY+SibHT5x2aiTD3HCsZGgIp9a/EosQWmk0QgxJwdq9Hz+YtOPCcc5wvOPUSHbEpK4fhkHKUv xADJYNiqUJFZpmg3RRaOtZlwcGmL/51w9hdEfgRP1SIKl7Zyp8jnP/fexg9hUWXrmDzsJs0Pp/j lpGIp1hbQKTASDtma7ATTRMFzSMFMqDrBihS7ZXsf7oBVobH/vd60rrU62Fr11d7vy+0fQqgTZs KGbIIh1aiWTJRTiWNJj6eLFPKpj3Pq3tkR+AaAFMH0HfGQbxF4UwKNEknPDRjqYj0rCztb8tpeY I3ysiXobWcwCroKqQPJkZOYVSvQ0ahW3krK54kl+EkWb655KNS+jzHA/uJmj07aGZFLPEK9J9Rj fOy3KR4ae0ymLDMxTikwhkj X-Received: by 2002:a05:600c:888b:b0:488:c40b:c8bf with SMTP id 5b1f17b1804b1-488fb73d234mr32626255e9.2.1776432847288; Fri, 17 Apr 2026 06:34:07 -0700 (PDT) Received: from localhost (p200300f65f20eb08db61cfc60d8aa232.dip0.t-ipconnect.de. [2003:f6:5f20:eb08:db61:cfc6:d8a:a232]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-488fc1001bdsm75797715e9.6.2026.04.17.06.34.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 06:34:06 -0700 (PDT) Date: Fri, 17 Apr 2026 15:34:04 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Li Jian Cc: linux-kernel@vger.kernel.org, lgirdwood@gmail.com, loongarch@vger.kernel.org, chenhuacai@loongson.cn, zhoubinbin@loongson.cn, jeffbai@aosc.io, stable@vger.kernel.org, Mark Brown , Jaroslav Kysela , Takashi Iwai , Zhang Yi , Charles Keepax , Kuninori Morimoto , Alexandru Ardelean , Jonathan Cameron , Stephen Boyd , linux-sound@vger.kernel.org Subject: Re: [PATCH] ASoC: ES8389: convert to devm_clk_get_optional() to get clock Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rel25duqhphg3sr5" Content-Disposition: inline In-Reply-To: --rel25duqhphg3sr5 Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH] ASoC: ES8389: convert to devm_clk_get_optional() to get clock MIME-Version: 1.0 Hello, On Fri, Apr 17, 2026 at 06:53:14PM +0800, Li Jian wrote: > When enabling ES8390 via ACPI description, es8389 would fail to > obtain a clock source, causing the driver to fail to initialize. > This was not an issue with older kernels, but since commit > abae8e57e49a ("clk: generalize devm_clk_get() a bit"), > devm_clk_get() would return an error pointer when a clock source > was not detected (instead of falling back to a static clock), > causing the driver to fail early. >=20 > Use devm_clk_get_optional() instead to return to the previous > behaviour, allowing the use of a static clock source. >=20 > Cc: stable@vger.kernel.org > Fixes: abae8e57e49a ("clk: generalize devm_clk_get() a bit") Are you sure you identified the breaking commit correctly? I intended the patch not to introduce any semantic change, and even with your claim I don't spot the issue in abae8e57e49a. Best regards Uwe --rel25duqhphg3sr5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmniNsoACgkQj4D7WH0S /k7OLwgAla3lc6UEHKZ8FPKaBwDVX2b3xJqRfuPoZ1dDnhKkWZVmCIKx4ElIYb6B kFUtzSnUdO8JkeM7hAXAOXICBTWuI4KS3yqXUCh9zIY1ZVUfWsA0zytSpqC6x0MN 4jQFKKXFv2zgtP0CKbYOGIkeYGnqmQCA+WtzbJTRX+Psnjcf1GP1U2bOfqFbyYSV U0lwQNh43b6guht4Afy8bOtdAwXQjFTcZ2zxkvFukkClo05/oHJwj+rLaEEwXAHT xz7l+6jVjoOZsmTPcpZfmj5KxQ4svXht7CHzM92HZ2ScAV/oJ+oJHy/TZIdVKe/m dTynrK4A/qe0QJMt7tXSjm/kqmmcUw== =cuEg -----END PGP SIGNATURE----- --rel25duqhphg3sr5--