From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D77FE3C3BE0 for ; Fri, 17 Apr 2026 18:36:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776450995; cv=none; b=GA4yZXBsBgla+QAre8I0uVz91dAvlzbypNQjFR3T3Ub7rWMyJ/UQsekiFjoe2N02k4SXXGygCLELT2RjwAOMXElOf/wbJjbsDodNECxDuUCkv32BlbFa9LECgeZmwbtMxvJPj3MMFKJiHurckpWwEw5AkqQoHEp8ETIv1HhqunI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776450995; c=relaxed/simple; bh=jhi8Q9sKzMlM9j3Xkto1ZUlcQv/ROlzg10YIqA3tX1k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZIjyofjMHPGaM4/prLEZKYL3KQWYQagpJJ6MdiOUYXAIEaOhc7zl+IrFYoH2b+BLZ29uhwq/zaWDnLpl9mU9F8342MQkmWZezyNhay0ONhGsyX3ZixBAafiMZiQNcnXUAyLPiq9qsmemU6DeOCa6dKb5TWZ2cTEvAUudJ0ImMek= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=iP8w3Mrw; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iP8w3Mrw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776450991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qzO4xHkNqCBbD3gDH7u2XXP1am7OmyGOsroGGiFrSjc=; b=iP8w3Mrwf+pUWKki6fj17/6SDIzYm9eoEb6ITdXWU6n2f8YvUwoWL6xWm8hWTqgLq3k6WT bG6mtDr/0TincmwVDOw73WuTqvJP3Otds88UG8GCbIc7LFDC1coBfKIonEw75zn+JezP4p Qs/ihBtZMTN9VD0hPze21wKpfpEIyNA= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-439-cFxf94TMPoStTwVXHme2-Q-1; Fri, 17 Apr 2026 14:36:28 -0400 X-MC-Unique: cFxf94TMPoStTwVXHme2-Q-1 X-Mimecast-MFC-AGG-ID: cFxf94TMPoStTwVXHme2-Q_1776450986 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A8C2718005A9; Fri, 17 Apr 2026 18:36:26 +0000 (UTC) Received: from redhat.com (unknown [10.22.88.10]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 25F4E1800906; Fri, 17 Apr 2026 18:36:25 +0000 (UTC) Date: Fri, 17 Apr 2026 14:36:22 -0400 From: Joe Lawrence To: Marcos Paulo de Souza Cc: Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Shuah Khan , live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/6] kselftests: livepatch: Adapt tests to be executed on 4.12 kernels Message-ID: References: <20260413-lp-tests-old-fixes-v2-0-367c7cb5006f@suse.com> <5fb3ecf5a13bdf459019f6f011f3507593498875.camel@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5fb3ecf5a13bdf459019f6f011f3507593498875.camel@suse.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 On Thu, Apr 16, 2026 at 03:18:33PM -0300, Marcos Paulo de Souza wrote: > On Thu, 2026-04-16 at 10:07 -0700, Josh Poimboeuf wrote: > > On Mon, Apr 13, 2026 at 02:26:11PM -0300, Marcos Paulo de Souza > > wrote: > > > A new version of the patchset, with fewer patches now. Please take > > > a look! > > > > > > Original cover-letter: > > > These patches don't really change how the patches are run, just > > > skip > > > some tests on kernels that don't support a feature (like kprobe and > > > livepatched living together) or when a livepatch sysfs attribute is > > > missing. > > > > > > The last patch slightly adjusts check_result function to skip dmesg > > > messages on SLE kernels when a livepatch is removed. > > > > Why are we adding complexity to support Linux 4.12 in mainline?  > > Isn't > > that what enterprise distros are for? > > These changes do not add any new complex code, just checks to enable > the tests to run on older kernels. I believe that it would be good for > all enterprises distros if they could run more tests in maintenance > updates of their kernels using the upstream tests. > > The changes are not really that big. Some patches were removed from v1 > because there were adding checks for out-of-tree messages (like the > last paragraph of the v2 erroneously shows), and another one was to > check if kprobes could live alongside livepatches, which fails for 4.12 > kernels. > > The patches for this versions introduce only checks to avoid testing > sysfs attributes for kernels that don't supports them. > IMHO when the changes are reasonably small, I think we should consider accomodating older kernels for the selftest suite. If we reach the point of having to introduce version #ifdef-erry, that opinion would flip pretty quickly. It's pretty amazing that modern tests still run on older kernels (with this patchset) -- not an explicit kselftest goal AFAIK, but nice to have. If we do merge this patchset, it should update the doc tools/testing/selftests/livepatch/README to note the oldest expected/tested upstream kernel. (So new selftest authors may have some idea of what API / sysfs features to use.) And that this compatibility was only an incidental "feature" that came for nearly free. It's not a promise to never add backwards-incompatible tests in the future. -- Joe