From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FF9F37D128 for ; Fri, 17 Apr 2026 15:07:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776438436; cv=none; b=CvCMGVd/aPgyfi81c98LP0tZ8qQkrx3p4btV4TYyOzvhwOZa2vuJT1WXqt53ZaIsNUXP30EGe0eyASLKTVi3DzTWBELpgsJ9j1nwWArR7gIKyGYRCnhWRQ/z0eBlmjrTS1DimxydMvz9Ql3Co/gdpeJAZcQSvaG1Icv4+LXAaTQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776438436; c=relaxed/simple; bh=qRoZV4X18vNFvmPDnw5TV3Kd1sVASGdoZqtHvXbs3Ss=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pCC2D9CDTKtIq/eXOXTa/w9LDB5rppXjr6Z9NgENTGQOT9iXv/c4USBHzBcU/+oT4czXWn9vBcY2mrywNUWJj0aK6Epk/TMha868Jd6ts6w+fEcZ5ltohN+QyOkhX1TgM8LBf+jWM56aCR9CtuIzdnPqurkmxq+3G+RAEcoRZW4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=fv6UMOoC; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="fv6UMOoC" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-66ba6d3dab3so10586a12.0 for ; Fri, 17 Apr 2026 08:07:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1776438433; x=1777043233; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4W1PvFTWyy9P9TaXChv1j05m0pIed2QAEvBCS3K2Pw4=; b=fv6UMOoCXvopsqvcEE9ttgx50KqREYq5tScwixlKOLMN0/c1G4BvZrBaXMOcvCx45A JMl3CBxI8kTB5tDEaBBHtnXOcAVigK/lQnxvc4pZCdEIsi+1Lw73TFrz6/o+wj9M0Hk1 j+uuzDB+JCYmNRXf/9kIjvoePnEubfehte84tnrosoDoKL3aywxy1jr5I/C5/Y+Xkn0j dKv/cvwWoco0UgupYm04lL1R1kLK7lL6VJ9ywkTczTyx+lzTrG+ARHzXm1fc2Wqojq/o GpIFpIk6ngyoccROBTDFQ86NL7P+EKkr3cJDDz+g22Oo3oG1aapIffrUdE4So2CMQjDJ Uc2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776438433; x=1777043233; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4W1PvFTWyy9P9TaXChv1j05m0pIed2QAEvBCS3K2Pw4=; b=MokWcLX11wMw4C5JNg9wAt1gEOYY4wNmmGXHSuUYDjA/o/Dr+1CCEKVzBwNXigw95Y 65dDZnVnV5DdyicvdVNuzl2OU8Pcr14oi2J7gKEMqh/tPckTtKLbbrwEi0l5JU6CmXFo Oio/HQr8eFNxpZ0mAtxq2uywQaFEWy7UerA8hGlAaMPIwyp91QLzRQly/88cD+wsLQ5I vbWPYuZWrrgsQcvPtxKMLDQ6ZNIvA3ZlRD+k1LMTv8ZRiWhmqA79Bc32L8R6P3BUsbco HEjbgtxHJdoS2t8K/NZc85RcPhyZn9gLZySS5Sum0cmZ+0r63z0fMKr4uQPslJh4eLeX RQ4w== X-Forwarded-Encrypted: i=1; AFNElJ8soJZiRBBAvCajbnyUg+CNWBJ7u8TB01bZT+G8UiwSZj2puxBuLqPxU98CS9vPhRil2v9YtYJ4B9fHxao=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/peV0dPdJt9/bve4WOYcFuYB3msanC6uSwpKzJkpDWGcKM8ux zcl5Zg2CGmmN87cKFo5w/rtrQdc3GZ6Wm2kzJ7lUlWT8cOsKFgPJy1ELzv3HWKd9rg== X-Gm-Gg: AeBDiet8XxkrHO3u6zcayzcDyJwbC7NCwKeOxYgj7JVf61IuVvQyW5ca5yLe7ckU72W rcqxHMCLc3ouZlSTeX/fx3zkIekOvahVwysBMQxLCPkPDCudep/IagyBrfdbkr7tP9pfBTtEIPO Os7sejlyvSDbOnEP029E+/B1P9Q6l2pXCR6CR1Ct24odPXU7y7yDshAE3NyWdYq0PgiMeWniRXO B6mLm320bPYrtF+3mGUp3CVJ/qjRq6yflUYbIZrl04WCzxG8hUR+wrh9AMItMn0Avu2cMkufx57 ao5YIVwJueKy7h8e+sM4BV5GOiSb+60HYP0Rlpmyf5wQhV/h6HzLH6ssM4oy/9VERmUGougxrc0 DNWiM6qidByij76LtioPJwXdtQXHwZUTYd4As4k0AMhveQgOiyNpk4F3aceu0/64r/v9dSw0m1v 6KJ8ieO3or29HBjK5HbVHLhCgEgj0jYeAe1pDfIuvQvnzTVxccM2cUTfIpYqv8Q3xw1iRXdqnIx oYvPA== X-Received: by 2002:a05:6402:304a:20b0:671:e657:449f with SMTP id 4fb4d7f45d1cf-672c08c88e5mr38646a12.13.1776438432370; Fri, 17 Apr 2026 08:07:12 -0700 (PDT) Received: from google.com (8.181.38.34.bc.googleusercontent.com. [34.38.181.8]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ba45553980csm64494366b.58.2026.04.17.08.07.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 08:07:11 -0700 (PDT) Date: Fri, 17 Apr 2026 15:07:07 +0000 From: Mostafa Saleh To: Jason Gunthorpe Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org, robin.murphy@arm.com, m.szyprowski@samsung.com, will@kernel.org, maz@kernel.org, suzuki.poulose@arm.com, catalin.marinas@arm.com, jiri@resnulli.us, aneesh.kumar@kernel.org Subject: Re: [RFC PATCH v3 2/5] dma-mapping: Move encryption in __dma_direct_free_pages() Message-ID: References: <20260408194750.2280873-1-smostafa@google.com> <20260408194750.2280873-3-smostafa@google.com> <20260410174553.GD2551565@ziepe.ca> <20260416001122.GI2577880@ziepe.ca> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260416001122.GI2577880@ziepe.ca> On Wed, Apr 15, 2026 at 09:11:22PM -0300, Jason Gunthorpe wrote: > On Wed, Apr 15, 2026 at 08:49:08PM +0000, Mostafa Saleh wrote: > > On Fri, Apr 10, 2026 at 02:45:53PM -0300, Jason Gunthorpe wrote: > > > On Wed, Apr 08, 2026 at 07:47:39PM +0000, Mostafa Saleh wrote: > > > > In the next patches, we will need to avoid encrypting memory allocated > > > > from SWIOTLB, so instead of calling dma_set_encrypted() before > > > > __dma_direct_free_pages(), call it inside, conditional on the memory > > > > state passed to the function. > > > > > > > > Signed-off-by: Mostafa Saleh > > > > --- > > > > kernel/dma/direct.c | 22 +++++++++++----------- > > > > 1 file changed, 11 insertions(+), 11 deletions(-) > > > > > > > > diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c > > > > index 6efb5973fbd3..ce74f213ec40 100644 > > > > --- a/kernel/dma/direct.c > > > > +++ b/kernel/dma/direct.c > > > > @@ -97,8 +97,11 @@ static int dma_set_encrypted(struct device *dev, void *vaddr, size_t size) > > > > } > > > > > > > > static void __dma_direct_free_pages(struct device *dev, struct page *page, > > > > - size_t size) > > > > + size_t size, bool encrypt) > > > > { > > > > > > This feels like it would be nicer if it could be the > > > swiotlb_page_state instead of a bool, maybe the enum needs a different > > > name. > > > > I am not sure I get this, at this point the swiotlb stuff is not > > introduced yet, > > Just that using bool as a function argument for a flag is often > frowned on, and you already have an enum encoding the same flag > state. I see, the enum is not introduced at this point, but I can change that. Thanks, Mostafa > > Jason