From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C0C5283C93 for ; Fri, 17 Apr 2026 16:01:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776441687; cv=none; b=Ne4MFt1sqhYVtZpYvr2hcH/752K5GwiLFkQlYTg9nRiJK7SS4xvyaFNqMxEQlkh8zk8AVjG8X4ckt7fe29n2XlheHQ3YRMrLB/PcC0Ke8Hpv7Ftkpo5jjeDbZfkqdmVc5SP+uEc5MWM1V2vYezoqQeBd+bPLcQpXuKKOW0aCcIk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776441687; c=relaxed/simple; bh=hbFE3FqsQfdRScUIGGhXtmt7GyIHGNENecOLhe+uiXI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=narjYI6lKAeDe12EulVTEvkzpEGvENfjIr4TiIk0FxXWeNdMuwha2y6Pf+l18mVKHY+5lTDHBmepIKvGfzdb5adFgqIWG1+1Cny/t0kmGIo1Hu2DJhwQBxEUvL3L1EesctLgnJlQdEfBH2yZQjU8bZ9ooPtmbFdmXKy9CPfXmlw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=readmodwrite.com; spf=none smtp.mailfrom=readmodwrite.com; dkim=pass (2048-bit key) header.d=readmodwrite-com.20251104.gappssmtp.com header.i=@readmodwrite-com.20251104.gappssmtp.com header.b=P3PCtSA2; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=readmodwrite.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=readmodwrite.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=readmodwrite-com.20251104.gappssmtp.com header.i=@readmodwrite-com.20251104.gappssmtp.com header.b="P3PCtSA2" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4838c15e3cbso8362195e9.3 for ; Fri, 17 Apr 2026 09:01:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=readmodwrite-com.20251104.gappssmtp.com; s=20251104; t=1776441684; x=1777046484; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bLUi2U0XkcTAJ668mHdGjDuVvnhT0adO328P6x+koW0=; b=P3PCtSA2cgF9UqS85BIvKNl5fdCKkSmQ6XyhEooxhXkf71kzF6NihjWZ+xHoGEXw2B RAdlsSr62cMJSXDUleQOq6vfE4+5Ep4UKNskOL3HbQvUEyYY8h/2ixx6WWXXrB5CLetV dkTneLgY+xxcymAk0uSPi1nzJIzMMMMYFHnpUpO5tMS3jfGsaf63eQrsM5y9s/COXwCJ NMxcouptSQsTz1+fUvFc0J5Wn2apdjqcK4g8ZcnOYenO691yCH8bYCNsoKgksur/3RV0 FS8R/uhhkUqfnbFuO/amHPY5hA/hABqZducDomAg6D5Um6J073ls9rqAhJDiTzhzpTu/ 9PtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776441684; x=1777046484; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bLUi2U0XkcTAJ668mHdGjDuVvnhT0adO328P6x+koW0=; b=iwRNtqq+Z9qx14YRMXTFTIbZIwbDH5f74dg9C/W3qr7EQE++DhKRAd9OKtHnKRDu/S ttI3olAUwcEkTgsOZ3Trz37IQe2riNDxm7H/EnAUWW9cZfZLAekaHGaRa/sIjkQ+q0pv JJg+qYpgqaa00oREAGl5Pwd5/vQkHwsUU+nUECVWof87BtojDsm/ohT9utqq50Viuajr 7hxKMcogbpayhKfisaEcMWmIQ/mM1lFQBOBcjfPiGM8QXZsHQKPtTtvTyE2UcFf5uk/M Sz/79Hb5sotfWvez1bpXpgC2sX8vTS/XTv4sRGvi/NTT76aS5l6Iasb8ied55rxbO5Yh JoYQ== X-Forwarded-Encrypted: i=1; AFNElJ/OmC3+B/nuSeeca4X1qun/VovvIccrQUDR3GBwu0qNP/DaOTBW5y06niWsDFnY2JoW/zpkkOXhxik3gqc=@vger.kernel.org X-Gm-Message-State: AOJu0YxHtn2d6wSFQS/VC4MuFDNu9dz8aNSiQWbqccZ5IHBeRHAOo6vK 3YbaoAS/9h3rAO4zE1HJ5qeXQFc3jsHoGjwxwtb+7uHAaLKguG87OruTOzSuH6r3nJE= X-Gm-Gg: AeBDieuGfBEytN6hbZ4XgdsY+3kfIYMgYL51jvwYtz3q3q6caVQjBbGKO2D4sr+A6KD ApmlPsxHINd4QPkuo2EUlCs/m3TJ52OGt7xc3PE+sX+e/EbOGpN3c5G/sp3krLDRPC0Okq+NSiU qC3M4W5pdqM4wHjA28d6L6gaNXygStlKanDShOedylS88W9Lpxz0FV7RTuR3r/lEgvSc2F1uMAp hHwJpCPhSOToan30DNqPuqtckFOXZO7CW9Ygh+z1+OOBgCEau0eBf3ldUytgWIr/MpxW3J7g0Hd Ict9tB/7dtcwdUT4JrkXa8dcbdpR9VR/92hXMdtn7+rlQp7KIHcKRpX2uYFcSwAT5ZoaqqBgM5q L+GYrxi4KmtWE0EMhmiTBQGwV7zsA2puQqDa6Ib79q2bxxzPjqCyWUIOgI0qvMczl2UoJCmG1MH OlNjrd2p7apY8kDUvJ5Q== X-Received: by 2002:a05:600c:681b:b0:488:b9c6:11ba with SMTP id 5b1f17b1804b1-488fb794f80mr47360845e9.28.1776441684378; Fri, 17 Apr 2026 09:01:24 -0700 (PDT) Received: from localhost ([2a09:bac6:37a8:d2::15:415]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4cc375dsm5123817f8f.14.2026.04.17.09.01.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 09:01:23 -0700 (PDT) Date: Fri, 17 Apr 2026 17:01:22 +0100 From: Matt Fleming To: Tony Camuso Cc: Frederick Lawler , corey@minyard.net, openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, kernel-team@cloudflare.com, Matt Fleming Subject: Re: [PATCH] ipmi: Add timeout to unconditional wait in __get_device_id() Message-ID: References: <20260415115930.3428942-1-matt@readmodwrite.com> <9b6af9ab-79f9-4f87-ab7c-8ad6efeb18ed@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Apr 16, 2026 at 10:28:50AM -0400, Tony Camuso wrote: > > In my testing with updates from the Linus tree, after a BMC cold reset: > 1. The KCS driver returned -EBUSY to callers (good) > 2. The watchdog daemon received the error and initiated shutdown > 3. No D-state hang > > My tests, conducted on a Dell PER640, verified that Corey's upstream fixes > cause the driver to properly return errors instead of blocking. > At least on that platform. > > Which hich low-level driver are you using (KCS, BT, SSIF)? > The PER640 uses KCS. > # cat /sys/class/ipmi/ipmi0/device/params 2>/dev/null > kcs,i/o,0xca8,rsp=4,rsi=1,rsh=0,irq=10,ipmb=32 $ cat /sys/class/ipmi/ipmi0/device/params kcs,i/o,0xca2,rsp=1,rsi=1,rsh=0,irq=0,ipmb=32 attentions 3 complete_transactions 7080342 events 3 flag_fetches 0 hosed_count 1 idles 25359147 incoming_messages 0 interrupts 0 long_timeouts 264790 short_timeouts 13723711 watchdog_pretimeouts 0 > Actually, no. The 54 commits I backported simply bring my RHEL-9 test kernel > to parity with the Linus tree, which includes [2] and ... > cae66f1a1dcd 2026-02-13 corey@minyard.net ipmi:si: Fix check for a misbehaving BMC Ah, I see we have some machines on v6.18.20 which includes this and they're still triggering this problem.