From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34B177261A for ; Fri, 17 Apr 2026 17:24:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776446697; cv=none; b=T4Xt8Q7tIrLO1nWHi2/eWfR+UX113hr0l1JexMcnh5UmobHRquEvJ/TB51bH85CQcBfD8R7o2JdR1RrS6so88U/skM/3wogq91faxinHq6QVlQYu4bfx6kiHrl5kbSaoXV4QGV+O7T4hUDuCBd15ei624lpQs26CwlDrVv/pKAM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776446697; c=relaxed/simple; bh=E/S0nfMNUNfMfW78DStv+AcpOFLK7TKJXpM1jKEQhm8=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CItqH1MVYH34d0UWqNJxDcX8TsHyeOQUH2lnHlj/Gx4h+wjqe30FnAaOHnG/EVocUKOwA95Tw+cAn5i91qeFgUkzmfoaZS9zA1Jg3eCDcAOdYnEGdReG1x34OZ98HKWY/0Q5t1eBzMh1FjxpsGklM2UmH5ZSxCQ2Amm9srqjhpQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FcOvXm5F; arc=none smtp.client-ip=209.85.208.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FcOvXm5F" Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-38eab6cf7d8so9001801fa.1 for ; Fri, 17 Apr 2026 10:24:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776446693; x=1777051493; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=wyFiZOhvljUSTmlMAtWIZh4RtLHlCzqCjHl9pwEGxDs=; b=FcOvXm5Fsg/R/rHrLeqkmPaLa8NAyYxN1hqTq0G1pBO2L8kg5/MV/fJeaSaYkkm7P2 OHFzb4kdE3P/DdJGHjSLL7UN2sYXegNN6VtdEdsL3tF8jn6//9uKRpFIu2otOHgAQWq/ tW8/QBuKAXvtMjIAtjATEIWLGoF7KiSmvhopGG29WWo2wR48R8V5zBvIo88DDorZVByS sL4drPJcSvp6GB0oZojOI7FZLlBRWEFzd1bLyo9o98Jtzvubzs7auoocxY7Ocd3MiaNZ DB3hdtvvENfny0cipiCOJGFjYoptuJ9w/KC5rfxME4KIzapA7i9Ojz/Z5YY8svRMr4Sz CZkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776446693; x=1777051493; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wyFiZOhvljUSTmlMAtWIZh4RtLHlCzqCjHl9pwEGxDs=; b=fJ+jSPYjhauAw05wfllXbWPocbVEspwbrRfmbD72+/+1FPDw0NaMi9a1EJgczPrM+i uF1QNk8RU8ZW6Xv+nAIiQdKLOaa82pbmTEcf2WV18P3nfNGCS2nPJY+8tBzoNJCc9UCJ 3gNyIUQd+jOOR7g7Dfcs2oTboQ5ab8JYZCPKExzLrRLU0bg6pODVfdp1hFTlNfS7ymf3 XLcX/f8DCKHtxPmCdmC4/rczAp+o4qbWOSpffbC1HH2DQDbDVDBj6PUKcwwHS2IGV9NQ 57eO7H6WmaIyGzG3v6pwvbkEAfKSW2N1MsKGZsJAfkPl307BZJU33YhWd2O7zzWD1s0P TTCQ== X-Forwarded-Encrypted: i=1; AFNElJ+m507Ss6HhQ89A9k5IPSy3cVll7EG+dS3/9+iupZTqjFSc1COkGu1zAcrsqviwEq32rAdGjdjiwo2daHo=@vger.kernel.org X-Gm-Message-State: AOJu0YykDBU95cKwN7+5PmUQV3yyh/SEMUsugRb2Us4uw3C37Vmmt/fr 0LNXQk9DYmjuuuFtLrJIEz82IYHF1fRx1/dzAPuvxkK8iO88EFH9baId3CmQqteR X-Gm-Gg: AeBDietdC/LMIO3yqcMZOHWTElZsAsuIHcCzaOimcOr0K4tpOkw8FyuByTnHpoatw8w YLtdatTemGgxGDJOKjC1Er/Nh4zp4OicuB90KHLh6q4Fjkn4VPIPbyOk2aZxj+Gec6n1BvdOWJ6 FTGJEJLhOiJXfAz4ssYWnKHinyW8WbcFqYcB+k09zfJ3h+CyucS2KelYl+9oF4n8a5CLLws6YtF 68Oelg4gAc/yF+66E+Ik4X2YV2L4o6WuHr8EHL5yeLf1XlTZ6UjJvsXd8Gtqqf9RL65jHdQ4nbD kGzIxDTYvLWananj19u0j8AtHFKeQ19WAGPYgAGCWh69F9zLgoVzGzBfuo6FdXdL5e//cVoqZsr 0oEKSX75yjfyy3QGK19cPU5TkNrEHOahxJhQ9Ycsw4DODMtxLggtF5Y0v8jcp2WkbnGConfsmI2 E= X-Received: by 2002:a05:651c:f11:b0:38e:13eb:f0a2 with SMTP id 38308e7fff4ca-38ec7830e30mr13004751fa.8.1776446692888; Fri, 17 Apr 2026 10:24:52 -0700 (PDT) Received: from milan ([2001:9b1:d5a0:a500::24b]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38ecb4f54ffsm5246531fa.1.2026.04.17.10.24.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 10:24:52 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Fri, 17 Apr 2026 19:24:50 +0200 To: Shivam Kalra Cc: Uladzislau Rezki , Alice Ryhl , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Danilo Krummrich Subject: Re: [PATCH v10 0/4] mm/vmalloc: free unused pages on vrealloc() shrink Message-ID: References: <20260404-vmalloc-shrink-v10-0-335759165dfa@zohomail.in> <7d16f260-ffd0-4e45-b66e-9e7f71332466@zohomail.in> <85a9f419-7f1e-41a0-9e8e-67aae7a1b0fe@zohomail.in> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <85a9f419-7f1e-41a0-9e8e-67aae7a1b0fe@zohomail.in> On Fri, Apr 17, 2026 at 07:05:09PM +0530, Shivam Kalra wrote: > On 16/04/26 00:14, Uladzislau Rezki wrote: > > Yep, the problem reported by Sashiko regarding area->size and vread_iter() > > is correct. V10 does not address this. > > > > I am not sure that reducing vma size is a good approach here. It is > > widely used and we might end up with fixing even more corner cases. > > > > vread_iter() and vm-size calculation there should be fixed. > > > > -- > > Uladzislau Rezki > Proposed Change for v11: > > long vread_iter(struct iov_iter *iter, const char *addr, size_t count) > { > struct vmap_node *vn; > struct vmap_area *va; > struct vm_struct *vm; > char *vaddr; > > vaddr = (char *) va->va_start; > size = vm ? get_vm_area_size(vm) : va_size(va); > > if (vm && vm->nr_pages) > size = min(size, (size_t)vm->nr_pages << PAGE_SHIFT); > > > I have some questions to clarify. Why should we use min()? Checking vm->nr_pages, can it be 0? Can we just do: if (vm) /* Can not use get_vm_area_size() because of realloc(). */ size = vm->nr_pages << PAGE_SHIFT; else size = va_size(va); or i am missing something? Thanks! -- Uladzislau Rezki