From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f45.google.com (mail-dl1-f45.google.com [74.125.82.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24E421514F8 for ; Fri, 17 Apr 2026 21:24:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776461082; cv=none; b=HjJMfCE8E7YI2MyUbcg1IKsuZyBPgvcO5+N4U9kpFSPf5snGFxBhhzYjr/VDAzZ5ICxax+FmKbM7wADetDib3081Xadfbyt8/J/Ar1Idoc14nKEqjQC8XUZXiZsRD70Ig3UKUrSgzruCCvXD+LSFycY/NH0eJCgtlQG3EzpHAQ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776461082; c=relaxed/simple; bh=SfW3aKMNDF3itjmw5mDGazvjrO1+TlvAVfQgjmpgN1I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=k5P1uf0z2Nm2Jf6egLGD+4Bx5h2jUcCdyxN1OwYnqXfNieB6Fqb3Pwruc2/pwTbvPkAU6Vl70CX+ZrL8NM7pz2vnDCP9p/IbtyJ1V3+oVWjCkFVuJ54saasGir3fwKFiZSAZYYZ000LginW8N0KTwFYR/JvrjmqGw2BKSGp4g9k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y1IFCL4I; arc=none smtp.client-ip=74.125.82.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y1IFCL4I" Received: by mail-dl1-f45.google.com with SMTP id a92af1059eb24-12c565dd3a7so2005614c88.1 for ; Fri, 17 Apr 2026 14:24:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776461080; x=1777065880; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9YMgPDsRl1INUEuGfQBN2K0mpewlXYhHoJVyAhAldtE=; b=Y1IFCL4IL4YYYhrphm7z00mjd9GRO/KIC4Zyqew9QjkGR9AdjivC19iU7hDPS/XUDw /QmJLcQuajzICwfhzrnhFPo0p4SWL7BUi/yT42QAZH08D5kmEDel8OoC8clZZhtpIxL7 TcGJEc6TIXn/mb1gcHcO2kY5IaHp0FURjEHznoKL1Bx9pC3on6g5JGHoUzwpYS5WTdih brKW/ke2xXPLjm1Zx5puJ9x6fkQCoVF/Eeoq33t6IOkESfMcvosY6viWozLhdX2YtpO2 jP5GKMTgNuld+yQglT6QklnYun1nL732o7LhoYSulJK/vU7UbF12xZ906KkavsgdlxGb gHpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776461080; x=1777065880; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9YMgPDsRl1INUEuGfQBN2K0mpewlXYhHoJVyAhAldtE=; b=Pl3WK6r/OzVCkCNM11Y9m3Y+00QyD5vpjUZkziL9cM44lSDyDMoeg6izfpm8eX9eHo ja8ZPIPosmo8J/9oyNqqc+Uhpw2KhMw5fTORH8fI2IsGvaStKkCgOOmuKPI7lC45sY/q 5KovJoVmlZkCiM/89lTsCvEHwxbXa8/PoLrQWmWHEiGERKxzDnpPDsbbrHkxrR1XPxWm L6PHriy4o3J2ePU9l/o0ZICclkEooE5KA6n+j1e4CzrKFQ8GxFzXePTj5S7znonLo485 Rs02wU5CMl/UiH4pwcIGqA0Mzl9yEwMJ0+YjwvKTngFUPO38TwbLsXq1NdAxBoIYlQCS ZEHw== X-Forwarded-Encrypted: i=1; AFNElJ/dqZkFCvtBrbUb4m91Qx9eqaC1WlVqcoxe1O5CS/HaNeAKwKlR+vEjX44LfT7h7SmjNdhKGQ+qxA6eWWU=@vger.kernel.org X-Gm-Message-State: AOJu0Yyi2e5pQEiwwuxC1sBVB3vVojEt3P5QukW+ZZnZLtNDB9jr7b6G aAykTDLrVtK7hXXOIulYApjQloWoztN+3lSlaHfO7XtIj6g4f8bHsRhl X-Gm-Gg: AeBDiesVllZiGLWd1RhDrQqUATk1UgkGhUKtMrpwYw3I4gKfnONj1cYO0FTRtokn0RQ a+sH7oiBBzItMlaKAH+xPADoDjiNjURQireNEVI2sm948PtSX4vqd5catv+S/R9z+kx0b8uUo4t zH40QGxhTzo4Ks3VvTw7A3TKHRHtrdcTGlRVnD/0c5X0pKufaUlz0rbeWcIZY2FxCg12FEXESvQ OC8qDrZXYiD4WrLg7y7sNw2bXISe615+EGUBdX0NcZ7J2X8HlRMaDRgL2/Wuux2cJdY6nXyjQq4 U4p6W3vPgVF0FUFaPhkgw+NbRTCKvfctMxFqYPIo9CKsgPi81SqS7pQXXtqbi5wMe8j1XhNpUFp hGM1UvPzYlGz02qYV3MyxkDmEJP5a6jHih5Ce4Qopm2BnWYT0675DcIgGVUp7AZpvj5HrhpVcsl YpEkK0PsRrdq2abARjQGS8ZOs6bij5BI0v+KOtVuzw69EnAGCggP5Ov8QWckIgWbOhiCrpAi0= X-Received: by 2002:a05:7022:60f:b0:124:abaa:7ff2 with SMTP id a92af1059eb24-12c73f9bc97mr2419280c88.24.1776461080143; Fri, 17 Apr 2026 14:24:40 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:a3:a483:e585:b80]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2e53ccd2564sm4053982eec.18.2026.04.17.14.24.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 14:24:39 -0700 (PDT) Date: Fri, 17 Apr 2026 14:24:36 -0700 From: Dmitry Torokhov To: Harpreet Saini Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , David Lechner , devicetree@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] input: misc: Add PixArt PAJ7620 gesture sensor driver Message-ID: References: <20260417052527.62535-1-sainiharpreet29@yahoo.com> <20260417052527.62535-3-sainiharpreet29@yahoo.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260417052527.62535-3-sainiharpreet29@yahoo.com> Hi Harpreet, On Fri, Apr 17, 2026 at 01:25:27AM -0400, Harpreet Saini wrote: > This driver adds support for the PixArt PAJ7620 gesture sensor. > It implements hand gesture recognition (up, down, left, right, > etc.) and reports them as standard input key events. The driver > includes power management support via Runtime PM. Sashiko has identified a number of valid concerns, please address them. Also consider: - moving powering up and down the chip into open()/close() for input device - getting keymap from device properties and allowing adjusting it from userspace vi EVIOCSKEYCODE - no capitals in type names - use 'error' instead of 'ret' for variables holding only error code or 0. Thanks. -- Dmitry