From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-173.mta0.migadu.com (out-173.mta0.migadu.com [91.218.175.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDABF329C71 for ; Sat, 18 Apr 2026 11:37:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776512236; cv=none; b=foW5Jz6zaOSGYPStbcgzlnQijQmqp4noIeYsxnvdnTbwF7RHzWs3ryLElRMVQZ2fmTV84lkCLe6uJaVtuHrqjRM4WjkgjDI/zrCyxAM97mFn2gUq84Lr0fvWqwEpif3T940goj1UTs/QOsExPR26k207ecvjqTowQC+XM0BxnoY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776512236; c=relaxed/simple; bh=9j8eVaGwvN0ubS+y6hUq6RKr0xQ7mZq5xSdwgayZwFs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Tt7wXRaJ8qcj+kUrvNOxX7AVZ2fZqd2o7OtPJ9giAcJolhLjVGJBwRZPyIbbI13SN0KUy5HaYCjbEe8Lj3pVoURnqnn2WnMmxtb64Yt9hew1Gx2WkeP9Dv1a6jm96vJH8Fg8JWFKRfZxMq8WadMKbmo5VersIvqD5COAsIwNQTU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=UBdWe1dE; arc=none smtp.client-ip=91.218.175.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="UBdWe1dE" Date: Sat, 18 Apr 2026 13:36:58 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1776512223; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L7bwugRpccIipnAdTLaiDh6Aizt/AO7kL9dxWFVM0g4=; b=UBdWe1dExc+zfAuPmB/aknQFrw1Xii++JamXUDteqE21FqHPUIOl5EE/sMngLL+GxM0x3D dhe0P5nCqAczfOp06+iVbHTchz/ZZ/xK2lk6zu/QriU0p1vM5KuBZXQLkbmBBeL/pESLnM YnTu169idUl6iHl+EI9zhMAjhWa5/50= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Thorsten Blum To: Hannes Reinecke Cc: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , stable@vger.kernel.org, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] nvme-auth: Don't log shared secret in nvme_auth_dhchap_exponential() Message-ID: References: <20260303190350.78705-2-thorsten.blum@linux.dev> <655d293e-51ce-4e24-93d1-587480d0680f@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <655d293e-51ce-4e24-93d1-587480d0680f@suse.de> X-Migadu-Flow: FLOW_OUT On Wed, Mar 04, 2026 at 08:17:03AM +0100, Hannes Reinecke wrote: > On 3/3/26 20:03, Thorsten Blum wrote: > > When debug logging is enabled, nvme_auth_dhchap_exponential() logs the > > DHCHAP shared secret. Remove the log to avoid exposing key material. > > > > Fixes: b61775d185a3 ("nvme-auth: Diffie-Hellman key exchange support") > > Cc: stable@vger.kernel.org > > Signed-off-by: Thorsten Blum > > --- > > drivers/nvme/host/auth.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/nvme/host/auth.c b/drivers/nvme/host/auth.c > > index 405e7c03b1cf..5e4df2ac3cc0 100644 > > --- a/drivers/nvme/host/auth.c > > +++ b/drivers/nvme/host/auth.c > > @@ -655,8 +655,6 @@ static int nvme_auth_dhchap_exponential(struct nvme_ctrl *ctrl, > > chap->status = NVME_AUTH_DHCHAP_FAILURE_INCORRECT_PAYLOAD; > > return ret; > > } > > - dev_dbg(ctrl->device, "shared secret %*ph\n", > > - (int)chap->sess_key_len, chap->sess_key); > > return 0; > > } > > Yeah, that was primarily for debugging. > > Reviewed-by: Hannes Reinecke This was never applied, was it? Thanks, Thorsten