From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FB82372ECC for ; Sat, 18 Apr 2026 14:55:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776524118; cv=none; b=tG9vVTZN8CzuPvStRyLg/u8g8hVkNbXG3udENT2KvQXmErZd6qtQ5CIUpOrIb3gvb5CkZfb4PwrhtlyggogYrtjO31lz0hzbNggjDX6P5AGgtC/mHLDFNC3D/7+uzBPaAWCWCDMTTryXHlV4Y/HEa4mRtiNIYZOnwfbZRAzchjY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776524118; c=relaxed/simple; bh=bwy8dcso4GjqW+vH/gHLOAFMKDProsWggCfpiZwSK90=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=N8qp8agpS5jbh2MNTPKhrxEB0XgacaqRqEpVI6NH4k//Mdc5zsLIT5k5ynVoTUcue2JJdE+Xhu4AVzC/KiTJhoYhDVskE3s3A+alBXPzG5IPX8o1zF46z+ZGUBNdZrf05/SU0tTulMmc63nJVxHb951BU6tb4cGbKajxALD0fvA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oigwDysS; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oigwDysS" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-48897fd88ebso16931235e9.2 for ; Sat, 18 Apr 2026 07:55:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776524116; x=1777128916; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ohVPZ4YjTwemU1YLhcK998ayf74B+HEeQBs83FoZEM8=; b=oigwDysSeVqOP5ro1KMDg2XDeS7kqCAIS9tzvNZuvaKv2AiN4iMiEXR/0N2hiiA+wC Cjlf+4UOUn4B+50sj7xYrcKehi3ctdRqJprcjuyAYknqP2hGg1LSko4GvPhYRbRakGO/ 4D5iUovmsU34S7B2FfOtis0UGN26sAPKmEpFrC/fx6Ky+7USBrxwijzobBo/NYJmIXj4 vynoGW/Fq0aliRTjY2SfK7RgUHIm5suAk1xHm5StqI11O5kwj0Q2TdFCrlp9KTwSUpNZ br++ISDjjJJsxH/wY3ovhSSE5ApBmjwe1/yc+RGjyI+NK3SBh5az0qmR1bY0h3uYfFN4 maVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776524116; x=1777128916; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ohVPZ4YjTwemU1YLhcK998ayf74B+HEeQBs83FoZEM8=; b=PNMMbdck14FXw9tllitOU6DOgxkpw5klm7KB/qiszxbnDNXY2DJFhgOkuIzv440mBN 0BTDIXT7spxtwWXwk5pf3KCa1mZnVMPNRxYWV4lz+Ty/KB6834mk4FmzYXoEvvqd+XCZ qanKegyscWtMySbYsDRV70BK1+02L6oHp7KMOHpoXrosRiqRa/nmbnDwU35qfomcVLmj 45R07s02pFQpcns2tf5w8zu/cBgMdyiQVBfCfvpxiEQMcZuFsNSQ2mzN9nNRCaFJMeR3 lPAiqBc3YYFrkFZr6zMK/VjZlUhQhYnCb3utgeOJaAa0PpnIaHkLc1zfdZpvAhZIIyus 7R+Q== X-Forwarded-Encrypted: i=1; AFNElJ/CjPZY/GUeHlfXktuU7h+XwTl8v5ibNmx+A6Z6c1pk5F1ASnYx0dC45GFZPGRvYpN4bq13ss/ijJORBJ8=@vger.kernel.org X-Gm-Message-State: AOJu0YwTluW39EexCwIlHT804k0FUQ5j1KhvT7FYz3a3+34DhmcOVHlE GJv3wgaOtEmXHP+6TONEQMFKjrXuFaQFKjhDFE3NUSu+5Hqp4Q90AFgN X-Gm-Gg: AeBDieuZbpmGeF9M2hS6zpcaXjiD1NKr4O+he3NBDGx+8KFoFDkzuDmlPWkt83lBCvN K55m6z0XD2KbbJdLbbAnF6hMcHqTrbl4qzKHB++PsC+GWIcVoKjCYI5xnXR+S7la58MXQmOFxb+ 4vQkpOEL18Oysv3YlrCgcyhBR2O9LpUFp9QRLPcqJvr4BjFFVqoZzT2Hs7WeAYHas/C1d3Mkyfg GzeGLfc0l23b9Ki6HfHknXvgK4zkTxopRV1zCmD90O1rzXVoVArGgPyq1urOujHrxKP2M+juLDs lsR6kKvE1Wn4NctMIelfbM1Fw2IwpzXXyo6gY4+fHlLWj3EGnE6eX3/+5RlmzTjQ79ui/nRXfed U8wdD06udmU13eW3+1f3Ib7eOtZADBZPSyo8LFvBfQEr2T4Dpl9BfURZYvAIhmJOJ0PD1dvGqG/ rJMu7QbQRdisMZw+TBBy6BxEVXz6WURQ== X-Received: by 2002:a05:600c:c04a:b0:487:12c:e7e1 with SMTP id 5b1f17b1804b1-488fb750840mr73962705e9.11.1776524115625; Sat, 18 Apr 2026 07:55:15 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fb754f15sm43693535e9.9.2026.04.18.07.55.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Apr 2026 07:55:14 -0700 (PDT) Date: Sat, 18 Apr 2026 17:55:11 +0300 From: Dan Carpenter To: Yuma Ochi Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] staging: rtl8723bs: Remove boolean comparisons Message-ID: References: <20260418144916.361744-1-ochiyuma.ochi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260418144916.361744-1-ochiyuma.ochi@gmail.com> On Sat, Apr 18, 2026 at 10:49:16PM +0800, Yuma Ochi wrote: > @@ -1950,8 +1950,8 @@ static int recv_indicatepkts_in_order(struct adapter *padapter, struct recv_reor > > /* indicate this recv_frame */ > if (!pattrib->amsdu) { > - if ((padapter->bDriverStopped == false) && > - (padapter->bSurpriseRemoved == false)) > + if ((!padapter->bDriverStopped) && > + (!padapter->bSurpriseRemoved)) Originally the parentheses were not a problem, but now there are too many. Same thing in other places as well. > rtw_recv_indicatepkt(padapter, prframe);/* indicate this recv_frame */ > > } else if (pattrib->amsdu == 1) { regards, dan carpenter