From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.formilux.org (mta1.formilux.org [51.159.59.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B421615746F for ; Sun, 19 Apr 2026 16:10:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=51.159.59.229 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776615010; cv=none; b=aSdnwZ7voj+LWskNeyddh5wj2C09zUj3heiW4UBDPI03yX7FypEav0yDKsoSKotInObXBSjkqa2iC7ZXDd5D/KQ0d24pIt3BYuR0rJiQ0jZYibD5cK9DF2Fa81q6N5tNBNblA5FpPoDnZg4jQybekU1HQO3OZKoSe2re5qCCxDw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776615010; c=relaxed/simple; bh=2SE9mjsFdpciqMlEJtxx0NnJ0JeT6WeTJbwEc0AM3Gs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NaEXSixzeGqms6ZXs6uWBvP495+ILPePldzbx5paqXrJFHTVpjqoetHQVi99czkvqkE42fwkb3K3+Wgk4eSZ95ybeXgYitetMorqsmCrfvCw00dsUVx6qaTOV8V5gNM//CVTOasNPBWr/mnSsQP9c1EwPDtopQkqQEzMiGvIjTc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=1wt.eu; spf=pass smtp.mailfrom=1wt.eu; dkim=pass (1024-bit key) header.d=1wt.eu header.i=@1wt.eu header.b=Ye2sAeWa; arc=none smtp.client-ip=51.159.59.229 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=1wt.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=1wt.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=1wt.eu header.i=@1wt.eu header.b="Ye2sAeWa" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1wt.eu; s=mail; t=1776615008; bh=KaLRmy1JRo0h00B0TUHpLhZfjN4eCLeqIp834yZaMC4=; h=From:Message-ID:From; b=Ye2sAeWaOT/BKxgVxivFjZFby/M4rQQfMmJgBydrsMqDJwMw2wlEzULQrYipYdBoV dVm9SP00Zwlk1e/4N6OuIDuTp4+LCE/5ce7lCjXZndeSyjxz76XpuzjSmY5Mx636PZ 9nTNMOLyQXxXmq7+Ly3/OjNhRb/q22RQuR/hAx7A= Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by mta1.formilux.org (Postfix) with ESMTP id 09922C09BA; Sun, 19 Apr 2026 18:10:08 +0200 (CEST) Date: Sun, 19 Apr 2026 18:10:07 +0200 From: Willy Tarreau To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: David Laight , Daniel Palmer , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] tools/nolibc: also handle _llseek system call Message-ID: References: <20260418-nolibc-largefile-v1-0-b91f0775bac3@weissschuh.net> <20260418-nolibc-largefile-v1-1-b91f0775bac3@weissschuh.net> <20260418122340.1dc07834@pumpkin> <6fe77be2-39be-4976-99d6-aced2bf3d955@weissschuh.net> <20260418170340.775bdfa7@pumpkin> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sun, Apr 19, 2026 at 05:38:26PM +0200, Thomas Weißschuh wrote: > The "preference" the commit message is talking about is not the > ifdeffery as quoted above. Rather it is in the *outer* ifdeffery. > > > The commit message should rather say something like: > > > > On some architectures the llseek system call contains a leading > > underscore. Fall back to it when llseek is not available and use it > > for the lseek system call as it is necessary for 64-bit offset handling. > > The preference is llseek > _llseek > lseek. The important bit is not > the order of llseek vs _llseek, as these will never occurr together > anyways, but that _llseek is preferred over lseek. > > What about: > > On some architectures the llseek system call contains a leading > underscore. Treat it the same way as llseek and prefer it over the > plain lseek system call as is necessary for 64-bit offset handling. Got it now! That's indeed clearer and I initially misunderstood it as what you debunked above :-) Thanks! Willy