From: Jarkko Sakkinen <jarkko@kernel.org>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tpm: eventlog: remove unused structs tcg_algorithm_{size,info}
Date: Sun, 19 Apr 2026 15:10:13 +0300 [thread overview]
Message-ID: <aeTGJRthnFZ_wxlz@kernel.org> (raw)
In-Reply-To: <20260417105516.552735-3-thorsten.blum@linux.dev>
On Fri, Apr 17, 2026 at 12:55:17PM +0200, Thorsten Blum wrote:
> Remove the unused structs tcg_algorithm_size and tcg_algorithm_info.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> include/linux/tpm_eventlog.h | 16 ----------------
> 1 file changed, 16 deletions(-)
>
> diff --git a/include/linux/tpm_eventlog.h b/include/linux/tpm_eventlog.h
> index aff8ea2fa98e..615bd0af5173 100644
> --- a/include/linux/tpm_eventlog.h
> +++ b/include/linux/tpm_eventlog.h
> @@ -114,22 +114,6 @@ struct tcg_pcr_event2_head {
> struct tpm_digest digests[];
> } __packed;
>
> -struct tcg_algorithm_size {
> - u16 algorithm_id;
> - u16 algorithm_size;
> -};
> -
> -struct tcg_algorithm_info {
> - u8 signature[16];
> - u32 platform_class;
> - u8 spec_version_minor;
> - u8 spec_version_major;
> - u8 spec_errata;
> - u8 uintn_size;
> - u32 number_of_algorithms;
> - struct tcg_algorithm_size digest_sizes[];
> -};
> -
> #ifndef TPM_MEMREMAP
> static inline void *TPM_MEMREMAP(unsigned long start, size_t size)
> {
NAK. If you are doing something useful here then it is fine.
The only feature that pure cleanup patches cause are potential merge
conflicts when backporting actual bug fixes.
BR, Jarkko
prev parent reply other threads:[~2026-04-19 12:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 10:55 [PATCH] tpm: eventlog: remove unused structs tcg_algorithm_{size,info} Thorsten Blum
2026-04-19 12:10 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeTGJRthnFZ_wxlz@kernel.org \
--to=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox