From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f173.google.com (mail-dy1-f173.google.com [74.125.82.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A467F6BB5B for ; Mon, 20 Apr 2026 00:14:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776644041; cv=none; b=GEq7AE0fi0Ya6J8SHjxkDqn78BbyX901sMmMq8E3IoveqRN2XHe83JaQXRzieeMnfLZIAvPMCLGN2Acrs0Q29gH/598LBMO4rE4IX2r/m1Uxv/OHvQwGY83X66gDDxduy7EoO0Vrs94ReKydL2+eukTz3nTxaugX2hP1bYmbZfg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776644041; c=relaxed/simple; bh=8e6o2e3S2kEpCh7AnUm8Lw8k4A5RfrAJ6mTx35sXCWI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rtgcmqscoJx5ZqXb7ZZXYpHEnN3OJV5kJxjMFxt7qPWbQcvlk8jFGnQcvpql7CkApNvaIUFk11723b4Gcfkb0ypwgvJM5xCSC+HEK4RhnOWO2hvWyjybhsGqW7X8xhHq4wfPzzjS3siba/ZfXPUOBr4zCgys5yL4KiiKCuOY/KY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=o6zSy1tM; arc=none smtp.client-ip=74.125.82.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="o6zSy1tM" Received: by mail-dy1-f173.google.com with SMTP id 5a478bee46e88-2de831d2b20so4984114eec.1 for ; Sun, 19 Apr 2026 17:14:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776644040; x=1777248840; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iQb96jxVBSn1C0UL8YusHfEi4afe/T/8UPw4t0TEFHI=; b=o6zSy1tM1wbRw+6bcSBnRybTMGq7xiM2L1J2hlwOWlnURCk/LW3J8037WeKj3aw+vq 1EnmlP8vgoynuessjLkCNFsve7J69YaGZhgmW2HrgRW6wSUFK/6hIQrqruumnZLPxp1x QzvNMm2KbqO5Pe7XjKwn+9gtXF7fP4wDbjuXFPsy4nI2uoX2K2lACziYCRNMb5vKUrBW afvMMDrbPcyvwpOxcUF8OoOGaPXgIKpMFV9bAEF3HhPPLqvlqRjXB4qwJtNiEtlJm5EE 95uxaFvw0rFjI+I/1A8gQaKruleXqQv6njGs8vxcFRHsjK5wszENXQ6NTA3RbQwJwH3c 9flQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776644040; x=1777248840; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iQb96jxVBSn1C0UL8YusHfEi4afe/T/8UPw4t0TEFHI=; b=rX0ogaK9YkcjPGtScFNOREas5NCa5dL/hO4kuP4GY0B53U2Gg04LP18HqP22gDVUEK 69J/UYCXz9fo/60Fk2/xvYDaBUn2TB04DmcXd9DBBIx0/yd3WAQhTDp43g4f36421JDT SGkUTc+5bWB68k1Jt/6Fh3cGaeEksWT/950Yjq8zypJDjBlA/OOXxyyMnKxe2cQOAUrU EAaBkud20p+pNecbYaqNK9zLy+U5BgIT/nPG29N2rp4KHrOnCDpVU8SO9kNKpx8+tM72 e+iIvjQ2im1v72cnUXUhyaQPgevguzlWTsgWT/h04LxpAQvfrA88zZXR1b+PUxCHHStM rnYg== X-Forwarded-Encrypted: i=1; AFNElJ+eaS4ZkgrMOIAMhIm4XfO3sdBte+kSEOEYUidJjRSJ8j52J+lRXMaC497CwDlwBEfmbti6N739+JrTx7E=@vger.kernel.org X-Gm-Message-State: AOJu0YwuXr2Q/8yHE5EiEFLSr+3Fd9h1JtbFWuv0LelakPX6plqQMI91 0pq6I4X66bhB1dWhdVkOFz5NSjfhs0DEb9eRiGM28VyHE+Ot/8oA0SIO X-Gm-Gg: AeBDievbn6oCcdVy0+00Aovax9J9n4uEF1w9d8J97VqF2cTC273Z9D2tEcA2MZIzcxe r/XrdgQ0ECXlWJOw2MfDwKih/bij33ofD1uKc5ATLBgtkftzCRtzavmhv3ewVE40wfUvleo3RDO JKIVhg07bvh4HOmAe3Ytp0NggrG3EcmVPpCmzKRCTRK6BD8NoxRmE23GkrSVnr4AJwumIavZQfj h0Tkebv5ki8FhL75i5o4gDt0/okQXn7qfgtgj4Q+YUJXQGzI23ARyB/vuvqnjhs2jlZZeee11sR 9gQgHDDZk4aelzCK+YA6toCaItp8WzT9xIoDWPtTy2d967Qw6aiB73EETL3vXbKeK80u8ZLV4UI xrbaXHV/Vir15ifnqlKnjLyIJSQkb8KDsnZFlUR4PgFtIFYYAKZODukRP8rQzec2LtYzAZmpZat BMGEQTVQiUsWZ5Stzq+tS0nnoECfr3i7rHZEH9IXGCgHvFG/RIOS593q21KYxv13/htciy/4YkX Hg= X-Received: by 2002:a05:7301:4586:b0:2c8:7172:3b7b with SMTP id 5a478bee46e88-2e478646190mr6601303eec.18.1776644039839; Sun, 19 Apr 2026 17:13:59 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:1a4e:4965:5dff:cdee]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2e53ccce440sm11587954eec.14.2026.04.19.17.13.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Apr 2026 17:13:59 -0700 (PDT) Date: Sun, 19 Apr 2026 17:13:56 -0700 From: Dmitry Torokhov To: Aaro Koskinen Cc: Oleksij Rempel , Janusz Krzysztofik , Tony Lindgren , Linus Walleij , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH v2 1/2] Input: ads7846 - restore half-duplex support Message-ID: References: <20260419161848.825831-1-aaro.koskinen@iki.fi> <20260419161848.825831-2-aaro.koskinen@iki.fi> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260419161848.825831-2-aaro.koskinen@iki.fi> Hi Aaro, On Sun, Apr 19, 2026 at 07:18:47PM +0300, Aaro Koskinen wrote: > +static void ads7846_halfd_read_state(struct ads7846 *ts) > +{ > + struct ads7846_packet *packet = ts->packet; > + int msg_idx = 0; > + > + packet->ignore = false; > + > + while (msg_idx < ts->msg_count) { > + int error; > + > + ads7846_wait_for_hsync(ts); > + > + error = spi_sync(ts->spi, &ts->msg[msg_idx]); > + if (error) { > + dev_err_ratelimited(&ts->spi->dev, "spi_sync --> %d\n", > + error); > + packet->ignore = true; > + return; Sashiko recommends trying to power down ADC on errors, what do you think? Thanks. -- Dmitry