* [PATCH] staging: rtl8723bs: remove redundant else block in sdio_halinit.c
@ 2026-04-20 14:16 Demir Özdemir
2026-04-20 22:47 ` Ethan Tidmore
2026-04-21 14:34 ` Luka Gejak
0 siblings, 2 replies; 3+ messages in thread
From: Demir Özdemir @ 2026-04-20 14:16 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel
Remove redundant else block after a return statement within if block in
rtl8723bs_hal_init(). Identified through checkpatch as a warning.
Signed-off-by: Demir Özdemir <demirozdemir@disroot.org>
---
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index f2f73c65a636..809f07855bb8 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -654,11 +654,11 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
padapter->bFWReady = false;
pHalData->fw_ractrl = false;
return ret;
- } else {
- padapter->bFWReady = true;
- pHalData->fw_ractrl = true;
}
+ padapter->bFWReady = true;
+ pHalData->fw_ractrl = true;
+
rtl8723b_InitializeFirmwareVars(padapter);
/* SIC_Init(padapter); */
--
2.53.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8723bs: remove redundant else block in sdio_halinit.c
2026-04-20 14:16 [PATCH] staging: rtl8723bs: remove redundant else block in sdio_halinit.c Demir Özdemir
@ 2026-04-20 22:47 ` Ethan Tidmore
2026-04-21 14:34 ` Luka Gejak
1 sibling, 0 replies; 3+ messages in thread
From: Ethan Tidmore @ 2026-04-20 22:47 UTC (permalink / raw)
To: Demir Özdemir, gregkh; +Cc: linux-staging, linux-kernel
On Mon Apr 20, 2026 at 9:16 AM CDT, Demir Özdemir wrote:
> Remove redundant else block after a return statement within if block in
> rtl8723bs_hal_init(). Identified through checkpatch as a warning.
>
> Signed-off-by: Demir Özdemir <demirozdemir@disroot.org>
> ---
LGTM.
Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>
Thanks,
ET
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8723bs: remove redundant else block in sdio_halinit.c
2026-04-20 14:16 [PATCH] staging: rtl8723bs: remove redundant else block in sdio_halinit.c Demir Özdemir
2026-04-20 22:47 ` Ethan Tidmore
@ 2026-04-21 14:34 ` Luka Gejak
1 sibling, 0 replies; 3+ messages in thread
From: Luka Gejak @ 2026-04-21 14:34 UTC (permalink / raw)
To: Demir Özdemir, gregkh; +Cc: linux-staging, linux-kernel
On Mon Apr 20, 2026 at 4:16 PM CEST, Demir Özdemir wrote:
> Remove redundant else block after a return statement within if block in
> rtl8723bs_hal_init(). Identified through checkpatch as a warning.
>
> Signed-off-by: Demir Özdemir <demirozdemir@disroot.org>
> ---
> drivers/staging/rtl8723bs/hal/sdio_halinit.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> index f2f73c65a636..809f07855bb8 100644
> --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> @@ -654,11 +654,11 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
> padapter->bFWReady = false;
> pHalData->fw_ractrl = false;
> return ret;
> - } else {
> - padapter->bFWReady = true;
> - pHalData->fw_ractrl = true;
> }
>
> + padapter->bFWReady = true;
> + pHalData->fw_ractrl = true;
> +
> rtl8723b_InitializeFirmwareVars(padapter);
>
> /* SIC_Init(padapter); */
LGTM.
Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
Best regards,
Luka Gejak
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-21 14:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-20 14:16 [PATCH] staging: rtl8723bs: remove redundant else block in sdio_halinit.c Demir Özdemir
2026-04-20 22:47 ` Ethan Tidmore
2026-04-21 14:34 ` Luka Gejak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox