From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E491D3C5DBE for ; Mon, 20 Apr 2026 14:20:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776694831; cv=none; b=ffJhC21M7WS2zNIwePuJxFvsYBHZp9lCpDrtEmE5QBTJip24wEoBl8nFOvR2Jxl6pdwNXPvs4IxuuQHvifI4HBQf8MMfGdbJkdS6OZu+yRdIXW6ZTpMIWtgOraPLMBv/CYY+JjFShyEgVrmny6AImsS/W5EHzZSnktmfA1B1ndQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776694831; c=relaxed/simple; bh=JmeOw989Ii+YNJAm7GuphtKEYNddmDvGiUCwoY6MGLA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gi42KzuVKLf3hoXm2nihGBQHHVZHDEdyJgdmGDEUPixOEjzm3E/j91K3FmqWXrAd9BMJ3Ql9IZWROhgWe0+vPhrQ3NjVtuyy5SQcLhNiVlpu7PqT7T3GsyAeCQwlHtt3kDwGdmnGMxeOpqvsXDkgI4DblbZHS/ulvW6ArD3mPQ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nqsqJZzY; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nqsqJZzY" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4891e86fabeso11670095e9.1 for ; Mon, 20 Apr 2026 07:20:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776694828; x=1777299628; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xn6gG3lmWAIV26Onf4TDKzqGtizzY94BWkPWcIHkOfs=; b=nqsqJZzY3rOirBFTCxe/BmepmgGD3pzotzEan3HQT/P6SQdyxS8NgVF80Yth9Q8XPQ /73wY8OgudGI0KaT8gNRpLykUeoCBUxpOD9YGHt/PVTh18gfVb05GIQVkX8Jk0sYKkkv jtPMtCwBLu0lawOvkfFqZIr10YQ6zRPPZJ362FLomJ/jRmugkmPLD5VJVbtsJlC+j3xq RCyKCvxI3JOgNHMDq/ks3vy/TzMWgqE9+XXBeUZtWKd0ZSodq6PKXjOu3sbXuJYidCcY gYI3LE/wigeN0ySaFprc0T3QiXbE5/JjWvMH8Zs8d7fDTXIVFGoNXFQDY0CXQJe8yoSU GSyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776694828; x=1777299628; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xn6gG3lmWAIV26Onf4TDKzqGtizzY94BWkPWcIHkOfs=; b=CvKweak3wsb1nK/v7u4CGGkgGAtv5jT0VwgsK+cJnOxy+WAJLvTypJtlq9nc9ll+wD gCh5yJU1WQQl0uG/7CAWODRYslEEZlRYAqwzTYbUtEZaOuzqcljHFKAruOCYTgaL75Gl aSg6ihVSL54cnjW6zRKotCEwQld0z6Egx3kaQBisX8HiTnZMSUtDyJ8nXVP4fSrJBL79 RLRL/Pxd4UrLzzogOo3VNrJJKYRE2lknftD6KEoMp8YCIIIVwdzvg8aISrXM1mP+kaGX jBZ2Y3maP7eXC2rdt6oFLwLNFevoH6b+9zwcauKaHcS3wXz7WcsYOzPgOqKLhX6U/p2M 4uqw== X-Forwarded-Encrypted: i=1; AFNElJ9VE23cGUn2ARKomppMtDWDLLNf33e/z9qf6UqF0GLK7/fEO6sB0W5CMy3dz5skVKP9MN3qFTK0WFCGBnk=@vger.kernel.org X-Gm-Message-State: AOJu0Yyq9Ihuqx3J2YOsMKIS58gCgIsOqebh7sVrn/kDpTozJaDrPpDP o3XIjOs1whGSvCBkk5rDU28XboiIK7ZX2o8HSBp8dGAIYw3DgnpPRRNs X-Gm-Gg: AeBDiesO977+z+NN89XuR08oGJfZXFmXunA6jcAy8u9/7b35M6QNmBf6Vf05O1Iu0jj vAMhV6Glx0YWAf1eVfBXzcwm8wLVx2JJ8lGYSY2zO5N2AxA1HO1wEyP2037Zi6vKRpgt2Z3+5Fn xQ+s5E+DaF3k0cJRdYuJ6mIdPdbjXGEf17luLdONisRRRgvYpTCx7KasG0Dn+btsYzSlOU13ZcN UjYCA9fC4ES9HMcVoteJla5kd34Dy5K/v6wNiTgvQktIoVPvcxhkzmIguPwTdKm3n9NuSMCzw9d TYpguSO7vzznrtInrOtBi5VGtdP7iCNAcdV4TXxHuU5EOYys9ItlIaRDnyrF0zWXj3hrUp98ryh hW/zkcP3VSL1w+SurVURQyhjF/XYJJiN3GgA6TI8EwNF8M8vrFKBCzstwT+LIbCjLWc+jj8gykd tbNnlctl6pqJksvZJRC1vYBe/ybUpyjA== X-Received: by 2002:a05:600c:1d19:b0:48a:525b:e157 with SMTP id 5b1f17b1804b1-48a525be257mr26409375e9.13.1776694828164; Mon, 20 Apr 2026 07:20:28 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4891df9e50asm59731985e9.0.2026.04.20.07.20.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2026 07:20:27 -0700 (PDT) Date: Mon, 20 Apr 2026 17:20:24 +0300 From: Dan Carpenter To: Yuho Choi Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, Hans de Goede , Michael Straube , Andy Shevchenko , Minu Jin , Omer El Idrissi , William Hansen-Baird , Ethan Tidmore , Ingo Molnar , linux-kernel@vger.kernel.org, Myeonghun Pak , Ijae Kim , Taegyu Kim Subject: Re: [PATCH v1] staging: rtl8723bs: fix stale recv_frame free in recv_func_posthandle() Message-ID: References: <20260420042734.3685-1-dbgh9129@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260420042734.3685-1-dbgh9129@gmail.com> On Mon, Apr 20, 2026 at 12:27:34AM -0400, Yuho Choi wrote: > recv_func_posthandle() saved the original recv_frame pointer before > calling recvframe_chk_defrag(). > > On the last-fragment reassembly path, recvframe_chk_defrag() may return > the first fragment as the new frame while freeing the original > last-fragment frame when draining the defrag queue. > > If process_recv_indicatepkts() then fails, recv_func_posthandle() frees > the saved pre-defrag pointer again, which can result in a stale pointer > free. You seem to be saying that process_recv_indicatepkts() frees orig_prframe. And, sure, that's true. But then it returns NULL and we goto _recv_data_drop so we don't hit this path. This seems like a false positive. regards, dan carpenter > > Free the current recv_frame on the failure path instead of the saved > pre-defrag pointer. > > Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver")