From: Dominique Martinet <asmadeus@codewreck.org>
To: Breno Leitao <leitao@debian.org>
Cc: Eric Van Hensbergen <ericvh@kernel.org>,
Latchesar Ionkov <lucho@ionkov.net>,
Christian Schoenebeck <linux_oss@crudebyte.com>,
Andrew Morton <akpm@linux-foundation.org>,
Eryu Guan <eguan@linux.alibaba.com>,
Yiwen Jiang <jiangyiwen@huawei.com>,
v9fs@lists.linux.dev, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] 9p: fix WARN_ON when dropping nlink on files with nlink=0
Date: Tue, 21 Apr 2026 00:59:51 +0900 [thread overview]
Message-ID: <aeZNdxmYw1K0Swg9@codewreck.org> (raw)
In-Reply-To: <aeY32gOaV5jw1s8F@gmail.com>
Breno Leitao wrote on Mon, Apr 20, 2026 at 07:31:14AM -0700:
> In cacheless mode the server is authoritative and the inode is on its
> way out, so locally adjusting nlink buys nothing. Skip v9fs_dec_count()
> entirely when neither CACHE_META nor CACHE_LOOSE is set, which both
> avoids the warning and removes a class of nlink races (two concurrent
> unlinkers observing nlink > 0 and both calling drop_nlink()) that an
> nlink == 0 guard alone would only narrow rather than close.
I need to check this doesn't actually leak memory or something but this
sounds better to me, thanks.
Please send as a proper PATCH mail and I'll tentatively apply for 7.2
(a bit too late for 7.1)
--
Dominique Martinet | Asmadeus
next prev parent reply other threads:[~2026-04-20 16:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 10:23 [PATCH] 9p: fix WARN_ON when dropping nlink on files with nlink=0 Breno Leitao
2026-02-15 9:27 ` Dominique Martinet
2026-04-20 14:31 ` Breno Leitao
2026-04-20 15:59 ` Dominique Martinet [this message]
2026-04-20 16:26 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeZNdxmYw1K0Swg9@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=akpm@linux-foundation.org \
--cc=eguan@linux.alibaba.com \
--cc=ericvh@kernel.org \
--cc=jiangyiwen@huawei.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=stable@vger.kernel.org \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox