From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1B7C3B777D for ; Mon, 27 Apr 2026 23:57:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777334252; cv=none; b=bMEmxcHv6k5aLt+BFSf56vRJ6ftqMOsmvI7XYGVIt581GmPp+mse+dJ49uS3wL+itKuA/ZkZ1ppkwlssgxirl/HHe2a95bQo0gk1PninnXi9l9HV+XKG1X9BwLc73qK715GpikdSZUpSmxgzC5XuX7QdhdydG2DSqlcezPZ+4P4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777334252; c=relaxed/simple; bh=86DrBS62pVYvlVqPazZF8WmjJYiZ2Z/t6aa8S1r0X3w=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=n9cprmsKzLgz0a83ukiJ4XwmCcu9HLy8VtX0UtGKlLV6UweXCJ0j21JLeoWjsKP0tSCTZeBd4cjkGIylD0dK3IX5uo85ZaRHpDeUnLBA8KT6zUOZdVZ7i7eZazP5+jrWMDQ/u+kfztqs+Kg1EJ/nL/4L8FEo6q3ofXK7gv7XqWs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=D9VHBvKw; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="D9VHBvKw" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-c709551ec08so11974255a12.3 for ; Mon, 27 Apr 2026 16:57:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1777334250; x=1777939050; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=r/RnEqD3499secxRAPp9I9KKYomN5qQi1oKzwuOX5gA=; b=D9VHBvKwitU4nJ1n5/c/uZ/me8tC5so4C2bAqNz9NzkXy5QjZmdpeRzFpEuIgmwx4h YF2QBRb0kSQjlW6w1rJx8lkOSUSauofdmEQXKrsfJRRajt6yoWYaN9NKetshG/dq2ouX Flq2xLObhAcdc7yL4ko31C2bqQUFsdjIcOlj+/rP/mTf2Hxd6Lhmu66gkgVkj4oTDKRh unNGjnhZ9f0GZRBsbXwkt8XF/K2gt46t46Fmxi7fi3DpUBGyZHCNxKSUVyXZrcEkJ2PP JXehv3vIuaWMDYbNeJbOgIuCZU7+q50paFFjGlr8EZV1OY5dNzMMWWTmn9iCPUPLaU0M WbwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777334250; x=1777939050; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=r/RnEqD3499secxRAPp9I9KKYomN5qQi1oKzwuOX5gA=; b=HUtu+7i+NXh2jro8PTEk2Tb0PRmn3B1t+LlgHNlW8SoiPZ+NP9y4IkKT74zmN+N5jm yyraIzKj/JhhVR4q4n1IxWjx88cUvQTkDAQDfIXd12nSK8uOdbQX2pQ3QIwfonJYFVa6 Awy7u0LPW8sazXHwQ7zqaV5ei7OoQqhMw2MgcSIJTK/lsmQcIRzdl1yk35fhMD0dpson l1HVzdbAix/IeHGRLTLKUmAtl1eD3yUchC8X+vwDp5xqgOJ41x8A2u2+Gb6nsYr8IzZd YC7YxnNcBZZ2R2hKVIe1DIXMHUyk0YIbL1PpPSY6E0pSAl41xiILlfWYLZLfjaehSCE3 HCPQ== X-Forwarded-Encrypted: i=1; AFNElJ/PF+YunTGs88TeIxQxdHJYUyGD7QMfxbjLpDWRkc5CLGBVgNg0XUh/9pBvsS1rJv9Ipmu5c0TsbZbOy0U=@vger.kernel.org X-Gm-Message-State: AOJu0YwkJxyQhE9cZBOD/HevbNZnorNxp1qrOTgE28lWzJ8Mu4WhpjMs gCkz/Vx44ukT8xTv/RsEOomRom9tQHLQTXdPoR6ZYIXQ++OmKVQqONmPcPDEObZ4GQ5VFiaO+u8 WfhjYuA== X-Received: from pgcl22.prod.google.com ([2002:a63:7016:0:b0:c79:22b6:a345]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6300:210b:b0:398:7256:3c0 with SMTP id adf61e73a8af0-3a39c12aa43mr912602637.13.1777334249978; Mon, 27 Apr 2026 16:57:29 -0700 (PDT) Date: Mon, 27 Apr 2026 16:57:28 -0700 In-Reply-To: <34e88a990e667ee402238a13a63b224dea1bcfa0.camel@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260427204313.50741-1-rick.p.edgecombe@intel.com> <34e88a990e667ee402238a13a63b224dea1bcfa0.camel@intel.com> Message-ID: Subject: Re: [PATCH] KVM: selftests: Include linux version of mman.h From: Sean Christopherson To: Rick P Edgecombe Cc: Ackerley Tng , "pbonzini@redhat.com" , "kvm@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Mon, Apr 27, 2026, Rick P Edgecombe wrote: > On Mon, 2026-04-27 at 16:39 -0700, Sean Christopherson wrote: > > However, for mman.h, we actually need both.=C2=A0 linux/mman.h provides= the bleeding > > header flags and definitions, but sys/mman.h proves the syscall wrapper= s that > > selftests expect/use.=C2=A0 The below builds because sys/mman.h is gett= ing included > > elsewhere, more than likely by tools/testing/selftests/kvm/include/test= _util.h. > >=20 > > Rather than updating individual tests on an ad hoc basis, what if we tr= y our > > best to handle this once? >=20 > Sounds reasonable to me. But I couldn't find the base commit that let me = apply > this in order to test it. LOL, it's probably a good thing you can't, because it'd be a bit embarrassi= ng on my end. The shortlogs I have locally are a mix of "tmp" and NSFW exclamati= ons of frustration :-) > Do you want me to turn it into a patch? I can just send it as a patch? It'll probably be more work for you get it = applied.