From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D098C366072 for ; Mon, 27 Apr 2026 20:32:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777321932; cv=none; b=LxfuC33BhkHIPx0K5q8gezNihnsXy7vhoPIC8vI1Ct+ivPE3WdUWP+K8uxr5uwLA4VvZbJKYBI23GKJiJdFodJuG/p+o5tRaW5EV0/dCReTY4/8DA5T/pPWU3wmlf9UT6wprYE0WDZXc4PxO3ZB7gq+pINygMQz2/OaF4Eh7P8M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777321932; c=relaxed/simple; bh=asBYEW5RtnsuFUIQ5ieSno/X6K7JGe38WVWZ15KVzeI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hISfRKHcA87+Pvite45pxcKbnzUrM00GTK6xTimdeeY8bigiTFtrgLYtKJKyyF8GB5REUVybs4TFmf8DqywVmWHtjoDUi2YDQrLdKY+L1JqhkIjQIXgwGl/1PfV1Df5Qv4JyvvfL4XrPlPWKFvheXDpp3XRepFuGfg7S+CAWDC0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=huHfNdXo; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="huHfNdXo" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4891f625344so96492905e9.0 for ; Mon, 27 Apr 2026 13:32:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1777321928; x=1777926728; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vtsGRC0FacbegB0AwrvJfP/Z12ZLNzAQIxUg9a44s5w=; b=huHfNdXoSFz+MDB7m+4flN9vf1ZRcZ7Fs/e0yDdl5I5q1zJQc9GqFhANMDG5VQ/EQo GEulwlhn7tc57+KG7xw18i2Tfz3GVAkYFORNL9tlZBMvuSpOQFOtQaS26Lshexdcxygl 71yAFnFO46Bl5m/CpYRIhrm1Uny1tWval4mK2GhUCNcqnXGFji/YRNpU0kJ+dwnGtOIR 8d8bm/cIfScv7CVi7wX4wJ8fG7THKTs/H2xUnmWuKB6Bmn2HQ9NPcLPbolYFgS/KfEYz qzuZCOD0Y2stCsp+aA7YOXTYoI/iINJ+dCv3nkDv2lN7/jqkwmjCIxjLchwEIhfYiFAG C9wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777321928; x=1777926728; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vtsGRC0FacbegB0AwrvJfP/Z12ZLNzAQIxUg9a44s5w=; b=VHGqTLaHcyfXyEYmr9m1ns32jAZTgTI0XzdnZpMODmOn1WnUmiEl+QundElFPrQ8bm 2a+0UtV48M5HSt0PUApBfJrRG5h+/9VGpWiZCgOFf4QCIr0ZlT6Dmd7ncB5XT/sCLkIa iT3bPeYoPTXRe87LrIqfzYFJlLNCtQQi64ckSYjLi5f7qAoVMOGr3iM3EdHheoovgvjz bb1i8/iKAsGJAt7WlydmSjbM67iLb7A6Dz+iB22ZXBifJtr9RBYd4zYhqMHW5Md3LzFH 5IkY2xrqe+sOHOvcpRkuHuGLyyi4rxEY1EU9eeLdOsbhDjRvDwjA97sKs7gnUlcwyGGK 1Nxg== X-Forwarded-Encrypted: i=1; AFNElJ/BFchnIQQPVcN76kkLn7ktCdQpLNlp2vN1rFZDeEpaQ7uFLgXPnx69NmTed+P+ZfbVTjD9622rgaL+Xt4=@vger.kernel.org X-Gm-Message-State: AOJu0YyY/zI5bPYxhyqHsO3ZMVCq3Zv7a5sR7BI5tcuBUyQFcoAmn4d+ nU4tSRTL3yutg9Dd83fuAolF5TE8bImtXaUbVDbIJTPpM9q5d0sOgMZIo8k3qPYIkeKk5fxNSm7 EqL7f X-Gm-Gg: AeBDievTgvSrLfc5OBunq2jTtIcIuN3ozt/WGHwwJs1lXg+z8EPVS87Xv5J9Bqb3QE0 LtwRycgu8fhEkcVv0nqMgiinWt9Kxoq+q6kntNi1voYZJMwreBmBaZcum9KdC4qTHehlfSLSFgy Luo5H519E23cN9J/tXqhib0tZAjZ797emAehl0F7VkPPDILa/KvAcgp5m5S01+EIfsUH1hcEu1H bFmAzoiZFcBLp/0mme/oVTboSrrhQD2dxJjfvswhttL0cYB5r7S8X8PpdtRvtIqxYLX8CdscoJ6 Z6QxUT9Dr9GAzcKX10RTqum7rNAmCsf6S9PJuYKLeVCZxwK9dfJ27dAlQFXVfH4TSVjAqafVf/B RyKwB/WRuso7QOMIAlxdQhZ9BektbR9e+adMWAD7dwcHLNrQEUnO2f+iu2ldoPbqWRux0KIdngD 2r1GgRps75ByOF+Sehix+maJMY6BbK5lPP7JMetOI= X-Received: by 2002:a05:600d:8495:10b0:489:1e5e:2cc with SMTP id 5b1f17b1804b1-48a77afcf3cmr2718895e9.9.1777321928066; Mon, 27 Apr 2026 13:32:08 -0700 (PDT) Received: from localhost ([2a02:8071:b783:6940:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-4463fb7e366sm811816f8f.31.2026.04.27.13.32.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 13:32:07 -0700 (PDT) Date: Mon, 27 Apr 2026 22:32:05 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Matthew Brost , Thomas =?utf-8?Q?Hellstr=C3=B6m?= , Rodrigo Vivi Cc: David Airlie , Simona Vetter , intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/xe: Don't emit UTS_RELEASE as part of device coredump Message-ID: References: <20260427160902.1126027-2-u.kleine-koenig@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5nl4r2jq5dzig4bb" Content-Disposition: inline In-Reply-To: <20260427160902.1126027-2-u.kleine-koenig@baylibre.com> --5nl4r2jq5dzig4bb Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH] drm/xe: Don't emit UTS_RELEASE as part of device coredump MIME-Version: 1.0 On Mon, Apr 27, 2026 at 06:09:03PM +0200, Uwe Kleine-K=F6nig (The Capable H= ub) wrote: > UTS_RELEASE changes quite easily (e.g. uncommitted changes in the source > tree or new commits). So when checking if a patch introduces changes to t= he > resulting binary each usage of UTS_RELEASE is a source of annoyance as > it introduces changes not caused by the change under test. >=20 > It's little helpful to emit the kernel version in the device coredump, so > drop the kernel version line from it. >=20 > Signed-off-by: Uwe Kleine-K=F6nig (The Capable Hub) > --- > Hello, >=20 > I'm not really sure if my assertion above that the kernel version isn't > helpful is actually true. >=20 > If yes, there are a few more very similar changes to make: >=20 > $ git grep -E 'drm_p.*UTS_RELEASE' v7.1-rc1 drivers/gpu/ > v7.1-rc1:drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c: drm_prin= tf(&p, "kernel: " UTS_RELEASE "\n"); > v7.1-rc1:drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c: drm_prin= tf(p, "kernel: " UTS_RELEASE "\n"); > v7.1-rc1:drivers/gpu/drm/msm/msm_gpu.c: drm_printf(&p, "kernel: " UTS_RE= LEASE "\n"); > v7.1-rc1:drivers/gpu/drm/xe/xe_devcoredump.c: drm_puts(&p, "kernel: " = UTS_RELEASE "\n"); >=20 > Best regards > Uwe >=20 > drivers/gpu/drm/xe/xe_devcoredump.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/xe/xe_devcoredump.c b/drivers/gpu/drm/xe/xe_= devcoredump.c > index 558a1a9841a0..260e3f19286b 100644 > --- a/drivers/gpu/drm/xe/xe_devcoredump.c > +++ b/drivers/gpu/drm/xe/xe_devcoredump.c > @@ -101,7 +101,6 @@ static ssize_t __xe_devcoredump_read(char *buffer, ss= ize_t count, > =20 > drm_puts(&p, "**** Xe Device Coredump ****\n"); > drm_printf(&p, "Reason: %s\n", ss->reason); > - drm_puts(&p, "kernel: " UTS_RELEASE "\n"); > drm_puts(&p, "module: " KBUILD_MODNAME "\n"); > =20 > ts =3D ktime_to_timespec64(ss->snapshot_time); >=20 FTR: If the patch is acceptable, the following should be squashed into it: diff --git a/drivers/gpu/drm/xe/xe_devcoredump.c b/drivers/gpu/drm/xe/xe_de= vcoredump.c index 260e3f19286b..4ed1e4afa4c6 100644 --- a/drivers/gpu/drm/xe/xe_devcoredump.c +++ b/drivers/gpu/drm/xe/xe_devcoredump.c @@ -8,7 +8,6 @@ =20 #include #include -#include =20 #include =20 I will wait with a new revision in the hope to get some feedback first. Best regards Uwe --5nl4r2jq5dzig4bb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmnvx7sACgkQj4D7WH0S /k47UAgApSFviop5H5WcLHTrJ16SrGvoD/8b9OMezrcG6g/kkc7sBetFoXGKnsKi f9Qtxnbkdv0wur6dQsvKxzkX6RKGGn2ZXaEHbRC07FO4XIrkIebQ7YNWWE3l0VM3 8385S74OD9Hrzehrkj5ZFZ+NJ+tf6SJdwlZqE8lubXtZGzsIMrjC6yWglZXcU0+F cgP8I8+czIHWqLzgQ5KGusr8NTAPzkT4c4iI3mWboHyp3qP/vBba2dOFg9518Ao7 Q6RFQmY9PNCbOgBRNjOGs+sPJXfYDNJIfqq4kzDIQPK4pisa690bd2H8+9kH+zGp dISTjeWk4+f8H+M1CJVJZqxNWTYx3g== =lCt6 -----END PGP SIGNATURE----- --5nl4r2jq5dzig4bb--