Re: [PATCH vhost 04/23] vdpa/mlx5: Drop redundant check in teardown_virtqueues()

Eugenio Perez Martin
2024-06-19T10:56:58Z

On Mon, Jun 17, 2024 at 5:08 PM Dragos Tatulea <dtatulea@nvidia.com> wrote:
>
> The check is done inside teardown_vq().
>
> Signed-off-by: Dragos Tatulea <dtatulea@nvidia.com>
> Reviewed-by: Cosmin Ratiu <cratiu@nvidia.com>

Reviewed-by: Eugenio Pérez <eperezma@redhat.com>

> ---
> drivers/vdpa/mlx5/net/mlx5_vnet.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> index b4d9ef4f66c8..96782b34e2b2 100644
> --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> @@ -2559,16 +2559,10 @@ static int setup_virtqueues(struct mlx5_vdpa_dev *mvdev)
>
> static void teardown_virtqueues(struct mlx5_vdpa_net *ndev)
> {
> - struct mlx5_vdpa_virtqueue *mvq;
> int i;
>
> - for (i = ndev->mvdev.max_vqs - 1; i >= 0; i--) {
> - mvq = &ndev->vqs[i];
> - if (!mvq->initialized)
> - continue;
> -
> - teardown_vq(ndev, mvq);
> - }
> + for (i = ndev->mvdev.max_vqs - 1; i >= 0; i--)
> + teardown_vq(ndev, &ndev->vqs[i]);
> }
>
> static void update_cvq_info(struct mlx5_vdpa_dev *mvdev)
>
> --
> 2.45.1
>