From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0149B3C553A for ; Mon, 20 Apr 2026 20:06:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776715585; cv=none; b=ZnZu06wu0d8JYFEcng/xnZ/ZEg2A3QFNSDkd5ZVi526jyOCTZaI5JkamNF6e8+xU0/DV/P9x5KAcBu2eoUKZRe4FlmJloFH6UBPYPPto5kkDIMTAqavL2MF/gnyFHezKsAcyZZ9b0onEcrBttY4WGjYbHEOPp3VdV2jMHpJrJ6M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776715585; c=relaxed/simple; bh=b89JOdWc2tHnz0JBm0XSYjGwA2IuoPpOvjwTZ1/Lux0=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=bkrXD82KPdILc8QX7TCP2uqm4QzkbUXEyMRPI388AClUIh6BFTzHBWONWaESkOBMf9tyqf+8BRK8AKijadTEXxRY29HjzwP/hKeBQdZr8bQkPh1wObWFXlMZmwQ1P7lkdBzdstfOe4OXUGw5P2tu5mnlMhMaVUkue8fE0kwe8uE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=QaLtUNkG; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="QaLtUNkG" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-358e425c261so3880668a91.3 for ; Mon, 20 Apr 2026 13:06:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1776715583; x=1777320383; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=TZxYUqD2nNuvPN56vUHQyfWGRkh1zwfXr7oE1wyS0SA=; b=QaLtUNkG4C2izbFKIp82iAhLIPN4+kVc5zwSDSb1x8nQq1j0SaCXJlpn6x14uKBSlW 7kfFrWGBM9SnKRmE07Dw764I961yx+zYX/5obhWTwRqwahb6QaIXBCNRC12kj1YCUus7 PfPZwd7qMsDcNF7rOlAV16ojzwPSjgPZD9P9Pxo6OndTRFk8c1vTXJXWVQByWVd66WC4 40jKDX8AnKp+fLItkoIFmE4Pc5+bS1kQ9OlFFFFpecV6OMm/B8nlYEqvJEo2JVtz8p7R Yjt7XxBXXgZAXrKgUbgUr0jQnRIEQl7gkEggH6YgKQ73hjpBJBbZ0nDay44Dpmuhgai/ 9kFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776715583; x=1777320383; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TZxYUqD2nNuvPN56vUHQyfWGRkh1zwfXr7oE1wyS0SA=; b=r6NO+Nme/OOHS6l/pJnQaOX/yk9O/3JYcmfcfMPFCCdK679XXBXZVPUdCttJYBT8YX zcIA2RsoTK/IVZMrz4u7WB38Wdx06FAplTo7DxjS69nCGprMpI3jpt/kPyRnDcqxZHGv +bWFngv5TDIqnrz2bIU9WPLYBBUJqrErVIzc5DqxIQvXVJDAL4mi0fimzLoUc8KLJAHs KwTkW/N1GhxAQr7HnPRjovKyTKiep2VeeaX4i34sczIbf+eUloGEiuJPwQedqCpa9yYU dbKdHxswQOv1pUfNWSEMJlqTGZ3JieMk+gihi5Z0Lqus6ji0h9718U/LHYL8VmhHtX+w FTAw== X-Forwarded-Encrypted: i=1; AFNElJ/GyFRxPZsWv29N51G9c89SOTrsL/i6bFtevmVboVWHP4BK7O9Pciv2lkXO0FHbQHLbp2nCXESNR5ZxIv0=@vger.kernel.org X-Gm-Message-State: AOJu0YwtnlllZhWK4vSGpUGXjQzjZFgIu1PBCb7O7R5QWmG6PQMeL4w9 UWRl+MAfD7llVejeh8TM8usQthJOoFHsNdLhBNiFgKXIZ44Woze13pMWsVaw88iXEkc32g12L0u tfQpFHg== X-Received: from pjbkx16.prod.google.com ([2002:a17:90b:2290:b0:35f:c299:a451]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:164a:b0:35b:96bb:47ba with SMTP id 98e67ed59e1d1-361404c0ca8mr14786253a91.26.1776715583185; Mon, 20 Apr 2026 13:06:23 -0700 (PDT) Date: Mon, 20 Apr 2026 13:06:21 -0700 In-Reply-To: <20260220004223.4168331-2-dmatlack@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260220004223.4168331-1-dmatlack@google.com> <20260220004223.4168331-2-dmatlack@google.com> Message-ID: Subject: Re: [PATCH v2 01/10] KVM: selftests: Use gva_t instead of vm_vaddr_t From: Sean Christopherson To: David Matlack Cc: Paolo Bonzini , Ackerley Tng , Albert Ou , Alexandre Ghiti , Andrew Jones , Anup Patel , Atish Patra , Bibo Mao , Christian Borntraeger , Claudio Imbrenda , Colin Ian King , David Hildenbrand , Fuad Tabba , Huacai Chen , James Houghton , Janosch Frank , Joey Gouly , kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-riscv@lists.infradead.org, Lisa Wang , loongarch@lists.linux.dev, Marc Zyngier , Maxim Levitsky , Nutty Liu , Oliver Upton , Palmer Dabbelt , Paul Walmsley , "Pratik R. Sampat" , Rahul Kumar , Shuah Khan , Suzuki K Poulose , Tianrui Zhao , Wu Fei , Yosry Ahmed , Zenghui Yu Content-Type: text/plain; charset="us-ascii" On Fri, Feb 20, 2026, David Matlack wrote: > Replace all occurrences of vm_vaddr_t with gva_t to align with KVM code > and with the conversion helpers (e.g. addr_gva2hva()). Also replace > vm_vaddr in function names with gva to align with the new type name. ... > @@ -716,22 +716,22 @@ void vm_mem_region_move(struct kvm_vm *vm, uint32_t slot, uint64_t new_gpa); > void vm_mem_region_delete(struct kvm_vm *vm, uint32_t slot); > struct kvm_vcpu *__vm_vcpu_add(struct kvm_vm *vm, uint32_t vcpu_id); > void vm_populate_vaddr_bitmap(struct kvm_vm *vm); > -vm_vaddr_t vm_vaddr_unused_gap(struct kvm_vm *vm, size_t sz, vm_vaddr_t vaddr_min); > -vm_vaddr_t vm_vaddr_alloc(struct kvm_vm *vm, size_t sz, vm_vaddr_t vaddr_min); > -vm_vaddr_t __vm_vaddr_alloc(struct kvm_vm *vm, size_t sz, vm_vaddr_t vaddr_min, > - enum kvm_mem_region_type type); > -vm_vaddr_t vm_vaddr_alloc_shared(struct kvm_vm *vm, size_t sz, > - vm_vaddr_t vaddr_min, > - enum kvm_mem_region_type type); > -vm_vaddr_t vm_vaddr_alloc_pages(struct kvm_vm *vm, int nr_pages); > -vm_vaddr_t __vm_vaddr_alloc_page(struct kvm_vm *vm, > - enum kvm_mem_region_type type); > -vm_vaddr_t vm_vaddr_alloc_page(struct kvm_vm *vm); > +gva_t gva_unused_gap(struct kvm_vm *vm, size_t sz, gva_t vaddr_min); > +gva_t gva_alloc(struct kvm_vm *vm, size_t sz, gva_t vaddr_min); > +gva_t __gva_alloc(struct kvm_vm *vm, size_t sz, gva_t vaddr_min, > + enum kvm_mem_region_type type); > +gva_t gva_alloc_shared(struct kvm_vm *vm, size_t sz, > + gva_t vaddr_min, > + enum kvm_mem_region_type type); > +gva_t gva_alloc_pages(struct kvm_vm *vm, int nr_pages); > +gva_t __gva_alloc_page(struct kvm_vm *vm, > + enum kvm_mem_region_type type); > +gva_t gva_alloc_page(struct kvm_vm *vm); The existing vm_vaddr_alloc() and friends are pretty bad names. gva_alloc() is far, far worse. The APIs aren't just allocation a guest virtual address, they're allocating guest physical memory, finding a usable virtual address, and creating mappings. I don't see any reason to have vaddr or gva in the name. E.g. malloc() isn't virt_malloc(). But I do think they need to be explicitly scoped to KVM, and to a VM. I'll drop API renames from this patch, and rename them to vm_alloc() and friends in a separate patch. Amusingly, that naming scheme will still work if "vm" is misconstrued as "virtual memory" instead of "virtual machine". P.S. This is a great example of why I insist on one logical change per patch, with judicious exemptions for opportunistic cleanups/changes. If this has been a separate patch, it would have taken me all of two seconds to unwind. As it was, I spent a good 10-15 minutes dealing with this. In large part because I kept making goofs, but that's the whole point: there was no reason to put me in a position to make goofs. The other argument against these sorts of "Also do xyz" add-ons is that of a slippery slope. Why rename these APIs in this patch, but not the myriad vaddr variables? Then after a few "I'll just clean this up too" changes, there's an entire series in what is purportedly just a typedef rename.