From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f49.google.com (mail-dl1-f49.google.com [74.125.82.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 074623C7DE8 for ; Mon, 30 Mar 2026 18:15:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894508; cv=none; b=ZQgCgxvaxeCPM0GKU9GC+PLzUtM065RApDOvkadWvQgYnBDVqeax/qXzecCaVtVJMJiv/Eqv8tfavfmWeh1G/nJBlRuitkn7jzQpYVq972kftEN+0Nor3Wkj0afX2Z/adrMfuJUqL7p7l9n37IhLiL5oPKKhO7tfOn/29YRwC1E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894508; c=relaxed/simple; bh=Z0VU27kp+EiqqnBSSicMghyKj31cSkFU4hmQ8/ef5W0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cfiLFZrp6pEp8K47WwYc8M/47aPv8+D4JD603riPIE5+VJtqgvDD58h1p7CLKbaEsRdnP7oIP5/3LGiZZSZUFIYsFF6RmbjcPgt73XspqMscZ2ybRqW0W+ec+6VhmHYG4VfNBDwqs5Yuvq8JiBu9rYN1k5RGDc6Tf9lqEL4b8ns= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y7qt/M4r; arc=none smtp.client-ip=74.125.82.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y7qt/M4r" Received: by mail-dl1-f49.google.com with SMTP id a92af1059eb24-12732165d1eso6655727c88.1 for ; Mon, 30 Mar 2026 11:15:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774894506; x=1775499306; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pOJfBRB99YZhtUsegm8iktYsZnnKxVREnxVNFeF5TrQ=; b=Y7qt/M4rhOyUADD4ca8igdqqaX5eqlDrK841/s3hkc619bm3HSDz6wpXJO0Du5qqPt md9kT2K9Q/QYcE5cr+Q0UgWpDUjcTsVboV4BxTYWdWdUksqTb2GknZ96h6347BAf1jVX /U5C3zsnQvRq5OBJxK2CrBTMKxv3JDD7SdvKUiAtaFUFBpC3zrKZLYnxg0NfWDs5T92o MdTBdG5Lx06hjG4/QSEHkFx2ezmNi4LD1aHc/4kMb0r0t8qV0HQ+FX+/QXTVgUgcONJv NYJlSeFEeqcbuUZNWPxCoFGUpcpP2VhnxGHd1sUmUIb3W/XnUPf3f12B9rnNVxFMwhm9 8vRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774894506; x=1775499306; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pOJfBRB99YZhtUsegm8iktYsZnnKxVREnxVNFeF5TrQ=; b=ljoMiBl8QriAtkMfWazRoHuzSeJk0hWjtZagooIR5PDmH/fTisgea2snMR8FGOg9Hx oi0e9DkDhVOkEClnVvqp+OeTI3AN8wRjk/erAx1JxKHluvLwAPy9xIa3OdYnDpSWYJnE mUqsvq3Geo0zp3uvbDsFopImQLpTUo2hmroqP6C2f8clno0Y3y6mP+rJyE4Q3NelFyhP SmfATjz3oHXjrs3UsMLsrZJ7YARLc6fOg4McvpMztgEJIQVXEqCoaO5T7SIgrKj1C0R3 rXbgu1TASHZkkKj07UjUHZtIhZNzdjEisRJ1skcr/XNjH5+b+aWAWFlTsMpx6xWLHLH1 rv7g== X-Forwarded-Encrypted: i=1; AJvYcCUM1gmtAmWNsh/8XZvs4knJq5CO7lQ69t/gW/yrhRaXrbwvS1u1/1XJhXRjWxxUnScA3uCfC1xUrXgXdrk=@vger.kernel.org X-Gm-Message-State: AOJu0YyDDnp3Rp+mHcfJaZ0waJInYeQDqSV/wNn2BB6FdYnOlhEt0mPE dw4GIGMDcXFUxosdMrUxBciO2S4CF6OFvqEJeuLXTVJS1qcBPnc8PmMh X-Gm-Gg: ATEYQzxia+0A1wyZ7IbSk9Z7KBWryNTfM1x2NCvtGWjxA7gXTRcev9ALcHCfHJY+GfU lQ1FEXTtwAMpGpuRGtIsaNTblYS7PZp+9lN4U2NGzpafnrnmvylIlgMDWBTvAFv1kQO+qz8voSO /m4H8NjTGmaB03q0rUD0rbNx+EorbN+VPxdzQJ2MgWWIFaEk8trlrsZ8iYlL2Xv6cf6iHaEHiJO e5DOBrRX7Cm1gwRvnEQ2k0egRmIEGL7A+DxG3DAad0B2qk7K+1HHdrNkFW9qwkvTrbduw6+N22S UVNZkd5bLU2mC7MyOqgJ73Fz+U86xVKstkYSSG/556N8EQJV5eggtaTFFhlMAm9GyDkeiSDZGR8 dV2h5snxNuPISPYhnriU2L+TqiBVGsT3SOQJ0NmmRMMHNyobwJsIoe7p/+b35uHMgfb5e4cwY3g x0/wMmHNBt2xjEvKtOWCuxj+CK7AH7wNTFWF/AAt6xPSaK4ycRXkdbPGgxYkhR2TZyIojQZXL20 2VcDKYyr/ae X-Received: by 2002:a05:7022:f102:b0:128:cf75:42a3 with SMTP id a92af1059eb24-12ab28d157dmr7026576c88.21.1774894505880; Mon, 30 Mar 2026 11:15:05 -0700 (PDT) Received: from ?IPV6:2a03:83e0:1151:15:c56:221b:35d5:85f? ([2620:10d:c090:500::1:79e]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12ab97d88c0sm12032304c88.5.2026.03.30.11.15.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Mar 2026 11:15:05 -0700 (PDT) Message-ID: Date: Mon, 30 Mar 2026 11:15:03 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3 1/6] net: bcmgenet: convert RX path to page_pool To: Nicolai Buchwitz , netdev@vger.kernel.org Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Vikas Gupta , Rajashekar Hudumula , Bhargava Marreddy , Eric Biggers , Arnd Bergmann , linux-kernel@vger.kernel.org References: <20260319115402.353509-1-nb@tipi-net.de> <20260319115402.353509-2-nb@tipi-net.de> Content-Language: en-US From: Mohsin Bashir In-Reply-To: <20260319115402.353509-2-nb@tipi-net.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > if (priv->crc_fwd_en) { > - skb_trim(skb, len - ETH_FCS_LEN); > + skb_trim(skb, skb->len - ETH_FCS_LEN); > len -= ETH_FCS_LEN; Looks like 'len' update here is unnecessary since we are overwriting it later anyway? > } > > + /* Set up checksum offload */ > + if (dev->features & NETIF_F_RXCSUM) { > + rx_csum = (__force __be16)(status->rx_csum & 0xffff); > + if (rx_csum) { > + skb->csum = (__force __wsum)ntohs(rx_csum); > + skb->ip_summed = CHECKSUM_COMPLETE; > + } > + } > + > + len = skb->len;