From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9069C432BE for ; Thu, 19 Aug 2021 15:07:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA0A760EFE for ; Thu, 19 Aug 2021 15:07:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239460AbhHSPHg (ORCPT ); Thu, 19 Aug 2021 11:07:36 -0400 Received: from mga05.intel.com ([192.55.52.43]:32319 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239184AbhHSPH3 (ORCPT ); Thu, 19 Aug 2021 11:07:29 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10081"; a="302160647" X-IronPort-AV: E=Sophos;i="5.84,335,1620716400"; d="scan'208";a="302160647" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2021 08:06:52 -0700 X-IronPort-AV: E=Sophos;i="5.84,335,1620716400"; d="scan'208";a="522471382" Received: from crojewsk-mobl1.ger.corp.intel.com (HELO [10.213.19.151]) ([10.213.19.151]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2021 08:06:50 -0700 Subject: Re: [PATCH v2] ASoC: Intel: Fix platform ID matching for kbl_da7219_max98373 To: Pierre-Louis Bossart , Lukasz Majczak Cc: upstream@semihalf.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Curtis Malainey , stable@vger.kernel.org References: <20210819082414.39497-1-lma@semihalf.com> <87736cce-a96f-064e-6d60-71645ba46f13@linux.intel.com> From: Cezary Rojewski Message-ID: Date: Thu, 19 Aug 2021 17:06:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <87736cce-a96f-064e-6d60-71645ba46f13@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-08-19 4:30 PM, Pierre-Louis Bossart wrote: > On 8/19/21 3:24 AM, Lukasz Majczak wrote: >> Sparse warnings triggered truncating the IDs of some platform device >> tables. Unfortunately kbl_da7219_max98373 was also truncated. >> This patch is reverting the original ID. >> Tested on Atlas chromebook. > > Instead of reverting, how about changing the remaining occurrences of > the old name in the machine driver? > > sound/soc/intel/boards/kbl_da7219_max98927.c: if (!strcmp(pdev->name, > "kbl_da7219_max98373") || > sound/soc/intel/boards/kbl_da7219_max98927.c: .name = > "kbl_da7219_max98373", Mentioned by 'Fixes' tag patch clearly introduced regression. If we are to update any name-fields, it's better to have a fresh start and update all the boards in one-go than doing so separately. Apart from that, Maxim codecs go by the name of 'max' in sound/soc/codecs/. It's more intuitive to have equivalent shortcut used in board's name. Regards, Czarek