From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13742C2EA
	for <linux-kernel@vger.kernel.org>; Tue, 21 Apr 2026 00:25:02 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1776731103; cv=none; b=ubcjQf0pzRkcnI3ERUG57vN7/htiCweO8HEeA893uKAPy/L2lQRXkROR1xSvaA8uODOKtFM54dPTO/8oJLpFx/QI5NIE5sMfbvkjf9iaSjbc3Xv4D1R3SFCQUSglNtxS6ReM4PbvLhDqY7jP4O9SKzUIS8ogcTn2Bwzv7Nl6tFU=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1776731103; c=relaxed/simple;
	bh=rnxdnKiMKIW0HVG/+B71u0+mC82dk058+mZabZsQ66E=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=Sldkcna2PRHFDmtusGTjUsCWhZSlW3pyIwvbMzuZ4MXF3dNa4gunAhaBA9krEZUSbpZEsmD314gTerDVno7ru1eJJYQmTx7yg9GsgAOvM6OZdTDTURmgDBYgDEctMGcSRgmJ2dH3px0drj4eXI9T6aunUJw/hadoxK2V0FTgid8=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LTg8EIlH; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LTg8EIlH"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6CE46C19425;
	Tue, 21 Apr 2026 00:25:02 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1776731102;
	bh=rnxdnKiMKIW0HVG/+B71u0+mC82dk058+mZabZsQ66E=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=LTg8EIlH4Q5UpiqsqdhmK3hBUER6Ja6d+ckbUwBQLsKb4ZXogB2BfDwCLoILcAhC3
	 SEgNo2dPxzmUaqouNzc6uPPf9w/dC7FmJKhL0dAPhaxUW0zO5n2IqnYqWairD5/ZA+
	 SENz14LJC/I7mwhqQleXzy6KuTRfFMfzLtfyT8whp3yyKy6PCaxXxknM1Nh4wAJ915
	 DLnHcc+gi6C7SSyNlXKunHeyKn5JBkS17wd+/H226B7F+/LMqlI+0aS8BnistegUcG
	 BDl1F1Nu3WcB6juYwHiESMYLsQTLuRhFG+5EFLr9X50vCkBjRft91vxclNtIhuSx8m
	 4Ehh5O7HwQ6JQ==
Date: Mon, 20 Apr 2026 18:25:00 -0600
From: Keith Busch <kbusch@kernel.org>
To: Chao Shi <coshi036@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>, linux-nvme@lists.infradead.org,
	linux-kernel@vger.kernel.org, Daniel Wagner <dwagner@suse.de>,
	Maurizio Lombardi <mlombardi@redhat.com>
Subject: Re: [PATCH v2 0/1] nvme: core: reject invalid LBA data size from
 Identify Namespace
Message-ID: <aebD3CqLTrD7T1JH@kbusch-mbp>
References: <20260418042835.420281-1-coshi036@gmail.com>
 <20260420231116.748204-1-coshi036@gmail.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260420231116.748204-1-coshi036@gmail.com>

On Mon, Apr 20, 2026 at 07:11:13PM -0400, Chao Shi wrote:
> On Mon, Apr 20, 2026 at 02:51:00PM -0700, Keith Busch wrote:
> 
> Fixed in v2.
> 
> > you're missing the corresponding queue_limits_cancel_update() for this
> > error case.
> 
> Added in both error paths in v2.

Not quite what I suggested. Instead, if you move up the validation
checks, you don't have any cleanup in the error case to do.

And don't bother splitting the error cases. The message about the "0"
LBADS is in reference to the the broadcast identification. It's never
valid for a controller to return an unusable flbas index value for an
attached namespace.